Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update instruction to cleanup a dashboard #1589

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

YashSartanpara1
Copy link
Contributor

No description provided.

@@ -12,6 +12,39 @@ Before submitting code or documentation contributions, you should first complete

Before you can contribute, we kindly ask you to sign our [Contributor License Agreement](https://cla-assistant.percona.com/percona/grafana-dashboards) (CLA). You can do this using your GitHub account and one click.

## Rules and Guidelines

Development Rules and Best Practices while creating a new dashboard -
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't link the internal document ( .
not sure is the overall PMM doc or if we should put this to the Dashboards repo?

I would vote for placing this to some reference page in the overall PMM documentation (pmm-doc repo )
@catalinaadam ^ WDYT

Copy link

@catalinaadam catalinaadam Apr 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rnovikovP - yep, I can move this info to a new topic under the Details chapter. (I guess this is similar to the Develop Advisors topic which we host there).
This Contributing file would then only reference that new topic.

@@ -12,6 +12,39 @@ Before submitting code or documentation contributions, you should first complete

Before you can contribute, we kindly ask you to sign our [Contributor License Agreement](https://cla-assistant.percona.com/percona/grafana-dashboards) (CLA). You can do this using your GitHub account and one click.

## Rules and Guidelines

Development Rules and Best Practices while creating a new dashboard -
Copy link

@catalinaadam catalinaadam Apr 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rnovikovP - yep, I can move this info to a new topic under the Details chapter. (I guess this is similar to the Develop Advisors topic which we host there).
This Contributing file would then only reference that new topic.

@@ -12,6 +12,39 @@ Before submitting code or documentation contributions, you should first complete

Before you can contribute, we kindly ask you to sign our [Contributor License Agreement](https://cla-assistant.percona.com/percona/grafana-dashboards) (CLA). You can do this using your GitHub account and one click.
Copy link

@catalinaadam catalinaadam Apr 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Before you can contribute, we kindly ask you to sign our [Contributor License Agreement](https://cla-assistant.percona.com/percona/grafana-dashboards) (CLA). You can do this using your GitHub account and one click.
You can easily do so using your GitHub account with just one click.
.```


![Untitled (1)](https://github.com/percona/grafana-dashboards/assets/119680679/14ef97c2-5a5b-45a7-b053-8b2fb1bd257c)


## Submitting a Bug

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also have a "Submitting a Bug" section in the Readme.md topic, which then links back to this Contributing topic. Should we remove that duplicate section from there and leave it under Contributing only?

@ademidoff ademidoff removed their request for review October 21, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants