Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PMM-11963 Add links between nodes and services #678

Merged
merged 3 commits into from
Aug 16, 2023

Conversation

matejkubinec
Copy link
Collaborator

@matejkubinec matejkubinec commented Jul 25, 2023

What this PR does / why we need it:

  • Adds links between service and it's node and back.
  • Adds filtering for Node ID/Service ID on respective pages.

Which issue(s) this PR fixes:

PMM-11963

FB: Percona-Lab/pmm-submodules#3347

Screenshots:

image image

fabio-silva
fabio-silva previously approved these changes Jul 25, 2023
@matejkubinec
Copy link
Collaborator Author

Had to change the filter values change spy to only react on value changes. Having the search field focused and clicking the node/service link would trigger filtering on the new table with old filter values.

@matejkubinec matejkubinec merged commit 5614654 into main Aug 16, 2023
5 of 7 checks passed
@matejkubinec matejkubinec deleted the PMM-11963-services-nodes-linking branch August 16, 2023 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants