Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PMM-13166: Ability to monitor DBs from a different node #766

Merged
merged 35 commits into from
Oct 3, 2024
Merged

PMM-13166: Ability to monitor DBs from a different node #766

merged 35 commits into from
Oct 3, 2024

Conversation

doracretu3pillar
Copy link

Added Nodes and Agents to any service from Inventory->AddService

matejkubinec
matejkubinec requested changes Aug 6, 2024
View reviewed changes
Copy link
Collaborator

@matejkubinec matejkubinec left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, please use a formatter (we should have prettier setup by default) it seems there are inconsistencies with usage of ' and " with spaces around if statements, etc.

And take a look at the CI tests as they seems to be failing.

public/app/percona/add-instance/components/AddRemoteInstance/AddRemoteInstance.service.tsx Outdated Show resolved Hide resolved
public/app/percona/add-instance/components/AddRemoteInstance/AddRemoteInstance.tsx Outdated Show resolved Hide resolved
.../app/percona/add-instance/components/AddRemoteInstance/FormParts/NodesAgents/NodesAgents.tsx Outdated Show resolved Hide resolved
.../app/percona/add-instance/components/AddRemoteInstance/FormParts/NodesAgents/NodesAgents.tsx Outdated Show resolved Hide resolved
.../app/percona/add-instance/components/AddRemoteInstance/FormParts/NodesAgents/NodesAgents.tsx Outdated Show resolved Hide resolved
public/app/percona/shared/core/reducers/nodes/nodes.ts Outdated Show resolved Hide resolved
public/app/percona/shared/core/reducers/nodes/nodes.utils.ts Outdated Show resolved Hide resolved
public/app/percona/shared/core/reducers/nodes/nodes.utils.ts Outdated Show resolved Hide resolved
.../app/percona/add-instance/components/AddRemoteInstance/FormParts/NodesAgents/NodesAgents.tsx Show resolved Hide resolved
.../app/percona/add-instance/components/AddRemoteInstance/FormParts/NodesAgents/NodesAgents.tsx Outdated Show resolved Hide resolved
@matejkubinec
Copy link
Collaborator

There are also multiple errors not fixed when yarn start is running:

image

And in VS code I'm getting quite a lot of squiglies:

image

Related to these eslint errors:

image

matejkubinec
matejkubinec reviewed Sep 10, 2024
View reviewed changes
public/app/percona/inventory/Inventory.types.ts Outdated Show resolved Hide resolved
...na/add-instance/components/AddRemoteInstance/FormParts/NodesAgents/NodesAgents.constants.tsx Outdated Show resolved Hide resolved
...percona/add-instance/components/AddRemoteInstance/FormParts/NodesAgents/NodesAgents.test.tsx Outdated Show resolved Hide resolved
.../app/percona/add-instance/components/AddRemoteInstance/FormParts/NodesAgents/NodesAgents.tsx Outdated Show resolved Hide resolved
.../app/percona/add-instance/components/AddRemoteInstance/FormParts/NodesAgents/NodesAgents.tsx Outdated Show resolved Hide resolved
.../app/percona/add-instance/components/AddRemoteInstance/FormParts/NodesAgents/NodesAgents.tsx Outdated Show resolved Hide resolved
.../app/percona/add-instance/components/AddRemoteInstance/FormParts/NodesAgents/NodesAgents.tsx Outdated Show resolved Hide resolved
public/app/percona/inventory/Tabs/Agents.tsx Outdated Show resolved Hide resolved
public/app/percona/inventory/Tabs/Agents.tsx Outdated Show resolved Hide resolved
public/app/percona/inventory/Tabs/Nodes.tsx Outdated Show resolved Hide resolved
matejkubinec
matejkubinec reviewed Sep 23, 2024
View reviewed changes
public/app/percona/add-instance/components/AddRemoteInstance/AddRemoteInstance.service.test.tsx Outdated Show resolved Hide resolved
...na/add-instance/components/AddRemoteInstance/FormParts/NodesAgents/NodesAgents.constants.tsx Outdated Show resolved Hide resolved
...percona/add-instance/components/AddRemoteInstance/FormParts/NodesAgents/NodesAgents.test.tsx Outdated Show resolved Hide resolved
...percona/add-instance/components/AddRemoteInstance/FormParts/NodesAgents/NodesAgents.test.tsx Outdated Show resolved Hide resolved
...percona/add-instance/components/AddRemoteInstance/FormParts/NodesAgents/NodesAgents.test.tsx Show resolved Hide resolved
...percona/add-instance/components/AddRemoteInstance/FormParts/NodesAgents/NodesAgents.test.tsx Outdated Show resolved Hide resolved
...percona/add-instance/components/AddRemoteInstance/FormParts/NodesAgents/NodesAgents.test.tsx Outdated Show resolved Hide resolved
...percona/add-instance/components/AddRemoteInstance/FormParts/NodesAgents/NodesAgents.test.tsx Outdated Show resolved Hide resolved
.../app/percona/add-instance/components/AddRemoteInstance/FormParts/NodesAgents/NodesAgents.tsx Outdated Show resolved Hide resolved
@matejkubinec matejkubinec merged commit 7acb1ea into v3 Oct 3, 2024
2 of 3 checks passed
@matejkubinec matejkubinec deleted the PMM-13166_nodes_monitor_db branch October 3, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BupycHuk BupycHuk BupycHuk left review comments

@DoraCretu594118 DoraCretu594118 DoraCretu594118 left review comments

@matejkubinec matejkubinec matejkubinec approved these changes

@YashSartanpara1 YashSartanpara1 Awaiting requested review from YashSartanpara1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@doracretu3pillar @matejkubinec @DoraCretu594118 @BupycHuk