PMM-13428 Fix add remote instance issues. #784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ademidoff
reviewed
Nov 7, 2024
| form?.change('address', 'localhost'); | ||
| } else { | ||
| form?.change('address', ''); | ||
| console.log(form?.getState().values?.address); |
There was a problem hiding this comment.
Suggested change
| console.log(form?.getState().values?.address); |
| } else { | ||
| form?.change('address', ''); | ||
| console.log(form?.getState().values?.address); | ||
| if (form?.getState().values?.address === undefined || form?.getState().values?.address === '' ) { |
There was a problem hiding this comment.
Suggested change
| if (form?.getState().values?.address === undefined || form?.getState().values?.address === '' ) { | |
| if (!form?.getState().values?.address) { |
matejkubinec
reviewed
Nov 8, 2024
...percona/add-instance/components/AddRemoteInstance/FormParts/NodesAgents/NodesAgents.types.ts
Outdated
Show resolved
Hide resolved
matejkubinec
requested review from
YashSartanpara1,
ademidoff and
matejkubinec
matejkubinec
approved these changes
Nov 8, 2024
YashSartanpara1
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
It doesn't override address when node or agent is changed.
dropped node/agent selection for HAProxy and External exporter as it doesn't have effect.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: