Skip to content

PMM-14153: Adding timestemp metrics for pbm backups #1108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

theTibi
Copy link

@theTibi theTibi commented Jul 4, 2025

PMM-14153 (optional, if ticket reported)

  • Links to related pull requests (optional).

Below we provide a basic checklist of things that would make it a good PR:

  • Make sure to sign the CLA (Contributor License Agreement).
  • Make sure all tests pass.
  • Keep current with the target branch and fix conflicts if necessary.
  • Update jira ticket description if necessary.
  • Attach screenshots and/or console output to the jira ticket to confirm new behavior, if applicable.
  • Leave notes to the reviewers if you need to focus their attention on something specific.

Once all checks pass and the code is ready for review, please add pmm-review-exporters team as the reviewer. That would assign people from the review team automatically. Report any issues on our Forum.

@theTibi theTibi requested a review from a team as a code owner July 4, 2025 08:54
@theTibi theTibi requested review from BupycHuk and JiriCtvrtka and removed request for a team July 4, 2025 08:54
@it-percona-cla
Copy link

it-percona-cla commented Jul 4, 2025

CLA assistant check
All committers have signed the CLA.

Copy link

codecov bot commented Jul 4, 2025

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 65.29%. Comparing base (dc46ed5) to head (2bdf263).
Report is 110 commits behind head on main.

Files with missing lines Patch % Lines
exporter/pbm_collector.go 0.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1108      +/-   ##
==========================================
- Coverage   70.88%   65.29%   -5.60%     
==========================================
  Files          28       29       +1     
  Lines        3569     3083     -486     
==========================================
- Hits         2530     2013     -517     
- Misses        904      932      +28     
- Partials      135      138       +3     
Flag Coverage Δ
agent 65.29% <0.00%> (-5.60%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@theTibi
Copy link
Author

theTibi commented Jul 7, 2025

I have tested it and it works, metric is created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants