-
Notifications
You must be signed in to change notification settings - Fork 446
Add supporting multi-target dynamic scraping #1120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
iamhalje
wants to merge
13
commits into
percona:main
Choose a base branch
from
iamhalje:multi-target-support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dmitry Ponomaryov <[email protected]>
…ndle concurrent access Signed-off-by: Dmitry Ponomaryov <[email protected]>
Signed-off-by: Dmitry Ponomaryov <[email protected]>
Signed-off-by: Dmitry Ponomaryov <[email protected]>
Signed-off-by: Dmitry Ponomaryov <[email protected]>
Signed-off-by: Dmitry Ponomaryov <[email protected]>
Signed-off-by: Dmitry Ponomaryov <[email protected]>
Signed-off-by: Dmitry Ponomaryov <[email protected]>
Signed-off-by: Dmitry Ponomaryov <[email protected]>
Signed-off-by: Dmitry Ponomaryov <[email protected]>
Signed-off-by: Dmitry Ponomaryov <[email protected]>
Signed-off-by: Dmitry Ponomaryov <[email protected]>
any feedback? can be produced |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces support for multi-target scraping via the
/scrape?target=...
endpoint, even when--mongodb.uri
is configured globally. This allows dynamic discovery and monitoring of MongoDB instances without restarting the exporter, improving integration with Prometheus service discovery and multi-target configurations.https://prometheus.io/docs/guides/multi-target-exporter/
Unlike the previous approach, where scraping was limited to the fixed list of instances specified by
--mongodb.uri
and when need added new host, need restart exported, this change enables flexible, on-demand querying of arbitrary MongoDB targets through the/scrape?target=...
parameter.Related issue: #878 — Multi target without need for specifying --mongodb.uri
Leave notes to the reviewers if you need to focus their attention on something specific:
This change affects core logic related to connection handling and target resolution. Existing setups using
--mongodb.uri
continue to work without changes. At the same time, users can now add dynamic targets seamlessly.If you notice anything that could affect stability or how can do more good with code structure, caching or backward compatibility, especially in edge cases or other contributed rights, please let me know and we fixed this.