Skip to content

K8SPSMDB-1035: Allow empty secretName for backup jobs #1377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 30, 2024
Merged

K8SPSMDB-1035: Allow empty secretName for backup jobs #1377

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3602a9a
Allow empty secretName for backup jobs
tadjik1 Nov 10, 2023
a0ca800
Merge branch 'main' into main
tadjik1 Nov 26, 2023
28aa065
Merge branch 'main' into main
tadjik1 Dec 3, 2023
74f3210
Merge branch 'main' into main
egegunes Jan 19, 2024
63d4409
gofmt
tadjik1 Jan 27, 2024
eeba153
Merge branch 'main' into main
tadjik1 Jan 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions pkg/controller/perconaservermongodb/backup.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,14 +386,16 @@ func (r *ReconcilePerconaServerMongoDB) updatePITR(ctx context.Context, cr *api.
secretName = storage.Azure.CredentialsSecret
}

exists, err := secretExists(ctx, r.client, types.NamespacedName{Name: secretName, Namespace: cr.Namespace})
if err != nil {
return errors.Wrap(err, "check storage credentials secret")
}
if secretName != "" {
exists, err := secretExists(ctx, r.client, types.NamespacedName{Name: secretName, Namespace: cr.Namespace})
if err != nil {
return errors.Wrap(err, "check storage credentials secret")
}

if !exists {
log.Error(nil, "Storage credentials secret does not exist", "secret", secretName)
return nil
if !exists {
log.Error(nil, "Storage credentials secret does not exist", "secret", secretName)
return nil
}
}

err = pbm.SetConfig(ctx, r.client, cr, storage)
Expand Down