K8SPSMDB-1062: Setting appProtocol for service objects#1393
K8SPSMDB-1062: Setting appProtocol for service objects#1393hors merged 14 commits intopercona:mainfrom
Conversation
|
|
|
@sorenmat ping |
|
I'm on it... 👍🏼 sorry for the delay |
3491eb0 to
df4b668
Compare
|
@sorenmat please ensure that you add this new field to every service controlled by the operator |
c9c7eb9 to
61dc1f1
Compare
61dc1f1 to
6415417
Compare
|
Hi @sorenmat! We're working on next PSMDB operator release and if you finish this PR in next 2 weeks we can include this. |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 32 out of 32 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 37 out of 37 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
egegunes
left a comment
There was a problem hiding this comment.
there's a diff in init-deploy
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 39 out of 39 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
commit: 371bdb6 |
|
Hi @sorenmat, we finished this PR and the improvement will be included in the PSMDBO 1.22.0 release. Thank you for your contribution. |
* Setting appProtocol for service objects * Setting appProtocol for service objects * update compare version * small improvement * fix unit-test * change `mongo` to `mongodb` * add appProtocol to mongos service and fix tests * fix unit-tests * fix unit-test * fix `TestReconcileReplsetServices` * switch back to `mongo` * fix init-deploy --------- Co-authored-by: Andrii Dema <a.dema@jazzserve.com> Co-authored-by: Viacheslav Sarzhan <slava.sarzhan@percona.com>
CHANGE DESCRIPTION
Problem:
When running in Istio (perhaps other serice meshes) we need to set the appProtocol to mongo.
This is needed since mongo is a server first protocol, which breaks the mTLS protocol
Cause:
A mongo cluster is not able to form.
Solution:
Just adding mongo as an appProtocol see: https://kubernetes.io/docs/concepts/services-networking/service/#application-protocol
CHECKLIST
Jira
Needs Doc) and QA (Needs QA)?Tests
compare/*-oc.yml)?Config/Logging/Testability