-
Notifications
You must be signed in to change notification settings - Fork 157
K8SPSMDB-755: Allow users to disallow invalid certificates #1523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cat $test_dir/conf/backup.yml | | ||
$sed -e "s/name:/name: ${backup_name}/" | | ||
$sed -e "s/storageName:/storageName: ${storage}/" | | ||
kubectl_bin apply -f - |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[shfmt] reported by reviewdog 🐶
cat $test_dir/conf/backup.yml | | |
$sed -e "s/name:/name: ${backup_name}/" | | |
$sed -e "s/storageName:/storageName: ${storage}/" | | |
kubectl_bin apply -f - | |
cat $test_dir/conf/backup.yml \ | |
| $sed -e "s/name:/name: ${backup_name}/" \ | |
| $sed -e "s/storageName:/storageName: ${storage}/" \ | |
| kubectl_bin apply -f - |
cat $test_dir/conf/restore.yml | | ||
$sed -e "s/name:/name: restore-${backup_name}/" | | ||
$sed -e "s/backupName:/backupName: ${backup_name}/" | | ||
kubectl_bin apply -f - |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[shfmt] reported by reviewdog 🐶
cat $test_dir/conf/restore.yml | | |
$sed -e "s/name:/name: restore-${backup_name}/" | | |
$sed -e "s/backupName:/backupName: ${backup_name}/" | | |
kubectl_bin apply -f - | |
cat $test_dir/conf/restore.yml \ | |
| $sed -e "s/name:/name: restore-${backup_name}/" \ | |
| $sed -e "s/backupName:/backupName: ${backup_name}/" \ | |
| kubectl_bin apply -f - |
lbEndpoint=$(kubectl_bin get svc $cluster-mongos -o=jsonpath='{.status}' | | ||
jq -r 'select(.loadBalancer != null and .loadBalancer.ingress != null and .loadBalancer.ingress != []) | .loadBalancer.ingress[0][]') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[shfmt] reported by reviewdog 🐶
lbEndpoint=$(kubectl_bin get svc $cluster-mongos -o=jsonpath='{.status}' | | |
jq -r 'select(.loadBalancer != null and .loadBalancer.ingress != null and .loadBalancer.ingress != []) | .loadBalancer.ingress[0][]') | |
lbEndpoint=$(kubectl_bin get svc $cluster-mongos -o=jsonpath='{.status}' \ | |
| jq -r 'select(.loadBalancer != null and .loadBalancer.ingress != null and .loadBalancer.ingress != []) | .loadBalancer.ingress[0][]') |
cat $test_dir/conf/backup.yml | | ||
$sed -e "s/name:/name: ${backup_name}/" | | ||
$sed -e "s/storageName:/storageName: ${storage}/" | | ||
kubectl_bin apply -f - |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[shfmt] reported by reviewdog 🐶
cat $test_dir/conf/backup.yml | | |
$sed -e "s/name:/name: ${backup_name}/" | | |
$sed -e "s/storageName:/storageName: ${storage}/" | | |
kubectl_bin apply -f - | |
cat $test_dir/conf/backup.yml \ | |
| $sed -e "s/name:/name: ${backup_name}/" \ | |
| $sed -e "s/storageName:/storageName: ${storage}/" \ | |
| kubectl_bin apply -f - |
cat $test_dir/conf/restore.yml | | ||
$sed -e "s/name:/name: restore-${backup_name}/" | | ||
$sed -e "s/backupName:/backupName: ${backup_name}/" | | ||
kubectl_bin apply -f - |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[shfmt] reported by reviewdog 🐶
cat $test_dir/conf/restore.yml | | |
$sed -e "s/name:/name: restore-${backup_name}/" | | |
$sed -e "s/backupName:/backupName: ${backup_name}/" | | |
kubectl_bin apply -f - | |
cat $test_dir/conf/restore.yml \ | |
| $sed -e "s/name:/name: restore-${backup_name}/" \ | |
| $sed -e "s/backupName:/backupName: ${backup_name}/" \ | |
| kubectl_bin apply -f - |
commit: 7a83d41 |
CHANGE DESCRIPTION
Problem:
--sslAllowInvalidCertificates
are hardcoded and there's no way to change it.Solution:
Add a new field to let users control it.
CHECKLIST
Jira
Needs Doc
) and QA (Needs QA
)?Tests
compare/*-oc.yml
)?Config/Logging/Testability