Skip to content

Conversation

egegunes
Copy link
Contributor

@egegunes egegunes commented Apr 17, 2024

K8SPSMDB-755 Powered by Pull Request Badge

CHANGE DESCRIPTION

Problem:
--sslAllowInvalidCertificates are hardcoded and there's no way to change it.

Solution:
Add a new field to let users control it.

CHECKLIST

Jira

  • Is the Jira ticket created and referenced properly?
  • Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
  • Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

  • Is an E2E test/test case added for the new feature/change?
  • Are unit tests added where appropriate?
  • Are OpenShift compare files changed for E2E tests (compare/*-oc.yml)?

Config/Logging/Testability

  • Are all needed new/changed options added to default YAML files?
  • Did we add proper logging messages for operator actions?
  • Did we ensure compatibility with the previous version or cluster upgrade process?
  • Does the change support oldest and newest supported MongoDB version?
  • Does the change support oldest and newest supported Kubernetes version?

@pull-request-size pull-request-size bot added the size/L 100-499 lines label Apr 17, 2024
Comment on lines +13 to +16
cat $test_dir/conf/backup.yml |
$sed -e "s/name:/name: ${backup_name}/" |
$sed -e "s/storageName:/storageName: ${storage}/" |
kubectl_bin apply -f -
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[shfmt] reported by reviewdog 🐶

Suggested change
cat $test_dir/conf/backup.yml |
$sed -e "s/name:/name: ${backup_name}/" |
$sed -e "s/storageName:/storageName: ${storage}/" |
kubectl_bin apply -f -
cat $test_dir/conf/backup.yml \
| $sed -e "s/name:/name: ${backup_name}/" \
| $sed -e "s/storageName:/storageName: ${storage}/" \
| kubectl_bin apply -f -

Comment on lines +22 to +25
cat $test_dir/conf/restore.yml |
$sed -e "s/name:/name: restore-${backup_name}/" |
$sed -e "s/backupName:/backupName: ${backup_name}/" |
kubectl_bin apply -f -
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[shfmt] reported by reviewdog 🐶

Suggested change
cat $test_dir/conf/restore.yml |
$sed -e "s/name:/name: restore-${backup_name}/" |
$sed -e "s/backupName:/backupName: ${backup_name}/" |
kubectl_bin apply -f -
cat $test_dir/conf/restore.yml \
| $sed -e "s/name:/name: restore-${backup_name}/" \
| $sed -e "s/backupName:/backupName: ${backup_name}/" \
| kubectl_bin apply -f -

Comment on lines +80 to +81
lbEndpoint=$(kubectl_bin get svc $cluster-mongos -o=jsonpath='{.status}' |
jq -r 'select(.loadBalancer != null and .loadBalancer.ingress != null and .loadBalancer.ingress != []) | .loadBalancer.ingress[0][]')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[shfmt] reported by reviewdog 🐶

Suggested change
lbEndpoint=$(kubectl_bin get svc $cluster-mongos -o=jsonpath='{.status}' |
jq -r 'select(.loadBalancer != null and .loadBalancer.ingress != null and .loadBalancer.ingress != []) | .loadBalancer.ingress[0][]')
lbEndpoint=$(kubectl_bin get svc $cluster-mongos -o=jsonpath='{.status}' \
| jq -r 'select(.loadBalancer != null and .loadBalancer.ingress != null and .loadBalancer.ingress != []) | .loadBalancer.ingress[0][]')

Comment on lines +13 to +16
cat $test_dir/conf/backup.yml |
$sed -e "s/name:/name: ${backup_name}/" |
$sed -e "s/storageName:/storageName: ${storage}/" |
kubectl_bin apply -f -
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[shfmt] reported by reviewdog 🐶

Suggested change
cat $test_dir/conf/backup.yml |
$sed -e "s/name:/name: ${backup_name}/" |
$sed -e "s/storageName:/storageName: ${storage}/" |
kubectl_bin apply -f -
cat $test_dir/conf/backup.yml \
| $sed -e "s/name:/name: ${backup_name}/" \
| $sed -e "s/storageName:/storageName: ${storage}/" \
| kubectl_bin apply -f -

Comment on lines +22 to +25
cat $test_dir/conf/restore.yml |
$sed -e "s/name:/name: restore-${backup_name}/" |
$sed -e "s/backupName:/backupName: ${backup_name}/" |
kubectl_bin apply -f -
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[shfmt] reported by reviewdog 🐶

Suggested change
cat $test_dir/conf/restore.yml |
$sed -e "s/name:/name: restore-${backup_name}/" |
$sed -e "s/backupName:/backupName: ${backup_name}/" |
kubectl_bin apply -f -
cat $test_dir/conf/restore.yml \
| $sed -e "s/name:/name: restore-${backup_name}/" \
| $sed -e "s/backupName:/backupName: ${backup_name}/" \
| kubectl_bin apply -f -

@egegunes egegunes added this to the v1.16.0 milestone Apr 18, 2024
@JNKPercona
Copy link
Collaborator

Test name Status
arbiter passed
balancer passed
custom-replset-name passed
cross-site-sharded passed
data-at-rest-encryption passed
data-sharded passed
demand-backup passed
demand-backup-eks-credentials passed
demand-backup-physical passed
demand-backup-physical-sharded passed
demand-backup-sharded passed
expose-sharded passed
ignore-labels-annotations passed
init-deploy passed
finalizer passed
ldap passed
ldap-tls passed
limits passed
liveness passed
mongod-major-upgrade passed
mongod-major-upgrade-sharded passed
monitoring-2-0 passed
multi-cluster-service passed
non-voting passed
one-pod passed
operator-self-healing-chaos passed
pitr passed
pitr-sharded passed
pitr-physical passed
pvc-resize passed
recover-no-primary passed
rs-shard-migration passed
scaling passed
scheduled-backup passed
security-context passed
self-healing-chaos passed
service-per-pod passed
serviceless-external-nodes passed
smart-update passed
split-horizon passed
storage passed
tls-issue-cert-manager passed
upgrade passed
upgrade-consistency passed
upgrade-consistency-sharded-tls passed
upgrade-sharded passed
users passed
version-service passed
We run 48 out of 48

commit: 7a83d41
image: perconalab/percona-server-mongodb-operator:PR-1523-7a83d412

@egegunes egegunes marked this pull request as ready for review April 18, 2024 12:56
@egegunes egegunes merged commit 1e74f86 into main Apr 19, 2024
@egegunes egegunes deleted the K8SPSMDB-755 branch April 19, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/L 100-499 lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants