K8SPSMDB-1056: S3 storage delete-backup finalizer without secrets #1524
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGE DESCRIPTION
Problem:
We can create a backup on S3 storage without secrets if we have EKS cluster with
iam.attachPolicyARNs
configured. The problem is we don't support this when deleting backups withdelete-backup
finalizer.Cause:
In executing
delete-backup
finalizer we strictly require thatcr.Status.S3.CredentialsSecret
is present.Solution:
Rely on
cr.Status.S3.CredentialsSecret
only if the user sets it, otherwise proceed and creds will be handled by correctiam.attachPolicyARNs
configured.CHECKLIST
Jira
Needs Doc
) and QA (Needs QA
)?Tests
compare/*-oc.yml
)?Config/Logging/Testability