Skip to content

Conversation

inelpandzic
Copy link
Contributor

@inelpandzic inelpandzic commented Apr 18, 2024

K8SPSMDB-1056 Powered by Pull Request Badge

CHANGE DESCRIPTION

Problem:
We can create a backup on S3 storage without secrets if we have EKS cluster with iam.attachPolicyARNsconfigured. The problem is we don't support this when deleting backups with delete-backup finalizer.

Cause:
In executing delete-backup finalizer we strictly require that cr.Status.S3.CredentialsSecret is present.

Solution:
Rely on cr.Status.S3.CredentialsSecret only if the user sets it, otherwise proceed and creds will be handled by correct iam.attachPolicyARNs configured.

CHECKLIST

Jira

  • Is the Jira ticket created and referenced properly?
  • Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
  • Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

  • Is an E2E test/test case added for the new feature/change?
  • Are unit tests added where appropriate?
  • Are OpenShift compare files changed for E2E tests (compare/*-oc.yml)?

Config/Logging/Testability

  • Are all needed new/changed options added to default YAML files?
  • Did we add proper logging messages for operator actions?
  • Did we ensure compatibility with the previous version or cluster upgrade process?
  • Does the change support oldest and newest supported MongoDB version?
  • Does the change support oldest and newest supported Kubernetes version?

@pull-request-size pull-request-size bot added the size/S 10-29 lines label Apr 18, 2024
egegunes
egegunes previously approved these changes Apr 18, 2024
@egegunes egegunes added this to the v1.16.0 milestone Apr 18, 2024
@JNKPercona
Copy link
Collaborator

Test name Status
arbiter passed
balancer passed
custom-replset-name passed
cross-site-sharded passed
data-at-rest-encryption passed
data-sharded passed
demand-backup passed
demand-backup-eks-credentials passed
demand-backup-physical passed
demand-backup-physical-sharded failure
demand-backup-sharded passed
expose-sharded passed
ignore-labels-annotations passed
init-deploy passed
finalizer passed
ldap passed
ldap-tls passed
limits passed
liveness passed
mongod-major-upgrade passed
mongod-major-upgrade-sharded passed
monitoring-2-0 passed
multi-cluster-service passed
non-voting passed
one-pod passed
operator-self-healing-chaos passed
pitr passed
pitr-sharded passed
pitr-physical passed
pvc-resize passed
recover-no-primary passed
rs-shard-migration passed
scaling passed
scheduled-backup passed
security-context passed
self-healing-chaos passed
service-per-pod passed
serviceless-external-nodes passed
smart-update passed
split-horizon passed
storage passed
tls-issue-cert-manager passed
upgrade passed
upgrade-consistency passed
upgrade-consistency-sharded-tls passed
upgrade-sharded passed
users passed
version-service passed
We run 48 out of 48

commit: a4dead1
image: perconalab/percona-server-mongodb-operator:PR-1524-a4dead1d

@hors hors merged commit cd0968e into main Apr 19, 2024
@hors hors deleted the K8SPSMDB-1056-s3-delete-backups-without-secrets branch April 19, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/S 10-29 lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants