Skip to content

K8SPSMDB-1084 MongoDB connections leak in backup feature #1542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 7, 2024
Merged

K8SPSMDB-1084 MongoDB connections leak in backup feature #1542

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e268e03
fix: pbm connections leak
steve-nzr May 6, 2024
f93aaaf
Merge branch 'main' into fix/pbm-conn-leak
hors May 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions pkg/psmdb/backup/pbm.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,7 @@ func NewPBM(ctx context.Context, c client.Client, cluster *api.PerconaServerMong

// GetPriorities returns priorities to be used in PBM config.
func GetPriorities(ctx context.Context, k8sclient client.Client, cluster *api.PerconaServerMongoDB) (map[string]float64, error) {
log := logf.FromContext(ctx)
priorities := make(map[string]float64)

usersSecret := corev1.Secret{}
Expand Down Expand Up @@ -218,6 +219,11 @@ func GetPriorities(ctx context.Context, k8sclient client.Client, cluster *api.Pe
// including the primary. That's why, we need to get primary nodes and
// set them in the config.
primary, err := psmdb.GetPrimaryPod(ctx, cli)

if disconnectErr := cli.Disconnect(ctx); disconnectErr != nil {
log.Error(err, "failed to close connection to replicaSet", "rs", rs.Name)
}

if err != nil {
return priorities, errors.Wrap(err, "get primary pod")
}
Expand Down