Skip to content

K8SPSMDB-1057 update finalizer#1590

Merged
nmarukovich merged 18 commits intomainfrom
K8SPSMDB-1057_update_finalizer_names
Jul 30, 2024
Merged

K8SPSMDB-1057 update finalizer#1590
nmarukovich merged 18 commits intomainfrom
K8SPSMDB-1057_update_finalizer_names

Conversation

@nmarukovich
Copy link
Contributor

@nmarukovich nmarukovich commented Jul 12, 2024

K8SPSMDB-1057 Powered by Pull Request Badge

CHANGE DESCRIPTION

Problem:
Fix warning:
Warning: metadata.finalizers: "delete-ssl": prefer a domain-qualified finalizer name to avoid accidental conflicts with other finalizer writers
Cause:
Short explanation of the root cause of the issue if applicable.

Solution:
Short explanation of the solution we are providing with this PR.
Added prefix percona.com in finalizer name.
CHECKLIST

Jira

  • Is the Jira ticket created and referenced properly?
  • Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
  • Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

  • Is an E2E test/test case added for the new feature/change?
  • Are unit tests added where appropriate?
  • Are OpenShift compare files changed for E2E tests (compare/*-oc.yml)?

Config/Logging/Testability

  • Are all needed new/changed options added to default YAML files?
  • Did we add proper logging messages for operator actions?
  • Did we ensure compatibility with the previous version or cluster upgrade process?
  • Does the change support oldest and newest supported MongoDB version?
  • Does the change support oldest and newest supported Kubernetes version?

@nmarukovich nmarukovich requested a review from egegunes July 19, 2024 11:12
hors and others added 2 commits July 19, 2024 14:18
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@nmarukovich nmarukovich requested a review from egegunes July 23, 2024 10:22
hors
hors previously approved these changes Jul 25, 2024
@nmarukovich nmarukovich requested a review from inelpandzic July 26, 2024 11:28
@JNKPercona
Copy link
Collaborator

Test name Status
arbiter passed
balancer passed
custom-replset-name passed
custom-tls passed
cross-site-sharded passed
data-at-rest-encryption passed
data-sharded passed
demand-backup passed
demand-backup-eks-credentials passed
demand-backup-physical passed
demand-backup-physical-sharded passed
demand-backup-sharded passed
expose-sharded passed
ignore-labels-annotations passed
init-deploy passed
finalizer passed
ldap passed
ldap-tls passed
limits passed
liveness passed
mongod-major-upgrade passed
mongod-major-upgrade-sharded passed
monitoring-2-0 passed
multi-cluster-service passed
non-voting passed
one-pod passed
operator-self-healing-chaos passed
pitr passed
pitr-sharded passed
pitr-physical passed
pvc-resize passed
recover-no-primary passed
rs-shard-migration passed
scaling passed
scheduled-backup passed
security-context passed
self-healing-chaos passed
service-per-pod passed
serviceless-external-nodes passed
smart-update passed
split-horizon passed
storage passed
tls-issue-cert-manager passed
upgrade passed
upgrade-consistency passed
upgrade-consistency-sharded-tls passed
upgrade-sharded passed
users passed
version-service passed
We run 49 out of 49

commit: 5ec25a9
image: perconalab/percona-server-mongodb-operator:PR-1590-5ec25a9c

@hors hors self-requested a review July 29, 2024 18:46
@nmarukovich nmarukovich merged commit 334ec86 into main Jul 30, 2024
@nmarukovich nmarukovich deleted the K8SPSMDB-1057_update_finalizer_names branch July 30, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/L 100-499 lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants