-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
K8SPSMDB-1057 update finalizer #1590
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmarukovich
requested review from
tplavcic,
ptankov,
jvpasinatto,
eleo007,
hors,
egegunes,
inelpandzic and
pooknull
as code owners
July 12, 2024 11:05
egegunes
requested changes
Jul 18, 2024
pkg/controller/perconaservermongodbbackup/perconaservermongodbbackup_controller.go
Outdated
Show resolved
Hide resolved
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
egegunes
reviewed
Jul 22, 2024
….com/percona/percona-server-mongodb-operator into K8SPSMDB-1057_update_finalizer_names
hors
previously approved these changes
Jul 25, 2024
pooknull
reviewed
Jul 26, 2024
pkg/controller/perconaservermongodbbackup/perconaservermongodbbackup_controller.go
Show resolved
Hide resolved
inelpandzic
requested changes
Jul 26, 2024
egegunes
approved these changes
Jul 29, 2024
commit: 5ec25a9 |
hors
approved these changes
Jul 29, 2024
inelpandzic
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGE DESCRIPTION
Problem:
Fix warning:
Warning: metadata.finalizers: "delete-ssl": prefer a domain-qualified finalizer name to avoid accidental conflicts with other finalizer writers
Cause:
Short explanation of the root cause of the issue if applicable.
Solution:
Short explanation of the solution we are providing with this PR.
Added prefix percona.com in finalizer name.
CHECKLIST
Jira
Needs Doc
) and QA (Needs QA
)?Tests
compare/*-oc.yml
)?Config/Logging/Testability