Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run go mod vendor #1816

Closed
wants to merge 1 commit into from
Closed

Run go mod vendor #1816

wants to merge 1 commit into from

Conversation

gkech
Copy link
Contributor

@gkech gkech commented Jan 31, 2025

CHANGE DESCRIPTION

Problem:
Seems like the vendor directory is outdated.

go mod vendor ensures all dependencies match the versions in go.mod and go.sum.

Cause:
Short explanation of the root cause of the issue if applicable.

Solution:
Short explanation of the solution we are providing with this PR.

CHECKLIST

Jira

  • Is the Jira ticket created and referenced properly?
  • Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
  • Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

  • Is an E2E test/test case added for the new feature/change?
  • Are unit tests added where appropriate?
  • Are OpenShift compare files changed for E2E tests (compare/*-oc.yml)?

Config/Logging/Testability

  • Are all needed new/changed options added to default YAML files?
  • Are all needed new/changed options added to the Helm Chart?
  • Did we add proper logging messages for operator actions?
  • Did we ensure compatibility with the previous version or cluster upgrade process?
  • Does the change support oldest and newest supported MongoDB version?
  • Does the change support oldest and newest supported Kubernetes version?

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

alex

⚠️ [alex] reported by reviewdog 🐶
Be careful with Angry, it’s profane in some cases angry retext-profanities

6. **Reactions require grace.** Angry responses are valid, but abusive language


⚠️ [alex] reported by reviewdog 🐶
just may be insensitive, try not to use it just retext-equality

7. **Opinions are just that: opinions.** Each and every one of us, due to our


⚠️ [alex] reported by reviewdog 🐶
clearly may be insensitive, try not to use it clearly retext-equality

- Code must be clear and readable, names of variables/constants clearly describes what they are doing


⚠️ [alex] reported by reviewdog 🐶
disabled may be insensitive, use turned off, has a disability, person with a disability, people with disabilities instead invalid retext-equality

`SetNilPtrAllowedByRequired` causes validation to pass when struct fields marked by `required` are set to nil. This is disabled by default for consistency, but some packages that need to be able to determine between `nil` and `zero value` state can use this. If disabled, both `nil` and `zero` values cause validation errors.


⚠️ [alex] reported by reviewdog 🐶
disabled may be insensitive, use turned off, has a disability, person with a disability, people with disabilities instead invalid retext-equality

`SetNilPtrAllowedByRequired` causes validation to pass when struct fields marked by `required` are set to nil. This is disabled by default for consistency, but some packages that need to be able to determine between `nil` and `zero value` state can use this. If disabled, both `nil` and `zero` values cause validation errors.


⚠️ [alex] reported by reviewdog 🐶
WhiteList may be insensitive, use Passlist, Alrightlist, Safelist, Allow list instead whitelist retext-equality


⚠️ [alex] reported by reviewdog 🐶
clearly may be insensitive, try not to use it clearly retext-equality

- Code must be clear and readable, names of variables/constants clearly describes what they are doing


⚠️ [alex] reported by reviewdog 🐶
Special may be insensitive, use Has a disability, Person with a disability, People with disabilities instead special retext-equality

#### Special thanks to [contributors](https://github.com/asaskevich/govalidator/graphs/contributors)


⚠️ [alex] reported by reviewdog 🐶
Be careful with executed, it’s profane in some cases executed retext-profanities

the terms of any separate license agreement you may have executed


⚠️ [alex] reported by reviewdog 🐶
Be careful with failure, it’s profane in some cases failure retext-profanities

Work (including but not limited to damages for loss of goodwill,


⚠️ [alex] reported by reviewdog 🐶
straightforward may be insensitive, try not to use it straightforward retext-equality

This package provides a straightforward API:


⚠️ [alex] reported by reviewdog 🐶
simple may be insensitive, try not to use it simple retext-equality

callback mechanism which is called when a simple domain match fails.


⚠️ [alex] reported by reviewdog 🐶
Be careful with Christian, it’s profane in some cases christian retext-profanities


⚠️ [alex] reported by reviewdog 🐶
invalid may be insensitive, use turned off, has a disability, person with a disability, people with disabilities instead invalid retext-equality

- Fix issue with default responses and invalid status code 0. (#393)


⚠️ [alex] reported by reviewdog 🐶
disabled may be insensitive, use turned off, has a disability, person with a disability, people with disabilities instead invalid retext-equality

- (api add) Added support for response encoding (gzip and deflate(zlib)). This feature is disabled on default (for backwards compatibility). Use restful.EnableContentEncoding = true in your initialization to enable this feature.


⚠️ [alex] reported by reviewdog 🐶
master may be insensitive, use primary, lead, hub, reference instead master retext-equality

All versions up to `v2.*.*` (on the master) are not supporting Go modules.


⚠️ [alex] reported by reviewdog 🐶
Be careful with hooks, it’s profane in some cases hooks retext-profanities

There are several hooks to customize the behavior of the go-restful package.


⚠️ [alex] reported by reviewdog 🐶
just may be insensitive, try not to use it just retext-equality

Inotify doesn't provide any good facilities to update it, so just remove the


⚠️ [alex] reported by reviewdog 🐶
Be careful with remains, it’s profane in some cases remains retext-profanities

On Windows this does work, and remains working.


⚠️ [alex] reported by reviewdog 🐶
simply may be insensitive, try not to use it simple retext-equality

fail if a file was unreadable by the current user. Now these files are simply


⚠️ [alex] reported by reviewdog 🐶
Be careful with crash, it’s profane in some cases crash retext-profanities

* Fix potential crash on windows if `raw.FileNameLength` exceeds `syscall.MAX_PATH` [#361](https://github.com/fsnotify/fsnotify/pull/361)


⚠️ [alex] reported by reviewdog 🐶
just may be insensitive, try not to use it just retext-equality

can just send PRs, but they may end up being rejected for one reason or the


⚠️ [alex] reported by reviewdog 🐶
Just may be insensitive, try not to use it just retext-equality

Just `go test ./...` runs all the tests; the CI runs this on all supported


⚠️ [alex] reported by reviewdog 🐶
Be careful with failure, it’s profane in some cases failure retext-profanities

The upshot of this is that a power failure or crash won't leave a half-written


⚠️ [alex] reported by reviewdog 🐶
Be careful with crash, it’s profane in some cases crash retext-profanities

The upshot of this is that a power failure or crash won't leave a half-written


⚠️ [alex] reported by reviewdog 🐶
Reconsider using sex, it may be profane sex retext-profanities

size, visible or invisible disability, ethnicity, sex characteristics, gender


⚠️ [alex] reported by reviewdog 🐶
Reconsider using sexual, it may be profane sexual retext-profanities

nationality, personal appearance, race, caste, color, religion, or sexual


⚠️ [alex] reported by reviewdog 🐶
just may be insensitive, try not to use it just retext-equality

* Focusing on what is best not just for us as individuals, but for the overall


⚠️ [alex] reported by reviewdog 🐶
Reconsider using sexual, it may be profane sexual retext-profanities

* The use of sexualized language or imagery, and sexual attention or advances of


⚠️ [alex] reported by reviewdog 🐶
Be careful with attacks, it’s profane in some cases attacks retext-profanities

* Trolling, insulting or derogatory comments, and personal or political attacks


⚠️ [alex] reported by reviewdog 🐶
Be careful with reject, it’s profane in some cases reject retext-profanities

Community leaders have the right and responsibility to remove, edit, or reject


⚠️ [alex] reported by reviewdog 🐶
Be careful with period, it’s profane in some cases period retext-profanities

those enforcing the Code of Conduct, for a specified period of time. This


⚠️ [alex] reported by reviewdog 🐶
Be careful with period, it’s profane in some cases period retext-profanities

communication with the community for a specified period of time. No public or


⚠️ [alex] reported by reviewdog 🐶
Be careful with period, it’s profane in some cases period retext-profanities

with those enforcing the Code of Conduct, is allowed during this period.


⚠️ [alex] reported by reviewdog 🐶
Clearly may be insensitive, try not to use it clearly retext-equality


⚠️ [alex] reported by reviewdog 🐶
Special may be insensitive, use Has a disability, Person with a disability, People with disabilities instead special retext-equality

- Special thanks to @lukseven for pointing out the contribution guidelines didn't mention signing requirements.


⚠️ [alex] reported by reviewdog 🐶
disabled may be insensitive, use turned off, has a disability, person with a disability, people with disabilities instead invalid retext-equality

- go1.19.10, linux/amd64, i5-13600K (disabled all e-cores, DDR4 @2933)


⚠️ [alex] reported by reviewdog 🐶
Be careful with executions, it’s profane in some cases executions retext-profanities

v2.7.0 (June 23, 2024) adds features and improvements that help large projects (e.g. Kubernetes) use CBOR as an alternative to JSON and Protocol Buffers. Other improvements include speedups, improved memory use, bug fixes, new serialization options, etc. It passed fuzz tests (5+ billion executions) and is production quality.


⚠️ [alex] reported by reviewdog 🐶
Invalid may be insensitive, use Turned off, Has a disability, Person with a disability, People with disabilities instead invalid retext-equality

* Invalid UTF-8 string: Decoder has option to check and return invalid UTF-8 string error. This check is enabled by default.


⚠️ [alex] reported by reviewdog 🐶
invalid may be insensitive, use turned off, has a disability, person with a disability, people with disabilities instead invalid retext-equality

* Invalid UTF-8 string: Decoder has option to check and return invalid UTF-8 string error. This check is enabled by default.


⚠️ [alex] reported by reviewdog 🐶
master may be insensitive, use primary, lead, hub, reference instead master retext-equality

- Newly added API in the master branch that has never been tagged in non-beta release.


⚠️ [alex] reported by reviewdog 🐶
Be careful with period, it’s profane in some cases period retext-profanities

- If function parameters are unchanged, bug fixes that change behavior (e.g. return error for edge case was missed in prior version). We try to highlight these in the release notes and add extended beta period. E.g. [v2.5.0-beta](https://github.com/fxamacker/cbor/releases/tag/v2.5.0-beta) (Dec 2022) -> [v2.5.0](https://github.com/fxamacker/cbor/releases/tag/v2.5.0) (Aug 2023).


⚠️ [alex] reported by reviewdog 🐶
his may be insensitive, when referring to a person, use their, theirs, them instead her-him retext-equality

Big thanks to Ben Luddy for his contributions in v2.6.0 and v2.7.0.


⚠️ [alex] reported by reviewdog 🐶
clearly may be insensitive, try not to use it clearly retext-equality

This library clearly wouldn't be possible without Carsten Bormann authoring CBOR RFCs.


⚠️ [alex] reported by reviewdog 🐶
Special may be insensitive, use Has a disability, Person with a disability, People with disabilities instead special retext-equality

Special thanks to Laurence Lundblade and Jeffrey Yasskin for their help on IETF mailing list or at [7049bis](https://github.com/cbor-wg/CBORbis).


⚠️ [alex] reported by reviewdog 🐶
he may be insensitive, use they, it instead he-she retext-equality

he has to say, and it largely aligns with our own experiences.


⚠️ [alex] reported by reviewdog 🐶
basically may be insensitive, try not to use it basically retext-equality

1. Dave basically proposes doing away with the notion of a logging API in favor


⚠️ [alex] reported by reviewdog 🐶
just may be insensitive, try not to use it just retext-equality

package restricts the logging API to just 2 types of logs: info and error.


⚠️ [alex] reported by reviewdog 🐶
easy may be insensitive, try not to use it easy retext-equality

- **github.com/wojas/genericr**: [genericr](https://github.com/wojas/genericr) (makes it easy to implement your own backend)


⚠️ [alex] reported by reviewdog 🐶
Special may be insensitive, use Has a disability, Person with a disability, People with disabilities instead special retext-equality

- Special slog values and interfaces don't work as expected.


⚠️ [alex] reported by reviewdog 🐶
easily may be insensitive, try not to use it easy retext-equality

- **Structured logs are more easily queryable**: Since you've got


⚠️ [alex] reported by reviewdog 🐶
easy may be insensitive, try not to use it easy retext-equality

keys, it becomes easy to gather all log lines related to a particular


⚠️ [alex] reported by reviewdog 🐶
just may be insensitive, try not to use it just retext-equality

matches a certain value, etc., instead of just having v-levels and names


⚠️ [alex] reported by reviewdog 🐶
easy may be insensitive, try not to use it easy retext-equality

**V-levels give operators an easy way to control the chattiness of log


⚠️ [alex] reported by reviewdog 🐶
simply may be insensitive, try not to use it simple retext-equality

of the package can simply change the v-levels for that library.


⚠️ [alex] reported by reviewdog 🐶
easily may be insensitive, try not to use it easy retext-equality

- They're not easily searchable without resorting to fuzzy searching,


⚠️ [alex] reported by reviewdog 🐶
easily may be insensitive, try not to use it easy retext-equality

- They don't compress easily, since the message is not constant.


⚠️ [alex] reported by reviewdog 🐶
obvious may be insensitive, try not to use it obvious retext-equality

While the interface ends up being a little less obvious, you get


⚠️ [alex] reported by reviewdog 🐶
mental may be insensitive, use rude, malicious, mean, disgusting, incredible, vile, person with symptoms of mental illness, person with mental illness, person with symptoms of a mental disorder, person with a mental disorder instead nuts retext-equality

I convert my mental model of logging with format strings to logging with


⚠️ [alex] reported by reviewdog 🐶
basically may be insensitive, try not to use it basically retext-equality

This is basically the only hard constraint: increase V-levels to denote


⚠️ [alex] reported by reviewdog 🐶
simple may be insensitive, try not to use it simple retext-equality


⚠️ [alex] reported by reviewdog 🐶
Be careful with harder, it’s profane in some cases harder retext-profanities

much harder to use. `Sprintf()` is for values, not for keys!


⚠️ [alex] reported by reviewdog 🐶
Reconsider using illegal, it may be profane illegal retext-profanities

it's illegal to pass a strongly-typed Zap field in a key position to any


⚠️ [alex] reported by reviewdog 🐶
just may be insensitive, try not to use it just retext-equality

enables `slogr.NewSlogHandler` to provide a `slog.Handler` which just passes


⚠️ [alex] reported by reviewdog 🐶
special may be insensitive, use has a disability, person with a disability, people with disabilities instead special retext-equality

parameters through to zapr. zapr handles special slog values (Group,


⚠️ [alex] reported by reviewdog 🐶
Reconsider using sexual, it may be profane sexual retext-profanities

nationality, personal appearance, race, religion, or sexual identity and


⚠️ [alex] reported by reviewdog 🐶
Reconsider using sexual, it may be profane sexual retext-profanities

* The use of sexualized language or imagery and unwelcome sexual attention or


⚠️ [alex] reported by reviewdog 🐶
Be careful with attacks, it’s profane in some cases attacks retext-profanities

* Trolling, insulting/derogatory comments, and personal or political attacks


⚠️ [alex] reported by reviewdog 🐶
Be careful with reject, it’s profane in some cases reject retext-profanities

reject comments, commits, code, wiki edits, issues, and other contributions


⚠️ [alex] reported by reviewdog 🐶
Be careful with faith, it’s profane in some cases faith retext-profanities

faith may face temporary or permanent repercussions as determined by other


⚠️ [alex] reported by reviewdog 🐶
Reconsider using sexual, it may be profane sexual retext-profanities

nationality, personal appearance, race, religion, or sexual identity and


⚠️ [alex] reported by reviewdog 🐶
Reconsider using sexual, it may be profane sexual retext-profanities

* The use of sexualized language or imagery and unwelcome sexual attention or


⚠️ [alex] reported by reviewdog 🐶
Be careful with attacks, it’s profane in some cases attacks retext-profanities

* Trolling, insulting/derogatory comments, and personal or political attacks


⚠️ [alex] reported by reviewdog 🐶
Be careful with reject, it’s profane in some cases reject retext-profanities

reject comments, commits, code, wiki edits, issues, and other contributions


⚠️ [alex] reported by reviewdog 🐶
Be careful with faith, it’s profane in some cases faith retext-profanities

faith may face temporary or permanent repercussions as determined by other


⚠️ [alex] reported by reviewdog 🐶
Reconsider using sexual, it may be profane sexual retext-profanities

nationality, personal appearance, race, religion, or sexual identity and


⚠️ [alex] reported by reviewdog 🐶
Reconsider using sexual, it may be profane sexual retext-profanities

* The use of sexualized language or imagery and unwelcome sexual attention or


⚠️ [alex] reported by reviewdog 🐶
Be careful with attacks, it’s profane in some cases attacks retext-profanities

* Trolling, insulting/derogatory comments, and personal or political attacks


⚠️ [alex] reported by reviewdog 🐶
Be careful with reject, it’s profane in some cases reject retext-profanities

reject comments, commits, code, wiki edits, issues, and other contributions


⚠️ [alex] reported by reviewdog 🐶
Be careful with faith, it’s profane in some cases faith retext-profanities

faith may face temporary or permanent repercussions as determined by other


⚠️ [alex] reported by reviewdog 🐶
Reconsider using sexual, it may be profane sexual retext-profanities

nationality, personal appearance, race, religion, or sexual identity and


⚠️ [alex] reported by reviewdog 🐶
Reconsider using sexual, it may be profane sexual retext-profanities

* The use of sexualized language or imagery and unwelcome sexual attention or


⚠️ [alex] reported by reviewdog 🐶
Be careful with attacks, it’s profane in some cases attacks retext-profanities

* Trolling, insulting/derogatory comments, and personal or political attacks


⚠️ [alex] reported by reviewdog 🐶
Be careful with reject, it’s profane in some cases reject retext-profanities

reject comments, commits, code, wiki edits, issues, and other contributions


⚠️ [alex] reported by reviewdog 🐶
Be careful with faith, it’s profane in some cases faith retext-profanities

faith may face temporary or permanent repercussions as determined by other


⚠️ [alex] reported by reviewdog 🐶
Reconsider using sexual, it may be profane sexual retext-profanities

nationality, personal appearance, race, religion, or sexual identity and


⚠️ [alex] reported by reviewdog 🐶
Reconsider using sexual, it may be profane sexual retext-profanities

* The use of sexualized language or imagery and unwelcome sexual attention or


⚠️ [alex] reported by reviewdog 🐶
Be careful with attacks, it’s profane in some cases attacks retext-profanities

* Trolling, insulting/derogatory comments, and personal or political attacks


⚠️ [alex] reported by reviewdog 🐶
Be careful with reject, it’s profane in some cases reject retext-profanities

reject comments, commits, code, wiki edits, issues, and other contributions


⚠️ [alex] reported by reviewdog 🐶
Be careful with faith, it’s profane in some cases faith retext-profanities

faith may face temporary or permanent repercussions as determined by other


⚠️ [alex] reported by reviewdog 🐶
Reconsider using sexual, it may be profane sexual retext-profanities

nationality, personal appearance, race, religion, or sexual identity and


⚠️ [alex] reported by reviewdog 🐶
Reconsider using sexual, it may be profane sexual retext-profanities

* The use of sexualized language or imagery and unwelcome sexual attention or


⚠️ [alex] reported by reviewdog 🐶
Be careful with attacks, it’s profane in some cases attacks retext-profanities

* Trolling, insulting/derogatory comments, and personal or political attacks


⚠️ [alex] reported by reviewdog 🐶
Be careful with reject, it’s profane in some cases reject retext-profanities

reject comments, commits, code, wiki edits, issues, and other contributions


⚠️ [alex] reported by reviewdog 🐶
Be careful with faith, it’s profane in some cases faith retext-profanities

faith may face temporary or permanent repercussions as determined by other


⚠️ [alex] reported by reviewdog 🐶
Reconsider using sexual, it may be profane sexual retext-profanities

nationality, personal appearance, race, religion, or sexual identity and


⚠️ [alex] reported by reviewdog 🐶
Reconsider using sexual, it may be profane sexual retext-profanities

* The use of sexualized language or imagery and unwelcome sexual attention or


⚠️ [alex] reported by reviewdog 🐶
Be careful with attacks, it’s profane in some cases attacks retext-profanities

* Trolling, insulting/derogatory comments, and personal or political attacks


⚠️ [alex] reported by reviewdog 🐶
Be careful with reject, it’s profane in some cases reject retext-profanities

reject comments, commits, code, wiki edits, issues, and other contributions


⚠️ [alex] reported by reviewdog 🐶
Be careful with faith, it’s profane in some cases faith retext-profanities

faith may face temporary or permanent repercussions as determined by other


⚠️ [alex] reported by reviewdog 🐶
Reconsider using sexual, it may be profane sexual retext-profanities

nationality, personal appearance, race, religion, or sexual identity and


⚠️ [alex] reported by reviewdog 🐶
Reconsider using sexual, it may be profane sexual retext-profanities

* The use of sexualized language or imagery and unwelcome sexual attention or


⚠️ [alex] reported by reviewdog 🐶
Be careful with attacks, it’s profane in some cases attacks retext-profanities

* Trolling, insulting/derogatory comments, and personal or political attacks


⚠️ [alex] reported by reviewdog 🐶
Be careful with reject, it’s profane in some cases reject retext-profanities

reject comments, commits, code, wiki edits, issues, and other contributions


⚠️ [alex] reported by reviewdog 🐶
Be careful with faith, it’s profane in some cases faith retext-profanities

faith may face temporary or permanent repercussions as determined by other


⚠️ [alex] reported by reviewdog 🐶
Don’t use stringers, it’s profane stringers retext-profanities

All types defined here are stringers and may be converted to strings with `.String()`.


⚠️ [alex] reported by reviewdog 🐶
just may be insensitive, try not to use it just retext-equality

The `conv` subpackage provides helpers to convert the types to and from pointers, just like `go-openapi/swag` does


⚠️ [alex] reported by reviewdog 🐶
primitive may be insensitive, use simple, indigenous, hunter-gatherer instead savage retext-equality


⚠️ [alex] reported by reviewdog 🐶
Reconsider using sexual, it may be profane sexual retext-profanities

nationality, personal appearance, race, religion, or sexual identity and


⚠️ [alex] reported by reviewdog 🐶
Reconsider using sexual, it may be profane sexual retext-profanities

* The use of sexualized language or imagery and unwelcome sexual attention or


⚠️ [alex] reported by reviewdog 🐶
Be careful with attacks, it’s profane in some cases attacks retext-profanities

* Trolling, insulting/derogatory comments, and personal or political attacks


⚠️ [alex] reported by reviewdog 🐶
Be careful with reject, it’s profane in some cases reject retext-profanities

reject comments, commits, code, wiki edits, issues, and other contributions


⚠️ [alex] reported by reviewdog 🐶
Be careful with faith, it’s profane in some cases faith retext-profanities

faith may face temporary or permanent repercussions as determined by other


⚠️ [alex] reported by reviewdog 🐶
Reconsider using sexual, it may be profane sexual retext-profanities

nationality, personal appearance, race, religion, or sexual identity and


⚠️ [alex] reported by reviewdog 🐶
Reconsider using sexual, it may be profane sexual retext-profanities

* The use of sexualized language or imagery and unwelcome sexual attention or


⚠️ [alex] reported by reviewdog 🐶
Be careful with attacks, it’s profane in some cases attacks retext-profanities

* Trolling, insulting/derogatory comments, and personal or political attacks


⚠️ [alex] reported by reviewdog 🐶
Be careful with reject, it’s profane in some cases reject retext-profanities

reject comments, commits, code, wiki edits, issues, and other contributions


⚠️ [alex] reported by reviewdog 🐶
Be careful with faith, it’s profane in some cases faith retext-profanities

faith may face temporary or permanent repercussions as determined by other


⚠️ [alex] reported by reviewdog 🐶
master may be insensitive, use primary, lead, hub, reference instead master retext-equality

Reference can be found here: https://github.com/OAI/OpenAPI-Specification/blob/master/versions/2.0.md.


⚠️ [alex] reported by reviewdog 🐶
Be careful with period, it’s profane in some cases period retext-profanities

- Remove extra period 1eb7729 (Matthew Lorimor)


⚠️ [alex] reported by reviewdog 🐶
Be careful with failures, it’s profane in some cases failures retext-profanities

The 2.17.0 release did not have a version pinned for xstrings, which caused compilation failures when xstrings < 1.2 was used. This adds the correct version string to glide.yaml.


⚠️ [alex] reported by reviewdog 🐶
Don’t use Coons, it’s profane coons retext-profanities

- Generate serial number a3bdffd (Cody Coons)


⚠️ [alex] reported by reviewdog 🐶
just may be insensitive, try not to use it just retext-equality

- `nindent` is just like `indent` but also prepends a new line


⚠️ [alex] reported by reviewdog 🐶
whitespace may be insensitive, use space, blank instead whitespace retext-equality

- cat: Concatenate strings with whitespace separators.


⚠️ [alex] reported by reviewdog 🐶
Simple may be insensitive, try not to use it simple retext-equality


⚠️ [alex] reported by reviewdog 🐶
Simple may be insensitive, try not to use it simple retext-equality

- Simple math is necessary for grid layouts, pagers, and so on. Complex math


⚠️ [alex] reported by reviewdog 🐶
just may be insensitive, try not to use it just retext-equality

just a few small guidelines you need to follow.


⚠️ [alex] reported by reviewdog 🐶
simply may be insensitive, try not to use it simple retext-equality

License Agreement. This is not a copyright **assignment**, it simply gives


⚠️ [alex] reported by reviewdog 🐶
simple may be insensitive, try not to use it simple retext-equality

1. Go makes it very simple to ensure properly formatted code, so always run


⚠️ [alex] reported by reviewdog 🐶
invalid may be insensitive, use turned off, has a disability, person with a disability, people with disabilities instead invalid retext-equality

change is the ability to represent an invalid UUID (vs a NIL UUID).


⚠️ [alex] reported by reviewdog 🐶
primitive may be insensitive, use simple, indigenous, hunter-gatherer instead savage retext-equality

* Supports all primitive go types (string, int{8..64}, uint{8..64}, float)


⚠️ [alex] reported by reviewdog 🐶
simple may be insensitive, try not to use it simple retext-equality

to allow users to specify command line options. This results in very simple


⚠️ [alex] reported by reviewdog 🐶
easy may be insensitive, try not to use it easy retext-equality

Using go-jmespath is really easy. There's a single function


⚠️ [alex] reported by reviewdog 🐶
master may be insensitive, use primary, lead, hub, reference instead master retext-equality

Source code: https://github.com/json-iterator/go-benchmark/blob/master/src/github.com/json-iterator/go-benchmark/benchmark_medium_payload_test.go


⚠️ [alex] reported by reviewdog 🐶
Be careful with CORRUPTION, it’s profane in some cases corruption retext-profanities

* zstd: Fix rare *CORRUPTION* output in "best" mode. See https://github.com/klauspost/compress/pull/876


⚠️ [alex] reported by reviewdog 🐶
Be careful with crash, it’s profane in some cases crash retext-profanities

* zstd: Fix decoder crash on amd64 (no BMI) on invalid input https://github.com/klauspost/compress/pull/645


⚠️ [alex] reported by reviewdog 🐶
invalid may be insensitive, use turned off, has a disability, person with a disability, people with disabilities instead invalid retext-equality

* zstd: Fix decoder crash on amd64 (no BMI) on invalid input https://github.com/klauspost/compress/pull/645


⚠️ [alex] reported by reviewdog 🐶
Be careful with crashes, it’s profane in some cases crashes retext-profanities

* zstd: Disable decoder extended memory copies (amd64) due to possible crashes https://github.com/klauspost/compress/pull/644


⚠️ [alex] reported by reviewdog 🐶
Be careful with crash, it’s profane in some cases crash retext-profanities

* s2: Fix final emit oob read crash on amd64 https://github.com/klauspost/compress/pull/601


⚠️ [alex] reported by reviewdog 🐶
Be careful with corruption, it’s profane in some cases corruption retext-profanities

* flate: Fix rare huffman only (-2) corruption. [#503](https://github.com/klauspost/compress/pull/503)


⚠️ [alex] reported by reviewdog 🐶
Be careful with bigger, it’s profane in some cases bigger retext-profanities

* zstd: Add bigger default blocks [#469](https://github.com/klauspost/compress/pull/469)


⚠️ [alex] reported by reviewdog 🐶
Be careful with dead, it’s profane in some cases dead retext-profanities

* zstd: Fix logically dead code by @ningmingxiao [#472](https://github.com/klauspost/compress/pull/472)


⚠️ [alex] reported by reviewdog 🐶
Be careful with bigger, it’s profane in some cases bigger retext-profanities

* s2: Improve speed with bigger output margin [#395](https://github.com/klauspost/compress/pull/395)


⚠️ [alex] reported by reviewdog 🐶
invalid may be insensitive, use turned off, has a disability, person with a disability, people with disabilities instead invalid retext-equality

* zstd: Detect short invalid signatures [#382](https://github.com/klauspost/compress/pull/382)


⚠️ [alex] reported by reviewdog 🐶
Be careful with crash, it’s profane in some cases crash retext-profanities

* s2: Fix crash on small better buffers. [#308](https://github.com/klauspost/compress/pull/308)


⚠️ [alex] reported by reviewdog 🐶
special may be insensitive, use has a disability, person with a disability, people with disabilities instead special retext-equality

* zstd: Minor/special case optimizations. [#251](https://github.com/klauspost/compress/pull/251), [#250](https://github.com/klauspost/compress/pull/250), [#249](https://github.com/klauspost/compress/pull/249), [#247](https://github.com/klauspost/compress/pull/247)


⚠️ [alex] reported by reviewdog 🐶
Be careful with crash, it’s profane in some cases crash retext-profanities

* Fix zstd crash when resetting multiple times without sending data. [#226](https://github.com/klauspost/compress/pull/226)


⚠️ [alex] reported by reviewdog 🐶
just may be insensitive, try not to use it just retext-equality

* Dec 10, 2019: s2: Fix repeat length output when just above at 16MB limit.


⚠️ [alex] reported by reviewdog 🐶
Be careful with crash, it’s profane in some cases crash retext-profanities

* Oct 28, 2019 (v1.9.1) ztsd: Fix crash when compressing blocks. [#174](https://github.com/klauspost/compress/pull/174)


⚠️ [alex] reported by reviewdog 🐶
Be careful with corruption, it’s profane in some cases corruption retext-profanities

* Oct 24, 2019 (v1.9.0) zstd: Fix rare data corruption [#173](https://github.com/klauspost/compress/pull/173)


⚠️ [alex] reported by reviewdog 🐶
easy may be insensitive, try not to use it easy retext-equality

* Feb 12, 2016: Snappy: Added AMD64 SSE 4.2 optimizations to matching, which makes easy to compress material run faster. Typical speedup is around 25%.


⚠️ [alex] reported by reviewdog 🐶
Simply may be insensitive, try not to use it simple retext-equality

The packages are drop-in replacements for standard libraries. Simply replace the import path to use them:


⚠️ [alex] reported by reviewdog 🐶
special may be insensitive, use has a disability, person with a disability, people with disabilities instead special retext-equality

This package offers stateless compression as a special option for gzip/deflate.


⚠️ [alex] reported by reviewdog 🐶
of course may be insensitive, try not to use it of-course retext-equality

A `bufio.Writer` can of course be used to control write sizes. For example, to use a 4KB buffer:


⚠️ [alex] reported by reviewdog 🐶
Be careful with bigger, it’s profane in some cases bigger retext-profanities

The columns to take note of are: *MB/s* - the throughput. *Reduction* - the data size reduction in percent of the original. *Rel Speed* relative speed compared to the standard library at the same level. *Smaller* - how many percent smaller is the compressed output compared to stdlib. Negative means the output was bigger. *Loss* means the loss (or gain) in compression as a percentage difference of the input.


⚠️ [alex] reported by reviewdog 🐶
Be careful with beast, it’s profane in some cases beast retext-profanities

The `gzstd` (standard library gzip) and `gzkp` (this package gzip) only uses one CPU core. [`pgzip`](https://github.com/klauspost/pgzip), [`bgzf`](https://github.com/biogo/hts/tree/master/bgzf) uses all 4 cores. [`zstd`](https://github.com/DataDog/zstd) uses one core, and is a beast (but not Go, yet).


⚠️ [alex] reported by reviewdog 🐶
Be careful with conservative, it’s profane in some cases conservative retext-profanities

This is mainly a test of how good the algorithms are at detecting un-compressible input. The standard library only offers this feature with very conservative settings at level 1. Obviously there is no reason for the algorithms to try to compress input that cannot be compressed. The only downside is that it might skip some compressible data on false detections.


⚠️ [alex] reported by reviewdog 🐶
Obviously may be insensitive, try not to use it obvious retext-equality

This is mainly a test of how good the algorithms are at detecting un-compressible input. The standard library only offers this feature with very conservative settings at level 1. Obviously there is no reason for the algorithms to try to compress input that cannot be compressed. The only downside is that it might skip some compressible data on false detections.


⚠️ [alex] reported by reviewdog 🐶
special may be insensitive, use has a disability, person with a disability, people with disabilities instead special retext-equality

This compression library adds a special compression level, named `HuffmanOnly`, which allows near linear time compression. This is done by completely disabling matching of previous data, and only reduce the number of bits to represent each character.


⚠️ [alex] reported by reviewdog 🐶
Be careful with crash, it’s profane in some cases crash retext-profanities

A security vulnerability is a bug that with certain input triggers a crash or an infinite loop. Most calls will have varying execution time and only in rare cases will slow operation be considered a security vulnerability.


⚠️ [alex] reported by reviewdog 🐶
Be careful with execution, it’s profane in some cases execution retext-profanities

A security vulnerability is a bug that with certain input triggers a crash or an infinite loop. Most calls will have varying execution time and only in rare cases will slow operation be considered a security vulnerability.


⚠️ [alex] reported by reviewdog 🐶
Be careful with crashes, it’s profane in some cases crashes retext-profanities

Out-of-memory crashes only applies if the en/decoder uses an abnormal amount of memory, with appropriate options applied, to limit maximum window size, concurrency, etc. However, if you are in doubt you are welcome to file a security issue.


⚠️ [alex] reported by reviewdog 🐶
Be careful with bigger, it’s profane in some cases bigger retext-profanities

S2 is aimed for high throughput, which is why it features concurrent compression for bigger payloads.


⚠️ [alex] reported by reviewdog 🐶
Be careful with corruption, it’s profane in some cases corruption retext-profanities

so data corruption may be undetected. Stream encoding provides CRC checks of data.


⚠️ [alex] reported by reviewdog 🐶
simple may be insensitive, try not to use it simple retext-equality

Using a simple `dst := s2.Encode(nil, src)` will compress `src` and return the compressed result.


⚠️ [alex] reported by reviewdog 🐶
simply may be insensitive, try not to use it simple retext-equality

Some very simply commandline tools are provided; `s2c` for compression and `s2d` for decompression.


⚠️ [alex] reported by reviewdog 🐶
host may be insensitive, use presenter, entertainer, emcee instead host-hostess retext-equality

By default, executables are created for the same platforms as the host os,


⚠️ [alex] reported by reviewdog 🐶
disabled may be insensitive, use turned off, has a disability, person with a disability, people with disabilities instead invalid retext-equality

This functionality is disabled with stdin/stdout.


⚠️ [alex] reported by reviewdog 🐶
host may be insensitive, use presenter, entertainer, emcee instead host-hostess retext-equality

If you wrap a TAR file you can specify `-untar` to make it untar on the destination host.


⚠️ [alex] reported by reviewdog 🐶
just may be insensitive, try not to use it just retext-equality

When compressing blocks no concurrent compression is performed just as Snappy.


⚠️ [alex] reported by reviewdog 🐶
Be careful with bigger, it’s profane in some cases bigger retext-profanities

An important change is that incompressible blocks will not be more than at most 10 bytes bigger than the input.


⚠️ [alex] reported by reviewdog 🐶
Be careful with bigger, it’s profane in some cases bigger retext-profanities

In rare, worst case scenario Snappy blocks could be significantly bigger than the input.


⚠️ [alex] reported by reviewdog 🐶
Be careful with harder, it’s profane in some cases harder retext-profanities

The PDF sample shows a significant slowdown compared to Snappy, as this mode tries harder


⚠️ [alex] reported by reviewdog 🐶
Be careful with bigger, it’s profane in some cases bigger retext-profanities

This will remove any negative (speed) impacts of the dictionaries on bigger blocks.


⚠️ [alex] reported by reviewdog 🐶
just may be insensitive, try not to use it just retext-equality

If your input is very uniform, you can just use a sample file as the dictionary.


⚠️ [alex] reported by reviewdog 🐶
easily may be insensitive, try not to use it easy retext-equality

Zstandard dictionaries can easily be converted to S2 dictionaries.


⚠️ [alex] reported by reviewdog 🐶
simply may be insensitive, try not to use it simple retext-equality

simply changing imports from `github.com/golang/snappy` to `github.com/klauspost/compress/snappy`.


⚠️ [alex] reported by reviewdog 🐶
Be careful with remains, it’s profane in some cases remains retext-profanities

so the output remains compatible with other decoders.


⚠️ [alex] reported by reviewdog 🐶
invalid may be insensitive, use turned off, has a disability, person with a disability, people with disabilities instead invalid retext-equality

Also note, that the cgo decompressor currently does not [report all errors on invalid input](https://github.com/DataDog/zstd/issues/59),


⚠️ [alex] reported by reviewdog 🐶
special may be insensitive, use has a disability, person with a disability, people with disabilities instead special retext-equality

Especially when encoding blocks you should take special care to reuse the encoder.


⚠️ [alex] reported by reviewdog 🐶
Be careful with period, it’s profane in some cases period retext-profanities

This will effectively make it run without allocations after a warmup period.


⚠️ [alex] reported by reviewdog 🐶
Be careful with crash, it’s profane in some cases crash retext-profanities

The main purpose of the fuzz testing is to ensure that it is not possible to crash the decoder,


⚠️ [alex] reported by reviewdog 🐶
simple may be insensitive, try not to use it simple retext-equality

For streaming use a simple setup could look like this:


⚠️ [alex] reported by reviewdog 🐶
Just may be insensitive, try not to use it just retext-equality

This will likely be improved over time. Just be aware to test performance when implementing.


⚠️ [alex] reported by reviewdog 🐶
Be careful with failed, it’s profane in some cases failed retext-profanities

A decoder can safely be re-used even if the previous stream failed.


⚠️ [alex] reported by reviewdog 🐶
straightforward may be insensitive, try not to use it straightforward retext-equality


⚠️ [alex] reported by reviewdog 🐶
Be careful with bigger, it’s profane in some cases bigger retext-profanities

The only drawback is a slightly bigger overhead compared to this and pure gzip.


⚠️ [alex] reported by reviewdog 🐶
simply may be insensitive, try not to use it simple retext-equality

The simplest way to use this is to simply do the same as you would when using [compress/gzip](http://golang.org/pkg/compress/gzip).


⚠️ [alex] reported by reviewdog 🐶
simply may be insensitive, try not to use it simple retext-equality

Decompression works similar to compression. That means that you simply call pgzip the same way as you would call [compress/gzip](http://golang.org/pkg/compress/gzip).


⚠️ [alex] reported by reviewdog 🐶
Be careful with hooks, it’s profane in some cases hooks retext-profanities

* New function `OrComposeDecodeHookFunc` to help compose decode hooks. [GH-240]


⚠️ [alex] reported by reviewdog 🐶
Be careful with crashes, it’s profane in some cases crashes retext-profanities

* Decoding to slice from array no longer crashes [GH-265]


⚠️ [alex] reported by reviewdog 🐶
Be careful with hooks, it’s profane in some cases hooks retext-profanities


⚠️ [alex] reported by reviewdog 🐶
Be careful with hook, it’s profane in some cases hook retext-profanities

* A new decode hook type `DecodeHookFuncValue` has been added that has


⚠️ [alex] reported by reviewdog 🐶
Be careful with hooks, it’s profane in some cases hooks retext-profanities

* Decoding maps from maps creates a settable value for decode hooks [GH-203]


⚠️ [alex] reported by reviewdog 🐶
Be careful with hook, it’s profane in some cases hook retext-profanities

* Fix error when decode hook decodes interface implementation into interface


⚠️ [alex] reported by reviewdog 🐶
just may be insensitive, try not to use it just retext-equality

However, it is much simpler to just decode this into a `map[string]interface{}`


⚠️ [alex] reported by reviewdog 🐶
Be careful with crash, it’s profane in some cases crash retext-profanities

* handle panic by callback: the default behavior will no longer crash your application


⚠️ [alex] reported by reviewdog 🐶
just may be insensitive, try not to use it just retext-equality

As it is just a thin wrapper to make go runtime public.


⚠️ [alex] reported by reviewdog 🐶
master may be insensitive, use primary, lead, hub, reference instead master retext-equality


⚠️ [alex] reported by reviewdog 🐶
master may be insensitive, use primary, lead, hub, reference instead master retext-equality


⚠️ [alex] reported by reviewdog 🐶
obvious may be insensitive, try not to use it obvious retext-equality

- Realized the obvious efficiency gains of ignoring the unique numbers at the beginning of the slice. Benchmark joy ensued.


⚠️ [alex] reported by reviewdog 🐶
master may be insensitive, use primary, lead, hub, reference instead master retext-equality

- Merge pull request [#29](https://github.com/montanaflynn/stats/issues/29) from edupsousa/master


⚠️ [alex] reported by reviewdog 🐶
master may be insensitive, use primary, lead, hub, reference instead master retext-equality

- Merge pull request [#24](https://github.com/montanaflynn/stats/issues/24) from alouche/master


⚠️ [alex] reported by reviewdog 🐶
master may be insensitive, use primary, lead, hub, reference instead master retext-equality

- Merge pull request [#21](https://github.com/montanaflynn/stats/issues/21) from brydavis/master


⚠️ [alex] reported by reviewdog 🐶
master may be insensitive, use primary, lead, hub, reference instead master retext-equality

- Merge pull request [#17](https://github.com/montanaflynn/stats/issues/17) from Kunde21/master


⚠️ [alex] reported by reviewdog 🐶
master may be insensitive, use primary, lead, hub, reference instead master retext-equality

- Merge pull request [#3](https://github.com/montanaflynn/stats/issues/3) from montanaflynn/master


⚠️ [alex] reported by reviewdog 🐶
master may be insensitive, use primary, lead, hub, reference instead master retext-equality

- Merge pull request [#2](https://github.com/montanaflynn/stats/issues/2) from montanaflynn/master


⚠️ [alex] reported by reviewdog 🐶
Be careful with MAD, it’s profane in some cases mad retext-profanities

- Merge pull request [#12](https://github.com/montanaflynn/stats/issues/12) from alixaxel/MAD


⚠️ [alex] reported by reviewdog 🐶
master may be insensitive, use primary, lead, hub, reference instead master retext-equality

- Merge pull request [#1](https://github.com/montanaflynn/stats/issues/1) from montanaflynn/master


⚠️ [alex] reported by reviewdog 🐶
Be careful with kills, it’s profane in some cases kills retext-profanities


⚠️ [alex] reported by reviewdog 🐶
Be careful with mad, it’s profane in some cases mad retext-profanities

* [func MedianAbsoluteDeviation(input Float64Data) (mad float64, err error)](#MedianAbsoluteDeviation)


⚠️ [alex] reported by reviewdog 🐶
Be careful with mad, it’s profane in some cases mad retext-profanities

* [func MedianAbsoluteDeviationPopulation(input Float64Data) (mad float64, err error)](#MedianAbsoluteDeviationPopulation)


⚠️ [alex] reported by reviewdog 🐶
simply may be insensitive, try not to use it simple retext-equality

If you have any suggestions, problems or bug reports please [create an issue](https://github.com/montanaflynn/stats/issues) and I'll do my best to accommodate you. In addition simply starring the repo would show your support for the project and be very much appreciated!


⚠️ [alex] reported by reviewdog 🐶
simple may be insensitive, try not to use it simple retext-equality

- Update `examples/main.go` with a simple example of the new feature


⚠️ [alex] reported by reviewdog 🐶
invalid may be insensitive, use turned off, has a disability, person with a disability, people with disabilities instead invalid retext-equality

* Gracefully handle invalid encodings when parsing.


⚠️ [alex] reported by reviewdog 🐶
special may be insensitive, use has a disability, person with a disability, people with disabilities instead special retext-equality


⚠️ [alex] reported by reviewdog 🐶
Reconsider using abuse, it may be profane abuse retext-profanities

This alphabet excludes the letters I, L, O, and U to avoid confusion and abuse.


⚠️ [alex] reported by reviewdog 🐶
Be careful with colors, it’s profane in some cases colors retext-profanities

- add GINKGO_NO_COLOR to disable colors via environment variables [bcab9c8]


⚠️ [alex] reported by reviewdog 🐶
Be careful with failures, it’s profane in some cases failures retext-profanities

- Fix docs for handling failures in goroutines (#1339) [4471b2e]


⚠️ [alex] reported by reviewdog 🐶
Be careful with failed, it’s profane in some cases failed retext-profanities

- emit output of failed go tool cover invocation so users can try to debug things for themselves [c245d09]


⚠️ [alex] reported by reviewdog 🐶
hang may be insensitive, use the app froze, the app stopped responding, the app stopped responding to events, the app became unresponsive instead hang retext-equality

- fix hang with ginkgo -p (#1192) [15d4bdc] - this addresses a _long_ standing issue related to Ginkgo hanging when a child process spawned by the test does not exit.


⚠️ [alex] reported by reviewdog 🐶
clearly may be insensitive, try not to use it clearly retext-equality

- document coverpkg a bit more clearly [fc44c3b]


⚠️ [alex] reported by reviewdog 🐶
simply may be insensitive, try not to use it simple retext-equality

Ginkgo now includes a `tools.go` file in the root directory of the `ginkgo` package. This should allow modules that simply `go get github.com/onsi/ginkgo/v2` to also pull in the CLI dependencies. This obviates the need for consumers of Ginkgo to have their own `tools.go` file and makes it simpler to ensure that the version of the `ginkgo` CLI being used matches the version of the library. You can simply run `go run github.com/onsi/ginkgo/v2/ginkgo` to run the version of the cli associated with your package go.mod.


⚠️ [alex] reported by reviewdog 🐶
simply may be insensitive, try not to use it simple retext-equality

Ginkgo now includes a `tools.go` file in the root directory of the `ginkgo` package. This should allow modules that simply `go get github.com/onsi/ginkgo/v2` to also pull in the CLI dependencies. This obviates the need for consumers of Ginkgo to have their own `tools.go` file and makes it simpler to ensure that the version of the `ginkgo` CLI being used matches the version of the library. You can simply run `go run github.com/onsi/ginkgo/v2/ginkgo` to run the version of the cli associated with your package go.mod.


⚠️ [alex] reported by reviewdog 🐶
simply may be insensitive, try not to use it simple retext-equality

you can stop tracking offsets (which makes nesting composing helpers nearly impossible) and simply write:


⚠️ [alex] reported by reviewdog 🐶
Be careful with Color, it’s profane in some cases color retext-profanities

- Color aliases for custom color support (#1101) [49fab7a]


⚠️ [alex] reported by reviewdog 🐶
Be careful with color, it’s profane in some cases color retext-profanities

- Color aliases for custom color support (#1101) [49fab7a]


⚠️ [alex] reported by reviewdog 🐶
Be careful with failures, it’s profane in some cases failures retext-profanities

- Fix a bug where timedout specs were not correctly treated as failures when determining whether or not to run AfterAlls in an Ordered container.


⚠️ [alex] reported by reviewdog 🐶
Be careful with colors, it’s profane in some cases colors retext-profanities

- Override formatter colors from envvars - this is a new feature but an alternative approach involving config files might be taken in the future (#1095) [60240d1]


⚠️ [alex] reported by reviewdog 🐶
Be careful with failure, it’s profane in some cases failure retext-profanities

to understand the flow of a spec and where a given failure occurs.


⚠️ [alex] reported by reviewdog 🐶
Be careful with failed, it’s profane in some cases failed retext-profanities

Several users were invoking `ginkgo` by installing the latest version of the cli via `go install github.com/onsi/ginkgo/v2/ginkgo@latest`. When 2.3.0 was released this resulted in an influx of issues as CI systems failed due to a change in the internal contract between the Ginkgo CLI and the Ginkgo library. Ginkgo only supports running the same version of the library as the cli (which is why both are packaged in the same repository).


⚠️ [alex] reported by reviewdog 🐶
Be careful with Period, it’s profane in some cases period retext-profanities

and have Ginkgo ensure that the node completes before the timeout elapses. If it does elapse, or if an external interrupt is received (e.g. `^C`) then Ginkgo will cancel the context and wait for the Grace Period for the node to exit before proceeding with any cleanup nodes associated with the spec. The `ctx` provided by Ginkgo can also be passed down to Gomega's `Eventually` to have all assertions within the node governed by a single deadline.


⚠️ [alex] reported by reviewdog 🐶
Be careful with failures, it’s profane in some cases failures retext-profanities

- Ginkgo now records any additional failures that occur during the cleanup of a failed spec. In prior versions this information was quietly discarded, but the introduction of a more rigorous approach to timeouts and interruptions allows Ginkgo to better track subsequent failures.


⚠️ [alex] reported by reviewdog 🐶
Be careful with failed, it’s profane in some cases failed retext-profanities

- Ginkgo now records any additional failures that occur during the cleanup of a failed spec. In prior versions this information was quietly discarded, but the introduction of a more rigorous approach to timeouts and interruptions allows Ginkgo to better track subsequent failures.


⚠️ [alex] reported by reviewdog 🐶
Be careful with crashes, it’s profane in some cases crashes retext-profanities

- fixes crashes on newer Ruby 3 installations by upgrading github-pages gem dependency [92c88d5]


⚠️ [alex] reported by reviewdog 🐶
simply may be insensitive, try not to use it simple retext-equality

As a result the **signature of these methods has changed** and now includes a trailing `args ...interface{}`. For most users simply using the DSL, this change is transparent. However if you were assigning one of these functions to a custom variable (or passing it around) then your code may need to change to reflect the new signature.


⚠️ [alex] reported by reviewdog 🐶
Be careful with failed, it’s profane in some cases failed retext-profanities

- Always emit spec summary [5cf23e2] - even when only one spec has failed


⚠️ [alex] reported by reviewdog 🐶
Be careful with failure, it’s profane in some cases failure retext-profanities

- Profiling suites with focused specs no longer generates an erroneous failure message [8fbfa02]


⚠️ [alex] reported by reviewdog 🐶
invalid may be insensitive, use turned off, has a disability, person with a disability, people with disabilities instead invalid retext-equality

- Add error check for invalid/nil parameters to DescribeTable [6f8577e]


⚠️ [alex] reported by reviewdog 🐶
Be careful with Chinese, it’s profane in some cases chinese retext-profanities

- Add a Chinese Doc #755 (#756) [5207632]


⚠️ [alex] reported by reviewdog 🐶
invalid may be insensitive, use turned off, has a disability, person with a disability, people with disabilities instead invalid retext-equality


⚠️ [alex] reported by reviewdog 🐶
Be careful with failure, it’s profane in some cases failure retext-profanities

- teamcity reporter: output location of test failure as well as test definition (#626) [9869142]


⚠️ [alex] reported by reviewdog 🐶
master may be insensitive, use primary, lead, hub, reference instead master retext-equality

- Travis badge should only show master [26d2143]


⚠️ [alex] reported by reviewdog 🐶
Be careful with failure, it’s profane in some cases failure retext-profanities

- Fix Ginkgo stack trace on failure for Specify (#415) [b977ede, 65ca40e, 6c46eb8]


⚠️ [alex] reported by reviewdog 🐶
Be careful with failed, it’s profane in some cases failed retext-profanities

- `ginkgo` now always emits compilation output. Previously, only failed compilation output was printed out. [#277]


⚠️ [alex] reported by reviewdog 🐶
simply may be insensitive, try not to use it simple retext-equality

- Add `By` to help document long `It`s. `By` simply writes to the `GinkgoWriter`.


⚠️ [alex] reported by reviewdog 🐶
Be careful with failure, it’s profane in some cases failure retext-profanities

- Fix incorrect failure message when a panic occurs during a parallel test run


⚠️ [alex] reported by reviewdog 🐶
hang may be insensitive, use the app froze, the app stopped responding, the app stopped responding to events, the app became unresponsive instead hang retext-equality

- Fixed a long standing bug where `ginkgo -p` would hang if a process spawned by one of the Ginkgo parallel nodes does not exit. (Hooray!)


⚠️ [alex] reported by reviewdog 🐶
just may be insensitive, try not to use it just retext-equality


⚠️ [alex] reported by reviewdog 🐶
Be careful with failures, it’s profane in some cases failures retext-profanities

- Ginkgo now summarizes any spec failures that occurred at the end of the test run.


⚠️ [alex] reported by reviewdog 🐶
just may be insensitive, try not to use it just retext-equality

- `--trace` flag prints out full stack traces when errors occur, not just the line at which the error occurs.


⚠️ [alex] reported by reviewdog 🐶
clearly may be insensitive, try not to use it clearly retext-equality

Ginkgo is a mature testing framework for Go designed to help you write expressive specs. Ginkgo builds on top of Go's `testing` foundation and is complemented by the [Gomega](https://github.com/onsi/gomega) matcher library. Together, Ginkgo and Gomega let you express the intent behind your specs clearly:


⚠️ [alex] reported by reviewdog 🐶
easy may be insensitive, try not to use it easy retext-equality

Jump to the [docs](https://onsi.github.io/ginkgo/) to learn more. It's easy to [bootstrap](https://onsi.github.io/ginkgo/#bootstrapping-a-suite) and start writing your [first specs](https://onsi.github.io/ginkgo/#adding-specs-to-a-suite).


⚠️ [alex] reported by reviewdog 🐶
easy may be insensitive, try not to use it easy retext-equality

At runtime, Ginkgo can run your specs in reproducibly [random order](https://onsi.github.io/ginkgo/#spec-randomization) and has sophisticated support for [spec parallelization](https://onsi.github.io/ginkgo/#spec-parallelization). In fact, running specs in parallel is as easy as


⚠️ [alex] reported by reviewdog 🐶
Be careful with period, it’s profane in some cases period retext-profanities

By following [established patterns for writing parallel specs](https://onsi.github.io/ginkgo/#patterns-for-parallel-integration-specs) you can build even large, complex integration suites that parallelize cleanly and run performantly. And you don't have to worry about your spec suite hanging or leaving a mess behind - Ginkgo provides a per-node `context.Context` and the capability to interrupt the spec after a set period of time - and then clean up.


⚠️ [alex] reported by reviewdog 🐶
easily may be insensitive, try not to use it easy retext-equality

As your suites grow Ginkgo helps you keep your specs organized with [labels](https://onsi.github.io/ginkgo/#spec-labels) and lets you easily run [subsets of specs](https://onsi.github.io/ginkgo/#filtering-specs), either [programmatically](https://onsi.github.io/ginkgo/#focused-specs) or on the [command line](https://onsi.github.io/ginkgo/#combining-filters). And Ginkgo's reporting infrastructure generates machine-readable output in a [variety of formats](https://onsi.github.io/ginkgo/#generating-machine-readable-reports) _and_ allows you to build your own [custom reporting infrastructure](https://onsi.github.io/ginkgo/#generating-reports-programmatically).


⚠️ [alex] reported by reviewdog 🐶
just may be insensitive, try not to use it just retext-equality

And that's just Ginkgo! [Gomega](https://onsi.github.io/gomega/) brings a rich, mature, family of [assertions and matchers](https://onsi.github.io/gomega/#provided-matchers) to your suites. With Gomega you can easily mix [synchronous and asynchronous assertions](https://onsi.github.io/ginkgo/#patterns-for-asynchronous-testing) in your specs. You can even build your own set of expressive domain-specific matchers quickly and easily by composing Gomega's [existing building blocks](https://onsi.github.io/ginkgo/#building-custom-matchers).


⚠️ [alex] reported by reviewdog 🐶
easily may be insensitive, try not to use it easy retext-equality

And that's just Ginkgo! [Gomega](https://onsi.github.io/gomega/) brings a rich, mature, family of [assertions and matchers](https://onsi.github.io/gomega/#provided-matchers) to your suites. With Gomega you can easily mix [synchronous and asynchronous assertions](https://onsi.github.io/ginkgo/#patterns-for-asynchronous-testing) in your specs. You can even build your own set of expressive domain-specific matchers quickly and easily by composing Gomega's [existing building blocks](https://onsi.github.io/ginkgo/#building-custom-matchers).


⚠️ [alex] reported by reviewdog 🐶
easily may be insensitive, try not to use it easy retext-equality

And that's just Ginkgo! [Gomega](https://onsi.github.io/gomega/) brings a rich, mature, family of [assertions and matchers](https://onsi.github.io/gomega/#provided-matchers) to your suites. With Gomega you can easily mix [synchronous and asynchronous assertions](https://onsi.github.io/ginkgo/#patterns-for-asynchronous-testing) in your specs. You can even build your own set of expressive domain-specific matchers quickly and easily by composing Gomega's [existing building blocks](https://onsi.github.io/ginkgo/#building-custom-matchers).


⚠️ [alex] reported by reviewdog 🐶
Be careful with failure, it’s profane in some cases failure retext-profanities

- You can call `StopTrying(message).Successfully()` to abort a `Consistently` early without failure [eeca931]


⚠️ [alex] reported by reviewdog 🐶
Be careful with failure, it’s profane in some cases failure retext-profanities

- BeTrueBecause and BeFalseBecause allow for better failure messages [4da4c7f]


⚠️ [alex] reported by reviewdog 🐶
Be careful with failure, it’s profane in some cases failure retext-profanities

- improve eventually failure message output [c530fb3]


⚠️ [alex] reported by reviewdog 🐶
Be careful with failure, it’s profane in some cases failure retext-profanities

- Correctly handle assertion failure panics for eventually/consistnetly "g Gomega"s in a goroutine [78f1660]


⚠️ [alex] reported by reviewdog 🐶
Be careful with failure, it’s profane in some cases failure retext-profanities

- `StopTrying()` is now always interpreted as a failure. If you are an early adopter of `StopTrying()` you may need to change your code as the prior version would match against the returned value even if `StopTrying()` was returned. Going forward the `StopTrying()` api should remain stable.


⚠️ [alex] reported by reviewdog 🐶
just may be insensitive, try not to use it just retext-equality

- `StopTrying()` and `StopTrying().Now()` can both be used in matchers - not just polled functions.


⚠️ [alex] reported by reviewdog 🐶
Be careful with crashes, it’s profane in some cases crashes retext-profanities

- Fixes crashes on newer Ruby 3 installations by upgrading github-pages gem dependency (#596) [12469a0]


⚠️ [alex] reported by reviewdog 🐶
easily may be insensitive, try not to use it easy retext-equality

- [`ContainElement`](https://onsi.github.io/gomega/#containelementelement-interface) now accepts an additional pointer argument. Elements that satisfy the matcher are stored in the pointer enabling developers to easily add subsequent, more detailed, assertions against the matching element. (#527) [1a4e27f]


⚠️ [alex] reported by reviewdog 🐶
master may be insensitive, use primary, lead, hub, reference instead master retext-equality

- Docs now live on the master branch in the docs folder which will make for easier PRs. The docs also use Ginkgo 2.0's new docs html/css/js. [2570272]


⚠️ [alex] reported by reviewdog 🐶
Be careful with failures, it’s profane in some cases failures retext-profanities

1.15.0 resolves this by requiring users who want to make assertions in `Eventually/Consistently` call backs to explicitly pass in a function that takes a `Gomega` as an argument. The passed-in `Gomega` instance can be used to make assertions. Any failures will cause `Eventually` to retry the callback. This cleaner interface avoids the issue of swapping out globals but comes at the cost of changing the contract introduced in v1.14.0. As such 1.15.0 introduces a breaking change with respect to 1.14.0 - however we expect that adoption of this feature in 1.14.0 remains limited.


⚠️ [alex] reported by reviewdog 🐶
Be careful with remains, it’s profane in some cases remains retext-profanities

1.15.0 resolves this by requiring users who want to make assertions in `Eventually/Consistently` call backs to explicitly pass in a function that takes a `Gomega` as an argument. The passed-in `Gomega` instance can be used to make assertions. Any failures will cause `Eventually` to retry the callback. This cleaner interface avoids the issue of swapping out globals but comes at the cost of changing the contract introduced in v1.14.0. As such 1.15.0 introduces a breaking change with respect to 1.14.0 - however we expect that adoption of this feature in 1.14.0 remains limited.


⚠️ [alex] reported by reviewdog 🐶
Be careful with failed, it’s profane in some cases failed retext-profanities

These assertions must pass or the function is considered to have failed and is retried.


⚠️ [alex] reported by reviewdog 🐶
Be careful with failed, it’s profane in some cases failed retext-profanities

if they contain no failed assertion. Otherwise they return an error wrapping the first assertion failure. This allows


⚠️ [alex] reported by reviewdog 🐶
Be careful with failure, it’s profane in some cases failure retext-profanities

if they contain no failed assertion. Otherwise they return an error wrapping the first assertion failure. This allows


⚠️ [alex] reported by reviewdog 🐶
Be careful with failure, it’s profane in some cases failure retext-profanities

- Introduce InterceptGomegaFailure - an analogue to InterceptGomegaFailures - that captures the first assertion failure


⚠️ [alex] reported by reviewdog 🐶
Be careful with execution, it’s profane in some cases execution retext-profanities

and halts execution in its passed-in callback.


⚠️ [alex] reported by reviewdog 🐶
Be careful with failure, it’s profane in some cases failure retext-profanities

- Output missing and extra elements in ConsistOf failure message [a31eda7]


⚠️ [alex] reported by reviewdog 🐶
special may be insensitive, use has a disability, person with a disability, people with disabilities instead special retext-equality

- Display special chars on error [41e1b26]


⚠️ [alex] reported by reviewdog 🐶
Be careful with failure, it’s profane in some cases failure retext-profanities

- Add failure message tests to BeElementOf matcher [efe19c3]


⚠️ [alex] reported by reviewdog 🐶
Be careful with failure, it’s profane in some cases failure retext-profanities

- show threshold in failure message of BeNumericallyMatcher (#293) [4bbecc8]


⚠️ [alex] reported by reviewdog 🐶
master may be insensitive, use primary, lead, hub, reference instead master retext-equality

- Travis badge should only show master [cc102ab]


⚠️ [alex] reported by reviewdog 🐶
Be careful with failure, it’s profane in some cases failure retext-profanities

- Changed OmegaMatcher interface. Instead of having `Match` return failure messages, two new methods `FailureMessage` and `NegatedFailureMessage` are called instead.


⚠️ [alex] reported by reviewdog 🐶
easy may be insensitive, try not to use it easy retext-equality

- Makes it easy to assert against stdout and stderr


⚠️ [alex] reported by reviewdog 🐶
easy may be insensitive, try not to use it easy retext-equality

- Makes it easy to send signals and wait for processes to exit


⚠️ [alex] reported by reviewdog 🐶
Special may be insensitive, use Has a disability, Person with a disability, People with disabilities instead special retext-equality

Special thanks to [@Zariel](https://github.com/Zariel) for his asm implementation of the decoder.


⚠️ [alex] reported by reviewdog 🐶
his may be insensitive, when referring to a person, use their, theirs, them instead her-him retext-equality

Special thanks to [@Zariel](https://github.com/Zariel) for his asm implementation of the decoder.


⚠️ [alex] reported by reviewdog 🐶
Special may be insensitive, use Has a disability, Person with a disability, People with disabilities instead special retext-equality

Special thanks to [@klauspost](https://github.com/klauspost) for his work on optimizing the code.


⚠️ [alex] reported by reviewdog 🐶
his may be insensitive, when referring to a person, use their, theirs, them instead her-him retext-equality

Special thanks to [@klauspost](https://github.com/klauspost) for his work on optimizing the code.


⚠️ [alex] reported by reviewdog 🐶
simple may be insensitive, try not to use it simple retext-equality

Package errors provides simple error handling primitives.


⚠️ [alex] reported by reviewdog 🐶
Be careful with failure, it’s profane in some cases failure retext-profanities

which applied recursively up the call stack results in error reports without context or debugging information. The errors package allows programmers to add context to the failure path in their code in a way that does not destroy the original value of the error.


⚠️ [alex] reported by reviewdog 🐶
Be careful with destroy, it’s profane in some cases destroy retext-profanities

which applied recursively up the call stack results in error reports without context or debugging information. The errors package allows programmers to add context to the failure path in their code in a way that does not destroy the original value of the error.


⚠️ [alex] reported by reviewdog 🐶
special may be insensitive, use has a disability, person with a disability, people with disabilities instead special retext-equality

We use [`golangci-lint`](https://github.com/golangci/golangci-lint) for linting the code. If it reports an issue and you think that the warning needs to be disregarded or is a false-positive, you can add a special comment `//nolint:linter1[,linter2,...]` before the offending line. Use this sparingly though, fixing the code to comply with the linter's recommendation is in general the preferred course of action.


⚠️ [alex] reported by reviewdog 🐶
master may be insensitive, use primary, lead, hub, reference instead master retext-equality

* Branch from the master branch and, if needed, rebase to the current master branch before submitting your pull request. If it doesn't merge cleanly with master you may be asked to rebase your changes.


⚠️ [alex] reported by reviewdog 🐶
master may be insensitive, use primary, lead, hub, reference instead master retext-equality

* Branch from the master branch and, if needed, rebase to the current master branch before submitting your pull request. If it doesn't merge cleanly with master you may be asked to rebase your changes.


⚠️ [alex] reported by reviewdog 🐶
master may be insensitive, use primary, lead, hub, reference instead master retext-equality

* Branch from the master branch and, if needed, rebase to the current master branch before submitting your pull request. If it doesn't merge cleanly with master you may be asked to rebase your changes.


⚠️ [alex] reported by reviewdog 🐶
just may be insensitive, try not to use it just retext-equality

extracting the ttar file using `make fixtures/.unpacked` or just `make test`.


⚠️ [alex] reported by reviewdog 🐶
master may be insensitive, use primary, lead, hub, reference instead master retext-equality

feature requests, and rough edges. It is based on a merge of master which


⚠️ [alex] reported by reviewdog 🐶
easy may be insensitive, try not to use it easy retext-equality

- Standard cron spec parsing by default (first field is "minute"), with an easy


⚠️ [alex] reported by reviewdog 🐶
Be careful with execution, it’s profane in some cases execution retext-profanities

- Delay a job's execution if the previous run hasn't completed yet


⚠️ [alex] reported by reviewdog 🐶
Be careful with execution, it’s profane in some cases execution retext-profanities

- Skip a job's execution if the previous run hasn't completed yet


⚠️ [alex] reported by reviewdog 🐶
easy may be insensitive, try not to use it easy retext-equality

will continue to be supported since it is unambiguous and easy to do so.


⚠️ [alex] reported by reviewdog 🐶
Master may be insensitive, use Primary, Lead, Hub, Reference instead master retext-equality

Cobra will follow a steady release cadence. Non breaking changes will be released as minor versions quarterly. Patch bug releases are at the discretion of the maintainers. Users can expect security patch fixes to be released within relatively short order of a CVE becoming known. For more information on security patch fixes see the CVE section below. Releases will follow [Semantic Versioning](https://semver.org/). Users tracking the Master branch should expect unpredictable breaking changes as the project continues to move forward. For stability, it is highly recommended to use a release.


⚠️ [alex] reported by reviewdog 🐶
master may be insensitive, use primary, lead, hub, reference instead master retext-equality

Breaking changes are generally allowed in the master branch, as this is the branch used to develop the next release of Cobra.


⚠️ [alex] reported by reviewdog 🐶
master may be insensitive, use primary, lead, hub, reference instead master retext-equality

There may be times, however, when master is closed for breaking changes. This is likely to happen as we near the release of a new version.


⚠️ [alex] reported by reviewdog 🐶
Be careful with executed, it’s profane in some cases executed retext-profanities

the terms of any separate license agreement you may have executed


⚠️ [alex] reported by reviewdog 🐶
Be careful with failure, it’s profane in some cases failure retext-profanities

Work (including but not limited to damages for loss of goodwill,


⚠️ [alex] reported by reviewdog 🐶
simple may be insensitive, try not to use it simple retext-equality

Cobra is a library providing a simple interface to create powerful modern CLI


⚠️ [alex] reported by reviewdog 🐶
Easy may be insensitive, try not to use it easy retext-equality

* Easy subcommand-based CLIs: `app server`, `app fetch`, etc.


⚠️ [alex] reported by reviewdog 🐶
man may be insensitive, use people, persons, folks instead gals-man retext-equality

* Automatically generated man pages for your application


⚠️ [alex] reported by reviewdog 🐶
easy may be insensitive, try not to use it easy retext-equality

Using Cobra is easy. First, use `go get` to install the latest version


⚠️ [alex] reported by reviewdog 🐶
just may be insensitive, try not to use it just retext-equality

For such flags, the default value is just the initial value of the variable.


⚠️ [alex] reported by reviewdog 🐶
just may be insensitive, try not to use it just retext-equality

It is possible to deprecate a flag, or just its shorthand. Deprecating a flag/shorthand hides it from help text and prints a usage message when the deprecated flag/shorthand is used.


⚠️ [alex] reported by reviewdog 🐶
Special may be insensitive, use Has a disability, Person with a disability, People with disabilities instead special retext-equality


⚠️ [alex] reported by reviewdog 🐶
Special may be insensitive, use Has a disability, Person with a disability, People with disabilities instead special retext-equality

Special thanks to Kathryn Long (starkat99) for creating [half-rs](https://github.com/starkat99/half-rs), a very nice rust implementation of float16.


⚠️ [alex] reported by reviewdog 🐶
disabled may be insensitive, use turned off, has a disability, person with a disability, people with disabilities instead invalid retext-equality

- Enable exemplars by default in `go.opentelemetry.io/otel/sdk/metric`. Exemplars can be disabled by setting `OTEL_METRICS_EXEMPLAR_FILTER=always_off` (#5778)


⚠️ [alex] reported by reviewdog 🐶
Be careful with failure, it’s profane in some cases failure retext-profanities

- Pass the underlying error rather than a generic retry-able failure in `go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetrichttp`, `go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploghttp` and `go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp`. (#5541)


⚠️ [alex] reported by reviewdog 🐶
invalid may be insensitive, use turned off, has a disability, person with a disability, people with disabilities instead invalid retext-equality

- Remove invalid environment variable header keys in `go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc`, `go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp`, `go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetricgrpc` and `go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetrichttp` (#5705)


⚠️ [alex] reported by reviewdog 🐶
invalid may be insensitive, use turned off, has a disability, person with a disability, people with disabilities instead invalid retext-equality

- Retry trace and span ID generation if it generated an invalid one in `go.opentelemetry.io/otel/sdk/trace`. (#5514)


⚠️ [alex] reported by reviewdog 🐶
invalid may be insensitive, use turned off, has a disability, person with a disability, people with disabilities instead invalid retext-equality

- Replace invalid percent-encoded octet sequences with replacement char in `go.opentelemetry.io/otel/baggage`. (#5528)


⚠️ [alex] reported by reviewdog 🐶
just may be insensitive, try not to use it just retext-equality

- Register all callbacks passed during observable instrument creation instead of just the last one multiple times in `go.opentelemetry.io/otel/sdk/metric`. (#4888)


⚠️ [alex] reported by reviewdog 🐶
whitespace may be insensitive, use space, blank instead whitespace retext-equality

- Fix whitespace encoding of `Member.String` in `go.opentelemetry.io/otel/baggage`. (#4756)


⚠️ [alex] reported by reviewdog 🐶
Be careful with failures, it’s profane in some cases failures retext-profanities

- Retry temporary HTTP request failures in `go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetrichttp`. (#4679)


⚠️ [alex] reported by reviewdog 🐶
Be careful with failures, it’s profane in some cases failures retext-profanities

- Retry temporary HTTP request failures in `go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp`. (#4679)


⚠️ [alex] reported by reviewdog 🐶
whitespace may be insensitive, use space, blank instead whitespace retext-equality

- Fix improper parsing of characters such us `+`, `/` by `Parse` in `go.opentelemetry.io/otel/baggage` as they were rendered as a whitespace. (#4667)


⚠️ [alex] reported by reviewdog 🐶
whitespace may be insensitive, use space, blank instead whitespace retext-equality

- Fix improper parsing of characters such us `+`, `/` passed via `OTEL_RESOURCE_ATTRIBUTES` in `go.opentelemetry.io/otel/sdk/resource` as they were rendered as a whitespace. (#4699)


⚠️ [alex] reported by reviewdog 🐶
whitespace may be insensitive, use space, blank instead whitespace retext-equality

- Fix improper parsing of characters such us `+`, `/` passed via `OTEL_EXPORTER_OTLP_HEADERS` and `OTEL_EXPORTER_OTLP_METRICS_HEADERS` in `go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetricgrpc` as they were rendered as a whitespace. (#4699)


⚠️ [alex] reported by reviewdog 🐶
whitespace may be insensitive, use space, blank instead whitespace retext-equality

- Fix improper parsing of characters such us `+`, `/` passed via `OTEL_EXPORTER_OTLP_HEADERS` and `OTEL_EXPORTER_OTLP_METRICS_HEADERS` in `go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetrichttp` as they were rendered as a whitespace. (#4699)


⚠️ [alex] reported by reviewdog 🐶
whitespace may be insensitive, use space, blank instead whitespace retext-equality

- Fix improper parsing of characters such us `+`, `/` passed via `OTEL_EXPORTER_OTLP_HEADERS` and `OTEL_EXPORTER_OTLP_TRACES_HEADERS` in `go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlptracegrpc` as they were rendered as a whitespace. (#4699)


⚠️ [alex] reported by reviewdog 🐶
whitespace may be insensitive, use space, blank instead whitespace retext-equality

- Fix improper parsing of characters such us `+`, `/` passed via `OTEL_EXPORTER_OTLP_HEADERS` and `OTEL_EXPORTER_OTLP_TRACES_HEADERS` in `go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlptracehttp` as they were rendered as a whitespace. (#4699)


⚠️ [alex] reported by reviewdog 🐶
invalid may be insensitive, use turned off, has a disability, person with a disability, people with disabilities instead invalid retext-equality

- In `go.opentelemetry.op/otel/exporters/prometheus`, don't try to create the Prometheus metric on every `Collect` if we know the scope is invalid. (#4499)


⚠️ [alex] reported by reviewdog 🐶
invalid may be insensitive, use turned off, has a disability, person with a disability, people with disabilities instead invalid retext-equality

- In `go.opentelemetry.op/otel/exporters/prometheus`, don't try to create the prometheus metric on every `Collect` if we know the scope is invalid. (#4499)


⚠️ [alex] reported by reviewdog 🐶
Be careful with failures, it’s profane in some cases failures retext-profanities

- Remove unused imports from `sdk/resource/host_id_bsd.go` which caused build failures. (#4040, #4041)


⚠️ [alex] reported by reviewdog 🐶
just may be insensitive, try not to use it just retext-equality

- The `New` and `Detect` functions from `go.opentelemetry.io/otel/sdk/resource` return errors that wrap underlying errors instead of just containing the underlying error strings. (#3844)


⚠️ [alex] reported by reviewdog 🐶
just may be insensitive, try not to use it just retext-equality

- Multi-reader `MeterProvider`s now export metrics for all readers, instead of just the first reader. (#3720, #3724)


⚠️ [alex] reported by reviewdog 🐶
disabled may be insensitive, use turned off, has a disability, person with a disability, people with disabilities instead invalid retext-equality

This can be disabled using the `WithoutScopeInfo()` option added to that package.(#3273, #3357)


⚠️ [alex] reported by reviewdog 🐶
disabled may be insensitive, use turned off, has a disability, person with a disability, people with disabilities instead invalid retext-equality

This can be disabled using the `WithoutUnits()` option added to that package. (#3352)


⚠️ [alex] reported by reviewdog 🐶
Invalid may be insensitive, use Turned off, Has a disability, Person with a disability, People with disabilities instead invalid retext-equality

Invalid characters are replaced with `_`. (#3212)


⚠️ [alex] reported by reviewdog 🐶
Invalid may be insensitive, use Turned off, Has a disability, Person with a disability, People with disabilities instead invalid retext-equality

- Invalid warning for context setup being deferred in `go.opentelemetry.io/otel/bridge/opentracing` package. (#3029)


⚠️ [alex] reported by reviewdog 🐶
invalid may be insensitive, use turned off, has a disability, person with a disability, people with disabilities instead invalid retext-equality

If the provided environment variables are invalid (negative), the default values would be used.


⚠️ [alex] reported by reviewdog 🐶
host's may be insensitive, use presenters, entertainers, emcees instead hostesses-hosts retext-equality

- The `go.opentelemetry.io/otel/exporter/otel/*` gRPC exporters now default to using the host's root CA set if none are provided by the user and `WithInsecure` is not specified. (#2432)


⚠️ [alex] reported by reviewdog 🐶
simply may be insensitive, try not to use it simple retext-equality

- The following interface types simply moved from `metric` to `metric/sdkapi`: `Descriptor`, `MeterImpl`, `InstrumentImpl`, `SyncImpl`, `BoundSyncImpl`, `AsyncImpl`, `AsyncRunner`, `AsyncSingleRunner`, and `AsyncBatchRunner`


⚠️ [alex] reported by reviewdog 🐶
invalid may be insensitive, use turned off, has a disability, person with a disability, people with disabilities instead invalid retext-equality

- Links added to a span will be dropped by the SDK if they contain an invalid span context (#2275).


⚠️ [alex] reported by reviewdog 🐶
simple may be insensitive, try not to use it simple retext-equality

- The simple span processor shutdown method deterministically returns the exporter error status if it simultaneously finishes when the deadline is reached. (#2290, #2289)


⚠️ [alex] reported by reviewdog 🐶
Be careful with crashes, it’s profane in some cases crashes retext-profanities

- json stdout exporter no longer crashes due to concurrency bug. (#2265)


⚠️ [alex] reported by reviewdog 🐶
Be careful with failures, it’s profane in some cases failures retext-profanities

- BatchSpanProcessor now report export failures when calling `ForceFlush()` method. (#1860)


⚠️ [alex] reported by reviewdog 🐶
just may be insensitive, try not to use it just retext-equality

This brings the export interface into compliance with the specification in that it now accepts an explicitly immutable type instead of just an implied one. (#1873)


⚠️ [alex] reported by reviewdog 🐶
Be careful with premature, it’s profane in some cases premature retext-profanities

These functions were deemed premature attempts to provide convenience that did not achieve this aim. (#1985)


⚠️ [alex] reported by reviewdog 🐶
simple may be insensitive, try not to use it simple retext-equality

- The `Shutdown` method of the simple `SpanProcessor` in the `go.opentelemetry.io/otel/sdk/trace` package now honors the context deadline or cancellation. (#1616, #1856)


⚠️ [alex] reported by reviewdog 🐶
Be careful with failed, it’s profane in some cases failed retext-profanities

- BatchSpanProcessor now drops span batches that failed to be exported. (#1860)


⚠️ [alex] reported by reviewdog 🐶
whitespace may be insensitive, use space, blank instead whitespace retext-equality

- Allow trailing and leading whitespace in the parsing of a `tracestate` header. (#1931)


⚠️ [alex] reported by reviewdog 🐶
just may be insensitive, try not to use it just retext-equality

- The storage of a local or remote Span in a `context.Context` using its SpanContext is unified to store just the current Span.


⚠️ [alex] reported by reviewdog 🐶
just may be insensitive, try not to use it just retext-equality

This means that `"go.opentelemetry.io/otel/trace".ContextWithRemoteSpanContext` will now overwrite any existing current Span, not just existing remote Spans, and make it the current Span in a `context.Context`. (#1731)


⚠️ [alex] reported by reviewdog 🐶
just may be insensitive, try not to use it just retext-equality

- The concept of a remote and local Span stored in a context is unified to just the current Span.


⚠️ [alex] reported by reviewdog 🐶
easily may be insensitive, try not to use it easy retext-equality

These functions are provided as a way to easily setup or install the exporter with what are deemed reasonable SDK settings for common use cases.


⚠️ [alex] reported by reviewdog 🐶
Be careful with failure, it’s profane in some cases failure retext-profanities

- Update the `Shutdown` method to the `"go.opentelemetry.io/otel/sdk/trace".TracerProvider` return an error on shutdown failure. (#1608)


⚠️ [alex] reported by reviewdog 🐶
just may be insensitive, try not to use it just retext-equality

- Store the parent's full `SpanContext` rather than just its span ID in the `span` struct. (#1360)


⚠️ [alex] reported by reviewdog 🐶
host may be insensitive, use presenter, entertainer, emcee instead host-hostess retext-equality

This change adds a new optional implementation of the udp conn interface used to detect changes to an agent's host dns record.


⚠️ [alex] reported by reviewdog 🐶
invalid may be insensitive, use turned off, has a disability, person with a disability, people with disabilities instead invalid retext-equality

Preference is given to Single Header encoding with Multiple Header being the fallback if Single Header is not found or is invalid.


⚠️ [alex] reported by reviewdog 🐶
Be careful with failed, it’s profane in some cases failed retext-profanities

- Default service config to enable retries for retry-able failed requests in the OTLP exporter and an option to override this default. (#777)


⚠️ [alex] reported by reviewdog 🐶
just may be insensitive, try not to use it just retext-equality

- Send configured headers with every request in the OTLP exporter, instead of just on connection creation. (#806)


⚠️ [alex] reported by reviewdog 🐶
Be careful with failure, it’s profane in some cases failure retext-profanities

- Fixed `global` `handler_test.go` test failure. #804


⚠️ [alex] reported by reviewdog 🐶
simple may be insensitive, try not to use it simple retext-equality

- Create basic `othttp.Transport` for simple client instrumentation. (#678)


⚠️ [alex] reported by reviewdog 🐶
just may be insensitive, try not to use it just retext-equality

- Rename `NewKey` in the `kv` package to just `Key`. (#721)


⚠️ [alex] reported by reviewdog 🐶
simple may be insensitive, try not to use it simple retext-equality

- The metric `export.Labels` became an interface which the SDK implements and the `export` package provides a simple, immutable implementation of this interface intended for testing purposes. (#574)


⚠️ [alex] reported by reviewdog 🐶
Be careful with executed, it’s profane in some cases executed retext-profanities

The checkpoint function is executed in a single thread so we can do the encoding lazily before passing the encoded version of labels to the exporter.


⚠️ [alex] reported by reviewdog 🐶
Be careful with crash, it’s profane in some cases crash retext-profanities

- Fix a possible nil-dereference crash (#478)


⚠️ [alex] reported by reviewdog 🐶
Don’t use stringer, it’s profane stringer retext-profanities

- Fix a dependency issue (generate target should depend on stringer, not lint target) in Makefile. (#442)


⚠️ [alex] reported by reviewdog 🐶
special may be insensitive, use has a disability, person with a disability, people with disabilities instead special retext-equality

The Go special interest group (SIG) meets regularly. See the


⚠️ [alex] reported by reviewdog 🐶
just may be insensitive, try not to use it just retext-equality


⚠️ [alex] reported by reviewdog 🐶
Be careful with desires, it’s profane in some cases desires retext-profanities

OpenTelemetry is an evolving specification, one where the desires and


⚠️ [alex] reported by reviewdog 🐶
easily may be insensitive, try not to use it easy retext-equality

Moreover, the interface becomes sealed so the user cannot easily implement


⚠️ [alex] reported by reviewdog 🐶
special may be insensitive, use has a disability, person with a disability, people with disabilities instead special retext-equality

special case of a boolean options `Without*`) and should have the following


⚠️ [alex] reported by reviewdog 🐶
simple may be insensitive, try not to use it simple retext-equality

to ensure it is sufficiently documented. One simple measure that contributes


⚠️ [alex] reported by reviewdog 🐶
simple may be insensitive, try not to use it simple retext-equality

simple interface for the specific functionality that you want to add or it can


⚠️ [alex] reported by reviewdog 🐶
simple may be insensitive, try not to use it simple retext-equality

This new type can be used similar to the simple interface above in that a


⚠️ [alex] reported by reviewdog 🐶
simple may be insensitive, try not to use it simple retext-equality

interfaces and will duplicate the pattern. For this reason, the simple targeted


⚠️ [alex] reported by reviewdog 🐶
just may be insensitive, try not to use it just retext-equality

platform. This project allows you to do just that for applications written in


⚠️ [alex] reported by reviewdog 🐶
Be careful with Failure, it’s profane in some cases failure retext-profanities

Failure to do so will leave things in a broken state. As long as you do not


⚠️ [alex] reported by reviewdog 🐶
Be careful with Failure, it’s profane in some cases failure retext-profanities

[Failure to do so will lead to minor emergencies and tough to work around](https://github.com/open-telemetry/opentelemetry-go/issues/331).


⚠️ [alex] reported by reviewdog 🐶
just may be insensitive, try not to use it just retext-equality

Importantly, bump any package versions referenced to be the latest one you just released and ensure all code examples still compile and are accurate.


⚠️ [alex] reported by reviewdog 🐶
just may be insensitive, try not to use it just retext-equality

- The `errors.Is` and `errors.As` functions *just work*.


⚠️ [alex] reported by reviewdog 🐶
easily may be insensitive, try not to use it easy retext-equality

* [#629][]: Added `zapcore.TimeEncoderOfLayout` to easily create time encoders


⚠️ [alex] reported by reviewdog 🐶
Be careful with hook, it’s profane in some cases hook retext-profanities

adds support for monitoring sampling decisions through a hook.


⚠️ [alex] reported by reviewdog 🐶
invalid may be insensitive, use turned off, has a disability, person with a disability, people with disabilities instead invalid retext-equality

* [#791][]: Fix panic on attempting to build a logger with an invalid Config.


⚠️ [alex] reported by reviewdog 🐶
invalid may be insensitive, use turned off, has a disability, person with a disability, people with disabilities instead invalid retext-equality

* [#799][]: Fix issue introduced in 1.14.0 that caused invalid JSON output to


⚠️ [alex] reported by reviewdog 🐶
disabled may be insensitive, use turned off, has a disability, person with a disability, people with disabilities instead invalid retext-equality

* [#771][]: Optimize calls for disabled log levels.


⚠️ [alex] reported by reviewdog 🐶
Be careful with colored, it’s profane in some cases colored retext-profanities

* [#307][]: Users can opt into colored output for log levels.


⚠️ [alex] reported by reviewdog 🐶
Be careful with hijacking, it’s profane in some cases hijacking retext-profanities

* [#353][]: In addition to hijacking the output of the standard library's


⚠️ [alex] reported by reviewdog 🐶
invalid may be insensitive, use turned off, has a disability, person with a disability, people with disabilities instead invalid retext-equality

* [#309][] and [#317][]: RC1 was mistakenly shipped with invalid


⚠️ [alex] reported by reviewdog 🐶
easy may be insensitive, try not to use it easy retext-equality

* The `zapcore.Core` type makes it easy for third-party packages to use zap's


⚠️ [alex] reported by reviewdog 🐶
Reconsider using sexual, it may be profane sexual retext-profanities

experience, nationality, personal appearance, race, religion, or sexual


⚠️ [alex] reported by reviewdog 🐶
Reconsider using sexual, it may be profane sexual retext-profanities

* The use of sexualized language or imagery and unwelcome sexual attention or


⚠️ [alex] reported by reviewdog 🐶
Be careful with attacks, it’s profane in some cases attacks retext-profanities

* Trolling, insulting/derogatory comments, and personal or political attacks


⚠️ [alex] reported by reviewdog 🐶
Be careful with reject, it’s profane in some cases reject retext-profanities

reject comments, commits, code, wiki edits, issues, and other contributions


⚠️ [alex] reported by reviewdog 🐶
Be careful with faith, it’s profane in some cases faith retext-profanities

faith may face temporary or permanent repercussions as determined by other


⚠️ [alex] reported by reviewdog 🐶
fellow may be insensitive, use person, friend, pal, folk, individual instead gal-guy retext-equality

communications, please remember to treat your fellow contributors with


⚠️ [alex] reported by reviewdog 🐶
Of course may be insensitive, try not to use it of-course retext-equality

Of course, most applications won't notice the impact of a slow logger: they


⚠️ [alex] reported by reviewdog 🐶
Be careful with harder, it’s profane in some cases harder retext-profanities

isn't any harder to use than other logging packages, and the `Logger` makes


⚠️ [alex] reported by reviewdog 🐶
Be careful with bigger, it’s profane in some cases bigger retext-profanities

out][go-proverbs], "The bigger the interface, the weaker the abstraction."


⚠️ [alex] reported by reviewdog 🐶
just may be insensitive, try not to use it just retext-equality


⚠️ [alex] reported by reviewdog 🐶
easily may be insensitive, try not to use it easy retext-equality

can easily make this bad situation worse: not only is your application coping


⚠️ [alex] reported by reviewdog 🐶
Be careful with crash, it’s profane in some cases crash retext-profanities

crash when an error is truly unrecoverable. To avoid losing any information


⚠️ [alex] reported by reviewdog 🐶
Be careful with crash, it’s profane in some cases crash retext-profanities

&mdash; especially the reason for the crash &mdash; the logger must flush any


⚠️ [alex] reported by reviewdog 🐶
easy may be insensitive, try not to use it easy retext-equality

Zap makes this easy by offering `Panic` and `Fatal` logging methods that


⚠️ [alex] reported by reviewdog 🐶
Of course may be insensitive, try not to use it of-course retext-equality

automatically flush before exiting. Of course, this doesn't guarantee that


⚠️ [alex] reported by reviewdog 🐶
simple may be insensitive, try not to use it simple retext-equality

If you follow two simple rules, everything should work: install zap with `go


⚠️ [alex] reported by reviewdog 🐶
easy may be insensitive, try not to use it easy retext-equality

However, it's easy to integrate a log rotation package like


⚠️ [alex] reported by reviewdog 🐶
just may be insensitive, try not to use it just retext-equality

they do is add a single endpoint variable. If you just want to add a


⚠️ [alex] reported by reviewdog 🐶
special may be insensitive, use has a disability, person with a disability, people with disabilities instead special retext-equality

or the specific OS/Architecture pair respectively) that need special handling


⚠️ [alex] reported by reviewdog 🐶
just may be insensitive, try not to use it just retext-equality

Adding a new syscall often just requires adding a new `//sys` function prototype


⚠️ [alex] reported by reviewdog 🐶
just may be insensitive, try not to use it just retext-equality

just include the error numbers and error strings, but also the signal numbers


⚠️ [alex] reported by reviewdog 🐶
easy may be insensitive, try not to use it easy retext-equality

subject line, so it is easy to find.


⚠️ [alex] reported by reviewdog 🐶
obvious may be insensitive, try not to use it obvious retext-equality

obvious improvement or might be considered a personal preference. If a style


⚠️ [alex] reported by reviewdog 🐶
Be careful with remains, it’s profane in some cases remains retext-profanities

timely manner. If the PR remains inactive for 6 days, it will be marked as


⚠️ [alex] reported by reviewdog 🐶
master may be insensitive, use primary, lead, hub, reference instead master retext-equality

latest changes from master (but avoid rebasing in the middle of a code


⚠️ [alex] reported by reviewdog 🐶
master may be insensitive, use primary, lead, hub, reference instead master retext-equality

- Keep your PR up to date with upstream/master (if there are merge conflicts, we


⚠️ [alex] reported by reviewdog 🐶
Simply may be insensitive, try not to use it simple retext-equality

Simply add the following import to your code, and then `go [build|run|test]`


⚠️ [alex] reported by reviewdog 🐶
Be careful with failed, it’s profane in some cases failed retext-profanities

### The RPC failed with error `"code = Unavailable desc = transport is closing"`


⚠️ [alex] reported by reviewdog 🐶
Be careful with failed, it’s profane in some cases failed retext-profanities

1. mis-configured transport credentials, connection failed on handshaking


⚠️ [alex] reported by reviewdog 🐶
disabled may be insensitive, use turned off, has a disability, person with a disability, people with disabilities instead invalid retext-equality

functionality can be disabled by setting `jsonpatch.SupportNegativeIndices =


⚠️ [alex] reported by reviewdog 🐶
whitespace may be insensitive, use space, blank instead whitespace retext-equality

Due to potential whitespace and ordering differences, one cannot simply compare


⚠️ [alex] reported by reviewdog 🐶
simply may be insensitive, try not to use it simple retext-equality

Due to potential whitespace and ordering differences, one cannot simply compare


⚠️ [alex] reported by reviewdog 🐶
whitespace may be insensitive, use space, blank instead whitespace retext-equality

whitespace differences, and key-value ordering.


⚠️ [alex] reported by reviewdog 🐶
Be careful with remains, it’s profane in some cases remains retext-profanities

The package name remains simply lumberjack, and the code resides at


⚠️ [alex] reported by reviewdog 🐶
simply may be insensitive, try not to use it simple retext-equality

The package name remains simply lumberjack, and the code resides at


⚠️ [alex] reported by reviewdog 🐶
simply may be insensitive, try not to use it simple retext-equality

component at the bottom of the logging stack that simply controls the files


⚠️ [alex] reported by reviewdog 🐶
just may be insensitive, try not to use it just retext-equality

To use lumberjack with the standard library's log package, just pass it into the SetOutput function when your application starts.


⚠️ [alex] reported by reviewdog 🐶
clearly may be insensitive, try not to use it clearly retext-equality

actually never supported by this package as it's clearly a poor choice.


⚠️ [alex] reported by reviewdog 🐶
just may be insensitive, try not to use it just retext-equality

- [Kubernetes Contributor Guide](http://git.k8s.io/community/contributors/guide) - Main contributor documentation, or you can just jump directly to the [contributing section](http://git.k8s.io/community/contributors/guide#contributing)


⚠️ [alex] reported by reviewdog 🐶
easy may be insensitive, try not to use it easy retext-equality

* `glog` doesn't provide an easy way to test logs, which detracts from the stability of software using it


⚠️ [alex] reported by reviewdog 🐶
Be careful with execution, it’s profane in some cases execution retext-profanities


⚠️ [alex] reported by reviewdog 🐶
master may be insensitive, use primary, lead, hub, reference instead master retext-equality

used inside Google. The master copy of the source lives inside


⚠️ [alex] reported by reviewdog 🐶
master copy may be insensitive, use pass key, original instead master-key retext-equality

used inside Google. The master copy of the source lives inside


⚠️ [alex] reported by reviewdog 🐶
hosts may be insensitive, use presenters, entertainers, emcees instead hostesses-hosts retext-equality

This module hosts an experimental implementation of v2 `encoding/json`.


⚠️ [alex] reported by reviewdog 🐶
Easy may be insensitive, try not to use it easy retext-equality


⚠️ [alex] reported by reviewdog 🐶
easy may be insensitive, try not to use it easy retext-equality


⚠️ [alex] reported by reviewdog 🐶
simple may be insensitive, try not to use it simple retext-equality


⚠️ [alex] reported by reviewdog 🐶
simply may be insensitive, try not to use it simple retext-equality


⚠️ [alex] reported by reviewdog 🐶
just may be insensitive, try not to use it just retext-equality


⚠️ [alex] reported by reviewdog 🐶
primitive may be insensitive, use simple, indigenous, hunter-gatherer instead savage retext-equality

go.mongodb.org/mongo-driver/bson/primitive


⚠️ [alex] reported by reviewdog 🐶
Be careful with color, it’s profane in some cases color retext-profanities

go.uber.org/zap/internal/color


⚠️ [alex] reported by reviewdog 🐶
Be careful with japanese, it’s profane in some cases japanese retext-profanities

golang.org/x/text/encoding/japanese


⚠️ [alex] reported by reviewdog 🐶
easily may be insensitive, try not to use it easy retext-equality

generic events, adjust to skipped or coalesced events, and easily deal


⚠️ [alex] reported by reviewdog 🐶
easily may be insensitive, try not to use it easy retext-equality

working with Kubernetes APIs. This will allow you to more easily


⚠️ [alex] reported by reviewdog 🐶
just may be insensitive, try not to use it just retext-equality

to create a new branch you will just need to ensure that all big fixes are cherry-picked into the respective


⚠️ [alex] reported by reviewdog 🐶
master may be insensitive, use primary, lead, hub, reference instead master retext-equality

1. Create a new prow test under [github.com/kubernetes/test-infra/tree/master/config/jobs/kubernetes-sigs/controller-runtime](https://github.com/kubernetes/test-infra/tree/master/config/jobs/kubernetes-sigs/controller-runtime)


⚠️ [alex] reported by reviewdog 🐶
easy may be insensitive, try not to use it easy retext-equality


⚠️ [alex] reported by reviewdog 🐶
easily may be insensitive, try not to use it easy retext-equality

numbers tend to lose meaning easily over time, and you'll be left


⚠️ [alex] reported by reviewdog 🐶
special may be insensitive, use has a disability, person with a disability, people with disabilities instead special retext-equality

implementations to provide special handling of errors (for instance,


⚠️ [alex] reported by reviewdog 🐶
special may be insensitive, use has a disability, person with a disability, people with disabilities instead special retext-equality

a special encoder for Zap that will transform Kubernetes objects into


⚠️ [alex] reported by reviewdog 🐶
simply may be insensitive, try not to use it simple retext-equality

- When logging multiple things, simply pluralize the key.


⚠️ [alex] reported by reviewdog 🐶
just may be insensitive, try not to use it just retext-equality

- [Kubernetes Contributor Guide](https://git.k8s.io/community/contributors/guide) - Main contributor documentation, or you can just jump directly to the [contributing section](https://git.k8s.io/community/contributors/guide#contributing)


⚠️ [alex] reported by reviewdog 🐶
just may be insensitive, try not to use it just retext-equality

- [Kubernetes Contributor Guide](http://git.k8s.io/community/contributors/guide) - Main contributor documentation, or you can just jump directly to the [contributing section](http://git.k8s.io/community/contributors/guide#contributing)


⚠️ [alex] reported by reviewdog 🐶
just may be insensitive, try not to use it just retext-equality

**Caveat #1:** When using `yaml.Marshal` and `yaml.Unmarshal`, binary data should NOT be preceded with the `!!binary` YAML tag. If you do, go-yaml will convert the binary data from base64 to native binary data, which is not compatible with JSON. You can still use binary in your YAML files though - just store them without the `!!binary` tag and decode the base64 in your code (e.g. in the custom JSON methods `MarshalJSON` and `UnmarshalJSON`). This also has the benefit that your YAML and your JSON binary data will be decoded exactly the same way. As an example:


⚠️ [alex] reported by reviewdog 🐶
Be careful with reject, it’s profane in some cases reject retext-profanities

should be made in the upstream go-yaml library, and we will reject such changes in this fork

### Bugs Fixed

* `runtime.SetMultipartFormData` won't try to stringify `[]byte` values.
* Pollers that use the `Location` header won't consider `http.StatusTooManyRequests` a terminal failure.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [alex] reported by reviewdog 🐶
Be careful with failure, it’s profane in some cases failure retext-profanities


* Fixed an issue that could cause some allowed HTTP header values to not show up in logs.
* Include error text instead of error type in traces when the transport returns an error.
* Fixed an issue that could cause an HTTP/2 request to hang when the TCP connection becomes unresponsive.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [alex] reported by reviewdog 🐶
hang may be insensitive, use the app froze, the app stopped responding, the app stopped responding to events, the app became unresponsive instead hang retext-equality

* Add `Clone()` method for `arm/policy.ClientOptions`.

### Bugs Fixed
* ARM's RP registration policy will no longer swallow unrecognized errors.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [alex] reported by reviewdog 🐶
Reconsider using swallow, it may be profane swallow retext-profanities

### Bugs Fixed
* Fixed an issue in `runtime.SetMultipartFormData` to properly handle slices of `io.ReadSeekCloser`.
* Fixed the MaxRetryDelay default to be 60s.
* Failure to poll the state of an LRO will now return an `*azcore.ResponseError` for poller types that require this behavior.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [alex] reported by reviewdog 🐶
Be careful with Failure, it’s profane in some cases failure retext-profanities

* Fixed bug in `NullValue` that could lead to incorrect comparisons for empty maps/slices (#16969)

### Other Changes
* `BearerTokenPolicy` is more resilient to transient authentication failures. (#16789)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [alex] reported by reviewdog 🐶
Be careful with failures, it’s profane in some cases failures retext-profanities

for your target platform/shell). An alternative is to instruct your end
user to source a script from their `bash_profile` (or equivalent).

Fortunately Kingpin makes it easy to generate or source a script for use
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [alex] reported by reviewdog 🐶
easy may be insensitive, try not to use it easy retext-equality

#### Additional API
To provide more flexibility, a completion option API has been
exposed for flags to allow user defined completion options, to extend
completions further than just EnumVar/Enum.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [alex] reported by reviewdog 🐶
just may be insensitive, try not to use it just retext-equality

There are four included templates: `kingpin.DefaultUsageTemplate` is the default,
`kingpin.CompactUsageTemplate` provides a more compact representation for more complex command-line structures,
`kingpin.SeparateOptionalFlagsUsageTemplate` looks like the default template, but splits required
and optional command flags into separate lists, and `kingpin.ManPageTemplate` is used to generate man pages.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [alex] reported by reviewdog 🐶
man may be insensitive, use people, persons, folks instead gals-man retext-equality

In the effort to create such a place, we hold to these values:

1. **Discrimination limits us.** This includes discrimination on the basis of
race, gender, sexual orientation, gender identity, age, nationality,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [alex] reported by reviewdog 🐶
Reconsider using sexual, it may be profane sexual retext-profanities

technology and any other arbitrary exclusion of a group of people.
2. **Boundaries honor us.** Your comfort levels are not everyone’s comfort
levels. Remember that, and if brought to your attention, heed it.
3. **We are our biggest assets.** None of us were born masters of our trade.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [alex] reported by reviewdog 🐶
masters may be insensitive, use primaries, hubs, references instead masters retext-equality

@gkech
Copy link
Contributor Author

gkech commented Jan 31, 2025

closing this since we are not building using vendor, we should gitignore it

@gkech gkech closed this Jan 31, 2025
@gkech gkech deleted the run-go-mod-vendor branch January 31, 2025 09:27
@gkech
Copy link
Contributor Author

gkech commented Jan 31, 2025

#1817

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant