K8SPSMDB-297 support persistent logs #1936
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkech
force-pushed
the
K8SPSMDB-297
branch
6 times, most recently
from
c3e53e6 to
63f5e16
Compare
pull-request-size
bot
added
size/XXL
gkech
force-pushed
the
K8SPSMDB-297
branch
5 times, most recently
from
93f17f2 to
18f9557
Compare
pull-request-size
bot
added
size/XL
gkech
force-pushed
the
K8SPSMDB-297
branch
3 times, most recently
from
535245f to
d72b63f
Compare
pull-request-size
bot
added
size/XXL
gkech
requested review from
egegunes,
eleo007,
hors,
jvpasinatto and
pooknull
as code owners
egegunes
previously approved these changes
May 29, 2025
| _mongod_hack_rename_arg_save_val --sslDisabledProtocols --tlsDisabledProtocols "${mongodHackedArgs[@]}" | ||
| fi | ||
|
|
||
| if [[ $originalArgOne == "mongod" && ${LOGCOLLECTOR_ENABLED:-} == "true" ]]; then |
There was a problem hiding this comment.
nitpick but ${LOGCOLLECTOR_ENABLED:-} is the same with just ${LOGCOLLECTOR_ENABLED}. by default var is empty
There was a problem hiding this comment.
tried it without the default and it didn't work, needed ${LOGCOLLECTOR_ENABLED:-} 🤔
pooknull
reviewed
May 29, 2025
Comment on lines
1193
to
1202
| if !cr.IsLogCollectorEnabled() { | ||
| return nil | ||
| } | ||
|
|
||
| if cr.Spec.LogCollector.Configuration == "" { | ||
| if err := deleteConfigMapIfExists(ctx, r.client, cr, logcollector.ConfigMapName(cr.Name)); err != nil { | ||
| return errors.Wrap(err, "failed to delete log collector config map") | ||
| } | ||
| return nil | ||
| } |
There was a problem hiding this comment.
Should we delete configmap if log collector is disabled?
There was a problem hiding this comment.
good point, 57a014d
egegunes
previously approved these changes
May 30, 2025
…bled and the config map empty, delete the config map and continue the follow
egegunes
approved these changes
May 30, 2025
pooknull
approved these changes
May 30, 2025
|
preparing the helm chart pr as well |
commit: 723c4d4 |
This was referenced May 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGE DESCRIPTION
Problem:
Currently, logs are available only for the lifecycle of the particular pods. With this PR we are introducing the support for persistent logs, focusing for now only on the
mongodlogs.Cause:
Short explanation of the root cause of the issue if applicable.
Solution:
Image:
perconalab/percona-server-mongodb-operator:K8SPSMDB-297-58The solution utilises FluentBit to manage the log pipeline, appending the appropriate metadata and storing the logs in a single file in a log-specific PVC for each pod - directory
/data/db/logs/. The logs can also be visible on stdout through the-c logscontainer.As part of this pr, we moved the required configuration for fluentbit from here: https://github.com/percona/percona-docker/tree/main/fluentbit to this repo and we mount them to the
logsandlogrotationcontainers. The fluentbit configuration forfluentbitcan also be provided through the cr.yaml optionconfiguration.Demo:
In terms of documentation, the functionality is similar to this: https://docs.percona.com/percona-operator-for-mysql/pxc/debug-logs.html
Connected with: percona/percona-docker#1182
CHECKLIST
Jira
Needs Doc) and QA (Needs QA)?Tests
compare/*-oc.yml)?Config/Logging/Testability