Skip to content

Conversation

gkech
Copy link
Contributor

@gkech gkech commented May 22, 2025

K8SPSMDB-297 Powered by Pull Request Badge

CHANGE DESCRIPTION

Problem:
Utilize ClusterName as SoT for cluster name for backups.

Cause:
Short explanation of the root cause of the issue if applicable.

Solution:
Short explanation of the solution we are providing with this PR.

CHECKLIST

Jira

  • Is the Jira ticket created and referenced properly?
  • Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
  • Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

  • Is an E2E test/test case added for the new feature/change?
  • Are unit tests added where appropriate?
  • Are OpenShift compare files changed for E2E tests (compare/*-oc.yml)?

Config/Logging/Testability

  • Are all needed new/changed options added to default YAML files?
  • Are all needed new/changed options added to the Helm Chart?
  • Did we add proper logging messages for operator actions?
  • Did we ensure compatibility with the previous version or cluster upgrade process?
  • Does the change support oldest and newest supported MongoDB version?
  • Does the change support oldest and newest supported Kubernetes version?

@pull-request-size pull-request-size bot added the size/S 10-29 lines label May 22, 2025
@gkech gkech marked this pull request as ready for review May 22, 2025 09:57
@gkech gkech requested review from eleo007 and jvpasinatto as code owners May 22, 2025 10:00
egegunes
egegunes previously approved these changes May 22, 2025
@github-actions github-actions bot added the tests label May 22, 2025
Copy link
Collaborator

@hors hors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@egegunes @gkech from custom-replset-name test

20:19:14  -----------------------------------------------------------------------------------
20:19:14  run backup backup-minio
20:19:14  -----------------------------------------------------------------------------------
20:19:14  
20:19:15  Error from server (BadRequest): error when creating "STDIN": PerconaServerMongoDBBackup in version "v1" cannot be handled as a PerconaServerMongoDBBackup: strict decoding error: unknown field "spec.psmdbCluster"
20:19:15  error: no objects passed to apply
20:19:19  error: no objects passed to apply
20:19:27  error: no objects passed to apply

@gkech
Copy link
Contributor Author

gkech commented May 23, 2025

Thanks @hors, seems that the custom-replset-name test only used the legacy configuration. Addressed here: 3ab9b7a.

For me the test passed locally, but let's also wait for the jenkins results.

@gkech gkech requested review from egegunes and hors May 23, 2025 06:55
@hors
Copy link
Collaborator

hors commented May 23, 2025

Thanks @hors, seems that the custom-replset-name test only used the legacy configuration. Addressed here: 3ab9b7a.

For me the test passed locally, but let's also wait for the jenkins results.

I think we need to add to our RN that we removed psmdbCluster

@JNKPercona
Copy link
Collaborator

Test name Status
arbiter passed
balancer passed
cross-site-sharded passed
custom-replset-name passed
custom-tls passed
custom-users-roles passed
custom-users-roles-sharded passed
data-at-rest-encryption passed
data-sharded passed
demand-backup passed
demand-backup-eks-credentials-irsa passed
demand-backup-fs passed
demand-backup-incremental passed
demand-backup-incremental-sharded passed
demand-backup-physical passed
demand-backup-physical-sharded passed
demand-backup-sharded passed
expose-sharded passed
finalizer passed
ignore-labels-annotations passed
init-deploy passed
ldap passed
ldap-tls passed
limits passed
liveness passed
mongod-major-upgrade passed
mongod-major-upgrade-sharded passed
monitoring-2-0 passed
monitoring-pmm3 passed
multi-cluster-service passed
multi-storage passed
non-voting passed
one-pod passed
operator-self-healing-chaos passed
pitr passed
pitr-physical failure
pitr-sharded passed
pitr-physical-backup-source passed
preinit-updates passed
pvc-resize passed
recover-no-primary passed
replset-overrides passed
rs-shard-migration passed
scaling passed
scheduled-backup passed
security-context passed
self-healing-chaos passed
service-per-pod passed
serviceless-external-nodes passed
smart-update passed
split-horizon passed
stable-resource-version passed
storage passed
tls-issue-cert-manager passed
upgrade passed
upgrade-consistency passed
upgrade-consistency-sharded-tls passed
upgrade-sharded passed
users passed
version-service passed
We run 60 out of 60

commit: 3ab9b7a
image: perconalab/percona-server-mongodb-operator:PR-1941-3ab9b7ac

@hors hors merged commit a2cf493 into main May 23, 2025
18 of 19 checks passed
@hors hors deleted the K8SPSMDB-297-remove-cluster-from-backup branch May 23, 2025 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/S 10-29 lines tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants