K8SPSMDB-1572: Add revisionHistoryLimit option to PerconaServerMongoDB CRD#2219
Open
myJamong wants to merge 5 commits intopercona:mainfrom
Open
K8SPSMDB-1572: Add revisionHistoryLimit option to PerconaServerMongoDB CRD#2219myJamong wants to merge 5 commits intopercona:mainfrom
myJamong wants to merge 5 commits intopercona:mainfrom
Conversation
myJamong
requested review from
bogdanjeler-ev,
egegunes,
eleo007,
gkech,
hors,
jvpasinatto,
mayankshah1607,
nmarukovich,
oksana-grishchenko,
pooknull and
valmiranogueira
as code owners
|
|
egegunes
changed the title
egegunes
requested changes
Feb 3, 2026
deploy/bundle.yaml
Outdated
| @@ -1,3 +1,4 @@ | |||
| # Warning: 'patchesStrategicMerge' is deprecated. Please use 'patches' instead. Run 'kustomize edit fix' to update your Kustomization automatically. | |||
Contributor
There was a problem hiding this comment.
not sure if we should have this warning in CRD
pkg/psmdb/mongos.go
Outdated
| UpdateStrategy: updateStrategy, | ||
| Template: template, | ||
| UpdateStrategy: updateStrategy, | ||
| RevisionHistoryLimit: cr.Spec.RevisionHistoryLimit, |
Contributor
There was a problem hiding this comment.
we need to add this field with version check to prevent unexpected restarts after operator upgrade. you can check cr.CompareVersion for examples. this will go into v1.23, so we need to check for "1.23.0"
Author
There was a problem hiding this comment.
I added some changes and added a cr.CompareVersion logic to check for 1.23.0.
Thanks for your guide.
commit: b910275
pkg/psmdb/statefulset.go
Outdated
| }, | ||
| }, | ||
| UpdateStrategy: updateStrategy, | ||
| RevisionHistoryLimit: cr.Spec.RevisionHistoryLimit, |
Contributor
There was a problem hiding this comment.
we need cr version check here as well
egegunes
approved these changes
Feb 4, 2026
Author
|
Hi @egegunes |
Contributor
|
@myJamong no, they are not related to your changes. |
This allows users to control the number of ControllerRevision objects retained for StatefulSets managed by the operator. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
myJamong
force-pushed
the
add-revisionhistorylimit
branch
from
2808255 to
6edbacf
Compare
Author
|
My previous commits were authored with my company email by mistake, so I wasn't able to sign the CLA. I've updated the commit author to my personal GitHub account(myJamong) and force-pushed. The CLA should be resolved now. |
nmarukovich
approved these changes
Mar 9, 2026
Collaborator
commit: d7e802d |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to the high volume of requests, we're unable to provide free service for this account. To continue using the service, please upgarde to a paid plan.
This allows users to control the number of ControllerRevision objects retained for StatefulSets managed by the operator.
CHANGE DESCRIPTION
Problem:
When StatefulSets are updated, Kubernetes creates ControllerRevision objects to track revision history. Without a limit, these objects accumulate indefinitely, cluttering the cluster
and making it harder to manage resources.
Cause:
The operator does not expose the
revisionHistoryLimitfield from StatefulSet spec, so users cannot control how many ControllerRevision objects are retained.Solution:
Add
revisionHistoryLimitoption to PerconaServerMongoDB CRD spec. This value is propagated to all StatefulSets (replsets and mongos) managed by the operator, allowing users to limitthe number of retained ControllerRevision objects.
CHECKLIST
Jira
Needs Doc) and QA (Needs QA)?Tests
compare/*-oc.yml)?Config/Logging/Testability