Skip to content

K8SPS-362: Fix version service #679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

Conversation

pooknull
Copy link
Contributor

@pooknull pooknull commented Jun 24, 2024

https://perconadev.atlassian.net/browse/K8SPS-362

DESCRIPTION

Problem:
The version-service test sometimes fails at the first step because statefulsets are updated with new images obtained from the version service immediately after they are created. We expect the statefulset to already have the new images without the need for an update.

Cause:
When the patch operation in the (*PerconaServerMySQLReconciler) reconcileVersions method fails, the operator continues to create the statefulsets with old images.

Solution:
We should replace the patch operation with an update. It gives more chances that the cluster will be updated with new images before creating statefulsets.

CHECKLIST

Jira

  • Is the Jira ticket created and referenced properly?
  • Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
  • Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

  • Is an E2E test/test case added for the new feature/change?
  • Are unit tests added where appropriate?

Config/Logging/Testability

  • Are all needed new/changed options added to default YAML files?
  • Did we add proper logging messages for operator actions?
  • Did we ensure compatibility with the previous version or cluster upgrade process?
  • Does the change support oldest and newest supported PS version?
  • Does the change support oldest and newest supported Kubernetes version?

@pull-request-size pull-request-size bot added the size/L 100-499 lines label Jun 24, 2024
@pooknull pooknull marked this pull request as ready for review June 25, 2024 07:19
@pooknull pooknull changed the title Fix version service K8SPS-362: Fix version service Jun 25, 2024
@JNKPercona
Copy link
Collaborator

Test name Status
async-ignore-annotations passed
auto-config passed
config passed
config-router passed
demand-backup passed
gr-demand-backup passed
gr-demand-backup-haproxy passed
gr-finalizer passed
gr-haproxy passed
gr-ignore-annotations passed
gr-init-deploy passed
gr-one-pod passed
gr-recreate passed
gr-scaling passed
gr-security-context passed
gr-self-healing passed
gr-tls-cert-manager passed
gr-users passed
haproxy passed
init-deploy passed
limits passed
monitoring passed
one-pod passed
operator-self-healing passed
recreate passed
scaling passed
service-per-pod passed
sidecars passed
smart-update passed
tls-cert-manager passed
users passed
version-service failure
We run 32 out of 32

commit: c209ca9
image: perconalab/percona-server-mysql-operator:PR-679-c209ca9c

@hors hors closed this Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L 100-499 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants