-
Notifications
You must be signed in to change notification settings - Fork 30
K8SPS-241: Set OPERATOR_NS in default Jenkins pipeline #680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egegunes
requested changes
Jul 1, 2024
egegunes
previously approved these changes
Jul 1, 2024
hors
approved these changes
Jul 1, 2024
commit: 086a2f3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGE DESCRIPTION
Problem:
Set OPERATOR_NS in the default Jenkins pipeline.
Note
percona-server-mysql-orchestrator
service account is created by the operator instead of with applying bundle.yaml. Because of this, the operator needs permissions for managing serviceaccounts, roles and roleBindings. We added those with additionalkubebuilder
annotations to the PS controller.kubectl assert
, just like the operator deployment, since it is deployed inps-operator
namespace.remove-cluster-gracefully
step to all of the tests (and renameddrup-finalizer
step) - this is the bulk of the PR.CHECKLIST
Jira
Needs Doc
) and QA (Needs QA
)?Tests
Config/Logging/Testability