Skip to content

K8SPS-365: Fix crashes after MySQL version upgrade #708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 31, 2024
Merged

K8SPS-365: Fix crashes after MySQL version upgrade #708

merged 2 commits into from
Jul 31, 2024

Conversation

egegunes
Copy link
Contributor

@egegunes egegunes commented Jul 25, 2024

K8SPS-365 Powered by Pull Request Badge

CHANGE DESCRIPTION

Problem:
For some reason we were restarting MySQL container after adding the pod to the cluster. This results with crash loop in case of MySQL version upgrade.

Solution:
This restart seems unnecessary, so I removed it.

CHECKLIST

Jira

  • Is the Jira ticket created and referenced properly?
  • Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
  • Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

  • Is an E2E test/test case added for the new feature/change?
  • Are unit tests added where appropriate?

Config/Logging/Testability

  • Are all needed new/changed options added to default YAML files?
  • Did we add proper logging messages for operator actions?
  • Did we ensure compatibility with the previous version or cluster upgrade process?
  • Does the change support oldest and newest supported PS version?
  • Does the change support oldest and newest supported Kubernetes version?

@pull-request-size pull-request-size bot added the size/M 30-99 lines label Jul 25, 2024
@egegunes egegunes marked this pull request as ready for review July 30, 2024 06:40
@@ -68,8 +68,8 @@ func lookup(svcName string) (sets.Set[string], error) {
return endpoints, nil
}

func lockExists() (bool, error) {
return fileExists("/var/lib/mysql/bootstrap.lock")
func lockExists(lockName string) (bool, error) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we only have bootstrap lock, do we need this lockName param at all?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was adding locks during development and I think this is more clear, I intend to keep it

@hors hors requested a review from inelpandzic July 30, 2024 11:59
@JNKPercona
Copy link
Collaborator

Test name Status
async-ignore-annotations passed
auto-config passed
config passed
config-router passed
demand-backup passed
gr-demand-backup passed
gr-demand-backup-haproxy passed
gr-finalizer passed
gr-haproxy passed
gr-ignore-annotations passed
gr-init-deploy passed
gr-one-pod passed
gr-recreate passed
gr-scaling passed
gr-security-context passed
gr-self-healing passed
gr-tls-cert-manager passed
gr-users passed
haproxy passed
init-deploy passed
limits passed
monitoring passed
one-pod passed
operator-self-healing passed
recreate passed
scaling passed
service-per-pod passed
sidecars passed
smart-update passed
tls-cert-manager passed
users passed
version-service passed
We run 32 out of 32

commit: 8ac99b6
image: perconalab/percona-server-mysql-operator:PR-708-8ac99b60

@hors hors merged commit 8838f29 into main Jul 31, 2024
16 checks passed
@hors hors deleted the K8SPS-365 branch July 31, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M 30-99 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants