Skip to content

K8SPS-360: Orc downscale outdated services #714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 1, 2024

Conversation

inelpandzic
Copy link
Contributor

@inelpandzic inelpandzic commented Jul 31, 2024

K8SPS-360 Powered by Pull Request Badge

CHANGE DESCRIPTION

Problem:
When the orchestrator is downscaled, outdated orc services are not removed.

Solution:
When the orchestrator is downscaled, remove all the dangling services.

If we have orc with size of 3, we have:

cluster1-orc-0           ClusterIP   10.114.157.220   <none>        3000/TCP,10008/TCP                               5m41s
cluster1-orc-1           ClusterIP   10.114.157.40    <none>        3000/TCP,10008/TCP                               5m41s
cluster1-orc-2           ClusterIP   10.114.151.242   <none>        3000/TCP,10008/TCP                               5m41s

and we scale orc to 1, we need to remove cluster1-orc-1 and cluster1-orc-2 services.

CHECKLIST

Jira

  • Is the Jira ticket created and referenced properly?
  • Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
  • Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

  • Is an E2E test/test case added for the new feature/change?
  • Are unit tests added where appropriate?

Config/Logging/Testability

  • Are all needed new/changed options added to default YAML files?
  • Did we add proper logging messages for operator actions?
  • Did we ensure compatibility with the previous version or cluster upgrade process?
  • Does the change support oldest and newest supported PS version?
  • Does the change support oldest and newest supported Kubernetes version?

@pull-request-size pull-request-size bot added the size/M 30-99 lines label Jul 31, 2024
@JNKPercona
Copy link
Collaborator

Test name Status
version-service passed
async-ignore-annotations passed
auto-config passed
config passed
config-router passed
demand-backup passed
gr-demand-backup passed
gr-demand-backup-haproxy passed
gr-finalizer passed
gr-haproxy passed
gr-ignore-annotations passed
gr-init-deploy passed
gr-one-pod passed
gr-recreate passed
gr-scaling passed
gr-security-context passed
gr-self-healing passed
gr-tls-cert-manager passed
gr-users passed
haproxy passed
init-deploy passed
limits passed
monitoring passed
one-pod passed
operator-self-healing passed
recreate passed
scaling passed
service-per-pod passed
sidecars passed
smart-update passed
tls-cert-manager passed
users passed
We run 32 out of 32

commit: 02d9cdc
image: perconalab/percona-server-mysql-operator:PR-714-02d9cdc6

@hors hors merged commit e399329 into main Aug 1, 2024
16 checks passed
@hors hors deleted the K8SPS-360-orc-downscale-cleanup branch August 1, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M 30-99 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants