PS-9452 [8.4] fix unprivileged user login when threadpool is full#5616
Merged
lukin-oleksiy merged 1 commit intopercona:8.4from Sep 24, 2025
Merged
Conversation
lukin-oleksiy
force-pushed
the
PS-9452-8.4-fix-login-when-threadpool-full
branch
from
914c856 to
dbd061a
Compare
lukin-oleksiy
changed the title
lukin-oleksiy
force-pushed
the
PS-9452-8.4-fix-login-when-threadpool-full
branch
from
dbd061a to
9194d48
Compare
lukin-oleksiy
force-pushed
the
PS-9452-8.4-fix-login-when-threadpool-full
branch
from
9194d48 to
1de68c9
Compare
percona-ysorokin
requested changes
Sep 23, 2025
sql/threadpool_unix.cc
Outdated
| c.thd->mdl_context.has_locks() || | ||
| c.thd->global_read_lock.is_acquired() || | ||
| c.thd->backup_tables_lock.is_acquired() || | ||
| c.thd->is_admin_connection() || // Admin connection is high prio |
Collaborator
There was a problem hiding this comment.
This part hasn't been updated as in 8.0
https://perconadev.atlassian.net/browse/PS-9452 The solution is to make connections to the admin port a high priority connection unconditionally. So, when the thread pool is exhausted, a user with the SERVICE_CONNECTION_ADMIN privilege can login through admin port and execute KILL commands
lukin-oleksiy
force-pushed
the
PS-9452-8.4-fix-login-when-threadpool-full
branch
from
1de68c9 to
42aaea0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.