PS-9760 Adds clang-tidy checks to CircleCI #5627
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
An example run with debug info can be seen here https://circleci.com/gh/percona/percona-server/8821 |
inikep
reviewed
Jun 9, 2025
VarunNagaraju
force-pushed
the
PS-9760-8.0-GCA
branch
from
9fed4d1 to
198b35b
Compare
VarunNagaraju
force-pushed
the
PS-9760-8.0-GCA
branch
from
198b35b to
dc008c1
Compare
percona-ysorokin
approved these changes
Jun 16, 2025
VarunNagaraju
force-pushed
the
PS-9760-8.0-GCA
branch
from
dc008c1 to
6720c3c
Compare
https://perconadev.atlassian.net/browse/PS-9760 Along with clang-format checks, CircleCI is now equipped with clang-tidy checks as well, which perform static code analysis on the files modified by a particular PR. Similar to clang-format checks, the console log of the CircleCI contains the output from the clang-tidy checks, which has 2 parts: 1. The clang-tidy warnings, considering the corresponding C++ standard, C++ standard library, and respective header files using the generated compile_commands.json file. 2. The clang-tidy suggestions, using same information from above, applied as a diff on the modified files. This helps visualise the recommended changes to improve the code.
VarunNagaraju
force-pushed
the
PS-9760-8.0-GCA
branch
from
6720c3c to
2736ac1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://perconadev.atlassian.net/browse/PS-9760
Along with clang-format checks, CircleCI is now equipped with clang-tidy checks as well, which perform static code analysis on the files modified by a particular PR.
Similar to clang-format checks, the console log of the CircleCI contains the output from the clang-tidy checks, which has 2 parts: