Skip to content

Run sanitizers against PostgreSQL 18 instead of 17#445

Merged
jeltz merged 1 commit intopercona:mainfrom
jeltz:sanitizers-pg18
Nov 14, 2025
Merged

Run sanitizers against PostgreSQL 18 instead of 17#445
jeltz merged 1 commit intopercona:mainfrom
jeltz:sanitizers-pg18

Conversation

@jeltz
Copy link
Collaborator

@jeltz jeltz commented Oct 28, 2025

Maybe we want to do a full matrix but for now let's at least run against the latest PostgreSQL version.

@jeltz jeltz requested a review from artemgavrilov as a code owner October 28, 2025 20:19
@codecov-commenter
Copy link

codecov-commenter commented Oct 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.66%. Comparing base (bf683f7) to head (6dd4b56).

❌ Your project status has failed because the head coverage (59.66%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #445   +/-   ##
=======================================
  Coverage   59.66%   59.66%           
=======================================
  Files          67       67           
  Lines       10481    10481           
  Branches     1809     1809           
=======================================
  Hits         6254     6254           
  Misses       3532     3532           
  Partials      695      695           
Components Coverage Δ
access 84.89% <ø> (ø)
catalog 87.93% <ø> (ø)
common 77.77% <ø> (ø)
encryption 71.56% <ø> (ø)
keyring 73.54% <ø> (ø)
src 94.20% <ø> (ø)
smgr 94.06% <ø> (ø)
transam ∅ <ø> (∅)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jeltz jeltz marked this pull request as draft October 31, 2025 02:10
artemgavrilov
artemgavrilov previously approved these changes Nov 4, 2025
@artemgavrilov
Copy link
Collaborator

Oh, sanitizers workflow failed

@artemgavrilov artemgavrilov self-requested a review November 4, 2025 12:51
@jeltz
Copy link
Collaborator Author

jeltz commented Nov 4, 2025

Yeah, the reason this is a draft is because I wanted to run the sanitizers and see what failed. Not sure if I will continue this work right now so @artemgavrilov if you want to continue this work feel free to do so.

dAdAbird pushed a commit to dAdAbird/pg_tde that referenced this pull request Nov 5, 2025
setup.md:

Modified file to be postgresql.conf file
Modified last note to be clearer.

test.md:
UPdated function return for step 2 checking encrypted data

variables.md:

Added warning note for Enabling WAL encryption.

yum.md:

Updated Memory Lock description.
@jeltz jeltz force-pushed the sanitizers-pg18 branch 8 times, most recently from f410a9f to c8ec77a Compare November 14, 2025 09:46
Maybe we want to do a full matrix but for now let's at least run against
the latest PostgreSQL version.
@jeltz jeltz marked this pull request as ready for review November 14, 2025 10:43
@jeltz
Copy link
Collaborator Author

jeltz commented Nov 14, 2025

@artemgavrilov I have now fixed this PR.

@jeltz jeltz dismissed artemgavrilov’s stale review November 14, 2025 14:45

It was reviewed before the PR was completed. :)

@jeltz jeltz merged commit bfff728 into percona:main Nov 14, 2025
17 checks passed
@jeltz jeltz deleted the sanitizers-pg18 branch November 14, 2025 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants