Skip to content

PG-1437 Clean up frontend and backend sources in meson.build #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 14, 2025

Conversation

jeltz
Copy link
Collaborator

@jeltz jeltz commented Apr 1, 2025

There is no reason why we cannot just concatenate the two lists. And while at it we also sort and reindent the lists.

While the frontend sources right now are a strict subset of the backend
sources that might not always be the case so keep them as separate lists
but clean them up. In the long term we want to refactor this entirely
anyway so let's not overcomplicate this.

@jeltz jeltz requested review from dutow and dAdAbird as code owners April 1, 2025 22:16
Copy link
Collaborator

@AndersAstrand AndersAstrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might have missed some previous discussion, but are we sure that adding an assumption that the frontend code is a subset of the extension code is what we want to do?

I'm thinking it might compound the possible confusion by #ifdef FRONTEND sprinkled throughout the code rather than help.

The old naming leads me to believe the list of files for "decrypt" arent necessarily frontend files but files used by both the extension and the frontend?

So I'd suggest either separate lists of files for frontend and extension, or if we want to group the files needed for decryption separately have both the frontend and extension file list concatenate it.

@jeltz
Copy link
Collaborator Author

jeltz commented Apr 4, 2025

Good point, need to think about it. But calling them decrypt isn't entirely accurate either because those files are for the following:

  • Reading and writing to the keyring file
  • Reading the key file (require connecting to key server)
  • Reading encrypted WAL (requires connecting to key server)

But it does not include for example:

  • Reading encrypted relations

@jeltz jeltz force-pushed the tde/dup-meson-sources branch 2 times, most recently from e0ba6b9 to 6f50f87 Compare April 10, 2025 23:48
jeltz added 3 commits April 11, 2025 13:15
While the frontend sources right now are a strict subset of the backend
sources that might not always be the case so keep them as separate lists
but clean them up. In the long term we want to refactor this entirely
anyway so let's not overcomplicate this.
@jeltz jeltz force-pushed the tde/dup-meson-sources branch from 6f50f87 to a5c925e Compare April 11, 2025 11:16
@jeltz jeltz changed the title PG-1437 Do not duplicate frontend sources in meson.build PG-1437 Clean up frontend and backend sources in meson.build Apr 11, 2025
@jeltz
Copy link
Collaborator Author

jeltz commented Apr 11, 2025

Kept them as separate.

@jeltz jeltz requested a review from AndersAstrand April 11, 2025 11:19
@jeltz jeltz merged commit 93ef451 into percona:TDE_REL_17_STABLE Apr 14, 2025
14 checks passed
@jeltz jeltz deleted the tde/dup-meson-sources branch April 16, 2025 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants