Modernize our way to call ereport()#200
Merged
jeltz merged 1 commit intopercona:TDE_REL_17_STABLEfrom Apr 10, 2025
Merged
Conversation
jeltz
force-pushed
the
tde/modern-ereport
branch
from
912401d to
77a7f22
Compare
dutow
approved these changes
Apr 10, 2025
jeltz
force-pushed
the
tde/modern-ereport
branch
from
77a7f22 to
11ba4b3
Compare
Commit e3a87b4 added a way to call ereport() without any extra parentheses which was backported all the way back to PostgreSQL 12. The new modern way improves code readability slightly.
jeltz
force-pushed
the
tde/modern-ereport
branch
from
11ba4b3 to
1475ca0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had forgot about this until Anders pointed it out.
Commit e3a87b4 added a way to call
ereport()without any extra parentheses which was backported all the way back to PostgreSQL 12. The new modern way improves code readability slightly.