Made some improvements to the syncusers function #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… different passwords in handled in the syncusers function. Previously an error would be thrown, now it will handle this occurance by only creating the first user record found and printing a warning.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It will now better handle instances of the same username with different passwords found in XtraDB. Now displaying users as they are being created, otherwise it seemed like nothing happened without logging into ProxySQL to verify. Also moved the completion and how to connect message to the very end as it can go off the screen if --syncusers was used during setup and a lot of users needed to be created. And unrelated, replaced some tabs with spaces, trying to stick to the established format.