Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow DB Instance to be edited #661

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Allow DB Instance to be edited #661

merged 1 commit into from
Oct 1, 2024

Conversation

Russsnizza
Copy link
Contributor

@Russsnizza Russsnizza commented Sep 19, 2024 •
edited by harjain99
Loading

Fixes: #668

Description

This pull request adds the @Updatable annotation to the getPubliclyAccessible method. This update will allow the publiclyAccessible property to be updated after the initial object creation.

Changes

  • Added @Updatable annotation to the getPubliclyAccessible method.

@Russsnizza Russsnizza changed the title Add @Updatable annotation to getPubliclyAccessible INFRA:625: Allow DB Instance to be edited Sep 19, 2024
@Russsnizza Russsnizza marked this pull request as ready for review September 19, 2024 16:31
@harjain99 harjain99 changed the title INFRA:625: Allow DB Instance to be edited Allow DB Instance to be edited Sep 25, 2024
@harjain99
Copy link
Contributor

The change looks good, but I believe the Issue also mentions an updatable field in dbCluster. Can we verify if that is indeed editable?

@Russsnizza
Copy link
Contributor Author

The change looks good, but I believe the Issue also mentions an updatable field in dbCluster. Can we verify if that is indeed editable?

Sorted AZs should fix when DB cluster is not updated I think. I am not sure if we should enable updating getEngineVersion. It looks like we can update it in the console, but it didn't work with gyro up for me yet.

@Russsnizza
Copy link
Contributor Author

Russsnizza commented Sep 26, 2024 •
edited
Loading

Also, I don't think we can just update the DB-instance engine in the console .

Screen Shot 2024-09-26 at 14 48 44 PM

@harjain99 harjain99 merged commit 0bd2a76 into master Oct 1, 2024
1 check passed
@harjain99 harjain99 deleted the bugfix/allow-db-instance-to-be-edited branch October 1, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harjain99 harjain99 harjain99 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow DB Instance to be edited
2 participants
@Russsnizza @harjain99