The db-cluster-parameter-group does not refresh parameters #665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add string array workaround for marker in AWS RDS API call
harjain99
requested changes
Sep 25, 2024
Comment on lines
155
to
159
| String[] marker = {null}; | ||
| do { | ||
| DescribeDbClusterParametersResponse parametersResponse = client.describeDBClusterParameters( | ||
| r -> r.dbClusterParameterGroupName(getName()).marker(marker[0]) | ||
| ); |
There was a problem hiding this comment.
The marker should be a String, it doesn't need to be an array.
The sdk has non-lamba builders that can get you past the issue of not being able to update a String value within a lambda
Suggested change
| String[] marker = {null}; | |
| do { | |
| DescribeDbClusterParametersResponse parametersResponse = client.describeDBClusterParameters( | |
| r -> r.dbClusterParameterGroupName(getName()).marker(marker[0]) | |
| ); | |
| String marker = {null}; | |
| do { | |
| DescribeDbClusterParametersResponse parametersResponse = client.describeDBClusterParameters( DescribeDbClusterParametersRequest.builder().dbClusterParameterGroupName(getName()).marker(marker).build()); |
Russsnizza
changed the title
harjain99
approved these changes
Oct 1, 2024
harjain99
deleted the
bugfix/db-cluster-parameter-group-does-not-refresh-parameters
branch
harjain99
restored the
bugfix/db-cluster-parameter-group-does-not-refresh-parameters
branch
harjain99
deleted the
bugfix/db-cluster-parameter-group-does-not-refresh-parameters
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #672
Description
This pull request addresses the need to retrieve DB cluster parameters in a paginated manner within the doRefresh() method of the DbClusterParameterGroupResource class.
Changes
Paginated retrieval in doRefresh() method.
Use of an Array String to override lambda's final constraint.