Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert db subnet group subnets into list #666

Merged
merged 3 commits into from
Oct 1, 2024

Conversation

Russsnizza
Copy link
Contributor

@Russsnizza Russsnizza commented Sep 24, 2024

Fixes: #673

Description

This PR refactors the DBSubnetGroupResource class. The setSubnets() and getSubnets() methods now work with a List instead of a Set. All references to these methods have been updated accordingly.

Copy link
Contributor

@harjain99 harjain99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor requested change. the rest looks good

@@ -167,4 +173,4 @@ public void delete(GyroUI ui, State state) {
r -> r.dbSubnetGroupName(getName())
);
}
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add newline at the EOF

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New line added.

@harjain99 harjain99 changed the title INFRA-623: Convert db subnet group subnets into list Convert db subnet group subnets into list Sep 25, 2024
@harjain99 harjain99 merged commit edacdc6 into master Oct 1, 2024
1 check passed
@harjain99 harjain99 deleted the bugfix/convert-db-subnet-group-subnets-into-list branch October 1, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert db-subnet-group subnets into a list
2 participants