checklist: replace the storage metrics disk.dm.* with disk.dev.* …

…(enables usage without device mapper)
performancecopilot · Jan 22, 2021 · e16fce3 · e16fce3
1 parent acc1d13
commit e16fce3
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 14 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,7 @@
 
 ## 3.0.2 (unreleased)
 
+- **checklist**: replace the storage metrics `disk.dm.*` with `disk.dev.*` (enables usage without device mapper)
 
 ## 3.0.1 (2020-12-22)
 

diff --git a/src/dashboards/vector/checklist/pcp-vector-checklist-storage.jsonnet b/src/dashboards/vector/checklist/pcp-vector-checklist-storage.jsonnet
@@ -12,7 +12,7 @@ checklist.dashboard.new(node)
     title='IOPS',
     datasource='$datasource',
     threshold=notifyGraph.threshold.new(
-      metric='disk.dm.total',
+      metric='disk.dev.total',
       operator='>',
       value=2500,
     ),
@@ -21,15 +21,15 @@ checklist.dashboard.new(node)
       warning='Overly high data saturation rate.',
       metrics=[
         notifyGraph.metric.new(
-          'disk.dm.total',
-          'per-device-mapper device total (read+write) operations',
+          'disk.dev.total',
+          'per-disk total (read+write) operations',
         ),
       ],
       details='There are maximum rates that data can be read from and written to a storage device which can present a bottleneck on performance',
       parents=parents,
     ),
   ).addTargets([
-    { expr: 'disk.dm.total', format: 'time_series', legendFormat: '$instance' },
+    { expr: 'disk.dev.total', format: 'time_series', legendFormat: '$instance' },
   ]), gridPos={
     x: 0,
     y: 3,
@@ -42,7 +42,7 @@ checklist.dashboard.new(node)
     title='Average block size [KiB]',
     datasource='$datasource',
     threshold=notifyGraph.threshold.new(
-      metric='disk.dm.avgsz',
+      metric='disk.dev.avgsz',
       operator='<',
       value=0.5,
     ),
@@ -51,20 +51,20 @@ checklist.dashboard.new(node)
       warning='Excessively small sized operations for storage.',
       metrics=[
         notifyGraph.metric.new(
-          'disk.dm.total_bytes',
-          'per-device-mapper device count of total bytes read and written'
+          'disk.dev.total_bytes',
+          'per-disk count of total bytes read and written'
         ),
         notifyGraph.metric.new(
-          'disk.dm.total',
-          'per-device-mapper device total (read+write) operations',
+          'disk.dev.total',
+          'per-disk total (read+write) operations',
         ),
       ],
-      derived=['disk.dm.avgsz = delta(disk.dm.total_bytes) / delta(disk.dm.total)'],
+      derived=['disk.dev.avgsz = delta(disk.dev.total_bytes) / delta(disk.dev.total)'],
       details='Operations on storage devices provide higher bandwidth with larger operations.  For rotational media the cost of seek operation to access different data on device is much higher that the cost of streaming the same amount of data from single continous region.',
       parents=parents,
     ),
   ).addTargets([
-    { name: 'disk.dm.avgsz', expr: 'delta(disk.dm.total_bytes) / delta(disk.dm.total)', format: 'time_series', legendFormat: '$instance' },
+    { name: 'disk.dev.avgsz', expr: 'delta(disk.dev.total_bytes) / delta(disk.dev.total)', format: 'time_series', legendFormat: '$instance' },
   ]), gridPos={
     x: 12,
     y: 3,

diff --git a/src/dashboards/vector/checklist/pcp-vector-checklist.jsonnet b/src/dashboards/vector/checklist/pcp-vector-checklist.jsonnet
@@ -43,7 +43,7 @@ checklist.dashboard.new(node)
     title='Storage Utilization [%]',
     datasource='$datasource',
     threshold=notifyGraph.threshold.new(
-      metric='disk.dm.avactive',
+      metric='disk.dev.avactive',
       operator='>',
       value=0.85,
     ),
@@ -52,7 +52,7 @@ checklist.dashboard.new(node)
       warning='Excessive waiting for storage.',
       metrics=[
         notifyGraph.metric.new(
-          'disk.dm.avactive', 'per-device-mapper device count of active time'
+          'disk.dev.avactive', 'per-disk count of active time'
         )
       ],
       urls=['https://access.redhat.com/documentation/en-US/Red_Hat_Enterprise_Linux/7/html-single/Performance_Tuning_Guide/index.html#chap-Red_Hat_Enterprise_Linux-Performance_Tuning_Guide-Storage_and_File_Systems'],
@@ -61,7 +61,7 @@ checklist.dashboard.new(node)
       children=[checklist.getNodeByUid('pcp-vector-checklist-storage')],
     ),
   ).addTargets([
-    { expr: 'disk.dm.avactive', format: 'time_series', legendFormat: '$instance' },
+    { expr: 'disk.dev.avactive', format: 'time_series', legendFormat: '$instance' },
   ]), gridPos={
     x: 12,
     y: 3,