Do not call mariadb_db_reconnect() during changing $dbh attributes unless needed #212
+42
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
choroba
added
review needed
…en not needed
Currently mariadb_db_STORE_attrib() function (handler for changing dbh
attributes via $dbh->{...} = ... syntax) at its beginning calls function
mariadb_db_reconnect() to ensure that imp_dbh->pmysql connection structure
is initialized.
Change logic of mariadb_db_STORE_attrib() function to call function
mariadb_db_reconnect() only when the changing of attribute really requires
active connection.
This change fixes a problem that Perl for locatized variables is trying to
restore its original value after leaving the scope, and this is failing for
restoring the DBI attributes.
Trying to change common DBI attributes (those which first letter is upper
case) except the AutoConnect, is not handled by DBD::MariaDB driver, and
therefore DBD::MariaDB driver does not have to check if the connection is
still active.
Add test case that custom HandleError and also localized custom HandleError does not trigger any error after disconnect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #211.