Avoid copies if it is possible to undo a move #50
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For states with complex objects, copies can take a significant bulk of the time spent by the algorithm. This pull requests add optional support for defining
def undo_move(self)
method on the class, which the user can implement to undo the last move, almost avoiding the copying in the body of the annealing.For demonstration purposes consider the following (admittedly convoluted) example:
On my pc, this code runs approximately 20x slower when I comment out
undo_move
(3 minutes vs 10 seconds).