feat: add helm chart #161
Draft
feat: add helm chart #161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dougkirkley
reviewed
May 30, 2025
heliapb
force-pushed
the
feat/helm_chart
branch
2 times, most recently
from
4f1ac25 to
5921f90
Compare
|
This issue could be a good way to test the full helm chart and installing custom resources as well, in a separate PR |
Signed-off-by: Hélia Barroso <[email protected]>
|
@heliapb Do you think your could load the current perses-operator docker image into kind and use that to test this scenario? |
ibakshay
reviewed
Jun 10, 2025
| ##@ Helm | ||
| .PHONY: helm-chart | ||
| helm-chart: manifests | ||
| kubebuilder edit --plugins=helm/v1-alpha |
There was a problem hiding this comment.
It will be great if the kubebuilder binary can be installed locally instead of installing it globally by the end-user in advance. Please see how it is done for [jsonnet_binary here](https://github.com/perses/perses-operator/blob/main/Makefile#L316-L320.
|
|
||
| - name: Check Helm release | ||
| run: | | ||
| helm status perses-operator --namespace perses-operator-system |
There was a problem hiding this comment.
We also need to have a workflow to release this helm chart. Same like this one
| type: application | ||
| version: 0.1.0 | ||
| appVersion: "0.1.0" | ||
| icon: "https://example.com/icon.png" |
There was a problem hiding this comment.
Suggested change
| icon: "https://example.com/icon.png" | |
| icon: "https://github.com/perses/perses/blob/main/docs/images/perses_logo_lt.png" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From issue #79
Add helm chart using kubebuilder helm plugin