Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move BiteSelection Top Buttons to Header in Landscape #65

Open
Raidakarim opened this issue Jun 6, 2023 · 1 comment
Open

Move BiteSelection Top Buttons to Header in Landscape #65

Raidakarim opened this issue Jun 6, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@Raidakarim
Copy link
Contributor

In landscape mode of BiteSelection Page, a lot of vertical space is “wasted” on Locate Place and Done Eating, when those buttons could potentially be in the empty space of the header (only in landscape mode). It’s not critical path, but is worth us keeping in mind for a future change.
IMG_3788

@Raidakarim Raidakarim added the enhancement New feature or request label Jun 6, 2023
@Raidakarim Raidakarim changed the title Move BiteSelection Top Buttons to Header Move BiteSelection Top Buttons to Header in Landscape Jun 6, 2023
@Raidakarim
Copy link
Contributor Author

Raidakarim commented Jun 11, 2023

Amal's suggestions for implementation:

  1. Delete PlateLocator.jsx — we will no longer have a specific plate locator, and instead only have a generic teleop interface. That generic teleop interface should be in the LiveVideoModal, so that way the user can close it and still stay on the same state. Add the arrow keys from PlateLocator to the LiveVideoModal.
  2. For DoneEating, always being in the header needs much further thought. If the robot is already moving and the user clicks DoneEating, what should happen? If it should cancel the previous action, that should be implemented. And what if DoneEating is clicked in a non-motion state? Then it shouldn't cancel the action. Further, the checkmark icon does not clearly communicate “click this when you’re done eating.” And finally, adding this really crowds up the header in portrait mode, which makes it confusing and not look good in my opinion.

@Raidakarim Raidakarim mentioned this issue Jun 11, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant