Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove isEmptyTextNode check #40

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/processNodes.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import isEmptyTextNode from './utils/isEmptyTextNode';
import convertNodeToElement from './convertNodeToElement';

/**
Expand All @@ -11,7 +10,6 @@ import convertNodeToElement from './convertNodeToElement';
export default function processNodes(nodes, transform) {

return nodes
.filter(node => !isEmptyTextNode(node))
.map((node, index) => {

// return the result of the transform function if applicable
Expand Down
10 changes: 0 additions & 10 deletions src/utils/isEmptyTextNode.js

This file was deleted.

6 changes: 6 additions & 0 deletions test/integration/integration.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -193,4 +193,10 @@ describe('Integration tests: ', () => {
expect(htmlparser2).toBeDefined();
});

it('should preserve whitespace with new lines between nodes', () => {
test(
'<strong>there should be</strong>\n <strong>a space</strong>',
'<strong>there should be</strong>\n <strong>a space</strong>'
);
});
});
18 changes: 0 additions & 18 deletions test/unit/processNodes.spec.js
Original file line number Diff line number Diff line change
@@ -1,34 +1,16 @@
const isEmptyTextNode = jasmine.createSpy('isEmptyTextNode');
const convertNodeToElement = jasmine.createSpy('convertNodeToElement');

const processNodes = require('inject!processNodes')({
'./utils/isEmptyTextNode': isEmptyTextNode,
'./convertNodeToElement': convertNodeToElement
}).default;

describe('Testing `processNodes`', () => {

beforeEach(() => {
isEmptyTextNode.calls.reset();
isEmptyTextNode.and.returnValue(false);
convertNodeToElement.calls.reset();
convertNodeToElement.and.callFake(node => node);
});

it('should filter out empty text nodes', () => {

isEmptyTextNode.and.callFake(node => node !== 'node2');

const nodes = [
'node1',
'node2',
'node3'
];

expect(processNodes(nodes)).toEqual(['node2']);

});

it('should return the response from the transform function if it is not undefined', () => {
const nodes = [
'node1',
Expand Down
32 changes: 0 additions & 32 deletions test/unit/utils/isEmptyTextNode.spec.js

This file was deleted.