-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Newmark integrator in time response method #1032
Add Newmark integrator in time response method #1032
Conversation
DescriptionThe Newmark integrator was implemented to take into account the speed variation in the rotor time response method. It can be used by passing an argument, The pseudo-modal method was also implemented to be considered in numerical integration, and it is only activated if the DoubtsI am not sure if what I did on lines 989-1011 of What do you think? TestsSome tests were carried out to evaluate the integrator response and are presented below. |
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1032 +/- ##
==========================================
- Coverage 85.32% 85.28% -0.05%
==========================================
Files 35 35
Lines 7620 7735 +115
==========================================
+ Hits 6502 6597 +95
- Misses 1118 1138 +20
Continue to review full report in Codecov by Sentry.
|
AdditionalResolves #884 I added a new argument that can be passed to the integrator """
add_to_RHS : callable, optional
An optional function that computes and returns an additional array to be added to
the right-hand side of the equation of motion. This function should take arguments
corresponding to the current state of the rotor system, including the time step
number, displacements, and velocities. It should return an array of the same length
as the degrees of freedom of the rotor system (`rotor.ndof`). This function allows
for the incorporation of supplementary terms or external effects in the rotor system
dynamics beyond the specified force input during the time integration process.
"""
def my_callable_function(step, displacement, velocity):
...
return ext_force
response = rotor.run_time_response(speed, F, t, integrator="newmark", add_to_RHS=my_callable_function) |
Resolves #1021
Hi @raphaeltimbo,
I created this pull request to report what I have been doing regarding the numerical integrator.
If there's anything I need to change, feel free to tell me.
I have some questions related to some of the implementations, and I will describe them better in the comments below.