Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal Integration #976

Closed

Conversation

marcusfilipesr
Copy link
Collaborator

@marcusfilipesr marcusfilipesr commented May 10, 2023

This PR is devoted to implementing a new integration inside ROSS, using the modal reduction. The main goal is to enable the solution of #429, #530 and #884.

This PR itself, does not solve any of the cited issues yet, i.e., it is a pre solution.

  • Insert the modal analysis to perform the time integration.
  • Rearrange the integrate_solver file.
  • Verify robustness of the automatic number of modes. ( Forced inputs? )
  • Run benchmark code with different number of modes evaluating the error

@marcusfilipesr
Copy link
Collaborator Author

I've just implementend the integration method. It's lacking the tests, which I'll be implementing tomorrow.

@codecov-commenter
Copy link

codecov-commenter commented May 10, 2023

Codecov Report

Merging #976 (fe5c9c0) into main (ee6e3f0) will decrease coverage by 0.46%.
The diff coverage is 58.59%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #976      +/-   ##
==========================================
- Coverage   85.56%   85.11%   -0.46%     
==========================================
  Files          34       34              
  Lines        7530     7650     +120     
==========================================
+ Hits         6443     6511      +68     
- Misses       1087     1139      +52     
Files Changed Coverage Δ
ross/defects/integrate_solver.py 56.32% <14.28%> (-39.52%) ⬇️
ross/rotor_assembly.py 92.40% <80.23%> (-0.85%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee6e3f0...fe5c9c0. Read the comment docs.

@marcusfilipesr
Copy link
Collaborator Author

@raphaeltimbo I think I've finished the first step which was:

  • Insert the modal analysis to perform the time integration.

I think it would be better to go slowly, so I will keep this branch without changes until your review. What do you think?

Copy link
Collaborator

@raphaeltimbo raphaeltimbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some small comments for now.
I think we should, in parallel, solve the issue #978, so that we can benchmark this new integrator.

ross/rotor_assembly.py Outdated Show resolved Hide resolved
ross/rotor_assembly.py Outdated Show resolved Hide resolved
@ross-bott
Copy link
Collaborator

Hi there!
I have marked this issue as stale because it has not had activity for 45 days.
Consider the following options:

  • If the issue refers to a large task, break it in smaller issues that can be solved in
    less than 45 days;
  • Label the issue as wontfix or wontfix for now and close it.

@ross-bott ross-bott added the stale Issues with no activity for a long period label Nov 3, 2023
@raphaeltimbo
Copy link
Collaborator

We have implemented the newmark integration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Issues with no activity for a long period
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants