Syntax changes/poisson pdf #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixzinn
force-pushed
the
syntax-changes/poisson-pdf
branch
from
2dbc4db to
29ba13b
Compare
now the Poisson pdf takes the expectation directly as a value (not the parameter) the `get_log_probs` function for the parameters was updated accordingly
normalization is now optional with default=True
felixzinn
force-pushed
the
syntax-changes/poisson-pdf
branch
from
57646d1 to
5a2bd1c
Compare
|
thanks! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The syntax of the Poisson pdf is changed such that it takes the expectation directly (not the parameter value) and can be evaluated at a specific observation.
It can take continuous values for the observation as well which
evermore.loss.PoissonLogLikelihoodcan not. With the new syntaxPoissonLogLikelihoodshould not be necessary anymore.