-
-
Notifications
You must be signed in to change notification settings - Fork 59
Added Kushagra Gupta to contributors in pgRouting-introduction.rst #521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughThe changes update contributor attribution across documentation and locale files. Kushagra Gupta is added to the "Individuals (in alphabetical order)" contributors list, replacing a previous entry. Locale metadata timestamps are updated to reflect current generation dates. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
locale/pot/pgrouting_doc_strings.pot (1)
9-17: POT-Creation-Date churn: OK, but consider reproducible builds if desired.Updating
POT-Creation-Dateis expected when regenerating catalogs; if you want fewer noisy diffs across rebuilds, consider configuring the tooling for reproducible timestamps (e.g.,SOURCE_DATE_EPOCH) rather than embedding the current time.
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
doc/src/pgRouting-introduction.rstlocale/en/LC_MESSAGES/pgrouting_doc_strings.polocale/pot/pgrouting_doc_strings.pot
🔇 Additional comments (4)
doc/src/pgRouting-introduction.rst (1)
149-149: ✓ Contributor addition is correctly formatted and alphabetically ordered.The new entry "Kushagra Gupta" is properly positioned in the alphabetized list and follows the existing formatting convention. The alphabetical order is maintained correctly between "Ko Nagase" and "Mahmoud Sakr".
locale/pot/pgrouting_doc_strings.pot (1)
7198-7206: Contributor list update looks consistent; confirm whether “Kishore Kumar” should remain listed.The updated
msgidadds “Kushagra Gupta” and keeps alphabetical ordering in the “Ki/Ko/Ku” region. If the intent was to replace an existing entry, double-check whether “Kishore Kumar” should still be present.locale/en/LC_MESSAGES/pgrouting_doc_strings.po (2)
8395-8401: Whitespace and format consistency are correct. "Ko Nagase" and "Kushagra Gupta" are properly spaced across line breaks, and the alphabetical order is maintained throughout the contributor list. The PO file structure is valid.
11-11: I need the review comment content (within<review_comment>tags) to verify and rewrite. Please provide the review comment you'd like me to analyze.
Fixes # .
Changes proposed in this pull request:
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.