Skip to content
This repository was archived by the owner on Mar 8, 2024. It is now read-only.

refactor!: IPFS injection done right#27

Open
UnKnoWn-Consortium wants to merge 2 commits intopgc-13:masterfrom
UnKnoWn-Consortium:ipfs-injection-by-factory
Open

refactor!: IPFS injection done right#27
UnKnoWn-Consortium wants to merge 2 commits intopgc-13:masterfrom
UnKnoWn-Consortium:ipfs-injection-by-factory

Conversation

@UnKnoWn-Consortium
Copy link

The loader class is now wrapped in a factory function with IPFS instance injected. Close #24.

@UnKnoWn-Consortium UnKnoWn-Consortium force-pushed the ipfs-injection-by-factory branch from e4d634e to 297ab48 Compare January 17, 2021 13:15
@UnKnoWn-Consortium UnKnoWn-Consortium changed the title refactor: IPFS injection done right refactor!: IPFS injection done right Jan 17, 2021
@UnKnoWn-Consortium UnKnoWn-Consortium force-pushed the ipfs-injection-by-factory branch from 835c58b to 902bc8f Compare January 17, 2021 13:35
…h a factory function

BREAKING CHANGE: the main export is now a factory function that returns the loader class with IPFS dependency injected.
@UnKnoWn-Consortium UnKnoWn-Consortium force-pushed the ipfs-injection-by-factory branch from 902bc8f to 2799c60 Compare January 17, 2021 17:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JS IPFS instance supplied via hls.config prevents Hls.js from kicking off its demuxing web worker

1 participant