fix conflicting bbox setting between pgfsys-dvisvgm and dvisvgm command; #1276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agrahn
force-pushed
the
dvisvgm-bbox
branch
from
b9e82b0 to
5c097e9
Compare
muzimuzhi
reviewed
Sep 13, 2023
fixes pgf-tikz#1275 Signed-off-by: Alexander Grahn <[email protected]>
agrahn
force-pushed
the
dvisvgm-bbox
branch
from
5c097e9 to
e4ef1d3
Compare
Contributor
Author
|
@hmenke, @muzimuzhi Do you think this PR could be merged? If something is still missing, please let me know. |
muzimuzhi
approved these changes
Sep 20, 2023
Member
muzimuzhi
left a comment
muzimuzhi
left a comment
There was a problem hiding this comment.
Only a soft styling suggestion.
As I said in #1275 (comment), currently most PRs are blocked by #1116, except for simple typo corrections.
Co-authored-by: Yukai Chou <[email protected]>
hmenke
approved these changes
Sep 20, 2023
drgrice1
added a commit
to drgrice1/webwork2
that referenced
this pull request
Feb 22, 2024
This patch is applied in the docker build. It can be applied on your server with the command `sudo patch -p1 -d / < /opt/webwork/webwork2/docker-config/pgfsys-dvisvmg-bbox-fix.patch.patch` Note this patch is specific to Ubuntu 22.04, so don't try it on other versions of Ubuntu or other linux distributions. This was the change made in pgf-tikz/pgf#1276 that was merged into the master branch of the to the pgf-tikz latex package on October 23, 2023 that fixes the issue reported in pgf-tikz/pgf#1275.
drgrice1
added a commit
to drgrice1/webwork2
that referenced
this pull request
Feb 22, 2024
This patch is applied in the docker build. It can be applied on your server with the command `sudo patch -p1 -d / < /opt/webwork/webwork2/docker-config/pgfsys-dvisvmg-bbox-fix.patch.patch` Note this patch is specific to Ubuntu 22.04, so don't try it on other versions of Ubuntu or other linux distributions. This was the change made in pgf-tikz/pgf#1276 that was merged into the master branch of the to the pgf-tikz latex package on October 23, 2023 that fixes the issue reported in pgf-tikz/pgf#1275.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
fixes #1275
Checklist
Please signoff your commits to explicitly state your agreement to the Developer Certificate of Origin. If that is not possible you may check the boxes below instead: