Pimp lua examples (addresses issues #640 #839)#883
Pimp lua examples (addresses issues #640 #839)#883Mo-Gul wants to merge 3 commits intopgf-tikz:masterfrom
Conversation
So far this is done as @hmenke suggested, i.e. the libraries are only shown for the first example if multiple examples are given.
ilayn
left a comment
ilayn
left a comment
There was a problem hiding this comment.
Don't know much about Lua parts but looks good to me (except that CI error and a minor comment).
| algorithms from the graph drawing libraries to get a better layout. For | ||
| instance, adding |tree layout| to the above code results in the following | ||
| somewhat more pleasing rendering: | ||
| instance, adding |tree layout| to the above code (and |
There was a problem hiding this comment.
@ilayn, sorry, I thought that I had commented on that already, but it seems that didn't work. So here "again".
You are absolutely right. This is, because I did that change in my forks master branch before following your suggestions to do new changes only in branches. A day after doing these changes I thought that I maybe could have avoided that by checking out the commit before I made that change and creating a branch from there.(?)
I hope that I don't have to do everything again, because this is hopefully a trivial change and therefore doesn't mess up anything when this is applied again.
There was a problem hiding this comment.
No problem I'll edit this issue text and they will all be closed automagically once this is merged. I think you fought well with git.
|
The CI failure is a bug in l3backend. |
|
I edited the issue description to close the other relevant issues and PRs. Please go over them once if I did the right ones. Then ready when you are ready. |
|
The mentioned issues and pull requests are right, thank you. While the last two could already be merged, the first one will still take a while I guess (as is also mentioned in the first comment here). |
3 participants
Closes #640
Closes #755
Closes #881