Switch Lint Checks in pre-commit (#1897)

* Switch Lint Checks in pre-commit

* standardrb fixes

* Fix the fixes

Author: pglombardo

.erb-lint.yml

@@ -0,0 +1,9 @@
+---
+exclude:
+  - 'vendor/bundle/**/*'
+EnableDefaultLinters: true
+linters:
+  SpaceAroundErbTag:
+    enabled: true
+  ExtraNewline:
+    enabled: true

.pre-commit-config.yaml

@@ -2,7 +2,7 @@
 # See https://pre-commit.com/hooks.html for more hooks
 repos:
 - repo: https://github.com/pre-commit/pre-commit-hooks
-  rev: v3.2.0
+  rev: v3.4.0
   hooks:
     - id: trailing-whitespace
       exclude: '\.enc$'
@@ -13,11 +13,20 @@ repos:
 
 - repo: local
   hooks:
-    - id: rubocop
-      name: Running rubocop
-      entry: rubocop
+    - id: erblint
+      name: ERBLint
+      entry: erblint
       language: system
-      pass_filenames: false
-      #args: ['-a']
-      always_run: true
-      stages: [pre-commit]
+      types: [html]
+      files: \.html\.erb$
+      pass_filenames: true
+
+- repo: local
+  hooks:
+    - id: standardrb
+      name: standardrb
+      entry: standardrb
+      language: system
+      types: [ruby]
+      files: \.rb$
+      pass_filenames: true

Gemfile

@@ -1,45 +1,48 @@
 # frozen_string_literal: true
 
-source 'https://rubygems.org'
+source "https://rubygems.org"
 
-ruby ENV['CUSTOM_RUBY_VERSION'] || '>=3.1.4'
+ruby ENV["CUSTOM_RUBY_VERSION"] || ">=3.1.4"
 
-gem 'rails', '~> 7.1.3'
+gem "rails", "~> 7.1.3"
 
 group :development do
-  gem 'listen'
+  gem "listen"
 
   # Visual Studio Additions
-  gem 'rubocop'
-  gem 'rubocop-performance'
-  gem 'rubocop-rails'
-  gem 'ruby-debug-ide'
+  gem "ruby-debug-ide"
 
-  gem 'pry-rails'
+  gem "pry-rails"
 
   # Access an interactive console on exception pages or by
   # calling 'console' anywhere in the code.
-  gem 'web-console', '>= 4.2.0'
+  gem "web-console", ">= 4.2.0"
+
+  gem "derailed_benchmarks"
+  gem "stackprof"
 end
 
 group :test do
   # Adds support for Capybara system testing and selenium driver
-  gem 'capybara', '>= 3.37.1', '< 4.0'
-  gem 'minitest'
-  gem 'minitest-rails', '>= 6.1.0'
-  gem 'minitest-reporters'
-  gem 'selenium-webdriver'
-  gem 'webdrivers', '~> 5.3', require: false
+  gem "capybara", ">= 3.37.1", "< 4.0"
+  gem "minitest"
+  gem "minitest-rails", ">= 6.1.0"
+  gem "minitest-reporters"
+  gem "selenium-webdriver"
+  gem "webdrivers", "~> 5.3", require: false
 end
 
 group :development, :test do
   # See https://guides.rubyonrails.org/debugging_rails_applications.html#debugging-with-the-debug-gem
-  gem 'debase', '>= 0.2.5.beta2', platforms: %i[mri mingw x64_mingw]
-  gem 'debug', platforms: %i[mri mingw x64_mingw]
+  gem "debase", ">= 0.2.5.beta2", platforms: %i[mri mingw x64_mingw]
+  gem "debug", platforms: %i[mri mingw x64_mingw]
+
+  gem "erb_lint", "~> 0.5.0"
+  gem "standardrb", "~> 1.0"
 end
 
-gem 'rack-attack'
-gem 'rack-cors'
+gem "rack-attack"
+gem "rack-cors"
 
 # OSX: ../src/utils.h:33:10: fatal error: 'climits' file not found
 # From:
@@ -53,70 +56,67 @@ gem 'rack-cors'
 # $ bundle install
 # gem 'therubyracer'
 #
-gem 'high_voltage'
-gem 'kramdown', require: false
-gem 'lockbox'
+gem "high_voltage"
+gem "kramdown", require: false
+gem "lockbox"
 
 # Reduces boot times through caching; required in config/boot.rb
-gem 'bootsnap', '>= 1.4.4', require: false
+gem "bootsnap", ">= 1.4.4", require: false
 
 # Use SCSS for stylesheets
-gem 'sass-rails', '~> 6.0', '>= 6.0.0'
-gem 'terser', '~> 1.2'
+gem "sass-rails", "~> 6.0", ">= 6.0.0"
+gem "terser", "~> 1.2"
 # Build JSON APIs with ease. Read more: https://github.com/rails/jbuilder
-gem 'bootstrap', '5.2.3'
-gem 'json', '~> 2.7' # Legacy carry-over
-gem 'will_paginate', '~> 4.0.0'
-gem 'will_paginate-bootstrap-style'
+gem "bootstrap", "5.2.3"
+gem "json", "~> 2.7" # Legacy carry-over
+gem "will_paginate", "~> 4.0.0"
+gem "will_paginate-bootstrap-style"
 
 # Hotwire's SPA-like page accelerator [https://turbo.hotwired.dev]
-gem 'turbo-rails'
+gem "turbo-rails"
 # Hotwire's modest JavaScript framework [https://stimulus.hotwired.dev]
-gem 'stimulus-rails'
+gem "stimulus-rails"
 # Build JSON APIs with ease [https://github.com/rails/jbuilder]
-gem 'jbuilder'
+gem "jbuilder"
 
 # Use Redis adapter to run Action Cable in production
 # gem 'redis', '~> 4.0'
 # Use ActiveModel has_secure_password
 # gem 'bcrypt', '~> 3.1.7'
 
-gem 'apipie-rails'
-gem 'config'
-gem 'devise', '>= 4.9.0'
-gem 'foreman'
-gem 'lograge'
-gem 'mail_form', '>= 1.9.0'
-gem 'oj'
-gem 'puma'
-gem 'rollbar'
-gem 'simple_token_authentication'
-
-gem 'devise-i18n'
-gem 'i18n-tasks', '~> 1.0.13' # , group: :development
-gem 'rails-i18n', '~> 7.0.8'
-gem 'route_translator', '>= 13.0.0'
-gem 'translation'
+gem "apipie-rails"
+gem "config"
+gem "devise", ">= 4.9.0"
+gem "foreman"
+gem "lograge"
+gem "mail_form", ">= 1.9.0"
+gem "oj"
+gem "puma"
+gem "rollbar"
+gem "simple_token_authentication"
+
+gem "devise-i18n"
+gem "i18n-tasks", "~> 1.0.13" # , group: :development
+gem "rails-i18n", "~> 7.0.8"
+gem "route_translator", ">= 13.0.0"
+gem "translation"
 
 # For File Uploads
-gem 'aws-sdk-s3', require: false
-gem 'azure-storage-blob', '~> 2.0', require: false
-gem 'google-cloud-storage', '~> 1.48', require: false
+gem "aws-sdk-s3", require: false
+gem "azure-storage-blob", "~> 2.0", require: false
+gem "google-cloud-storage", "~> 1.48", require: false
 
 # Windows does not include zoneinfo files, so bundle the tzinfo-data gem
-gem 'tzinfo-data', platforms: %i[mingw mswin x64_mingw jruby]
+gem "tzinfo-data", platforms: %i[mingw mswin x64_mingw jruby]
 
 # Database backends
-gem 'mysql2'
-gem 'pg'
-gem 'sqlite3', force_ruby_platform: true
+gem "mysql2"
+gem "pg"
+gem "sqlite3", force_ruby_platform: true
 
 group :production do
-  gem 'rack-throttle', '0.7.0'
-  gem 'rack-timeout'
+  gem "rack-throttle", "0.7.0"
+  gem "rack-timeout"
 end
 
-gem 'version', git: 'https://github.com/pglombardo/version.git', branch: 'master'
-
-gem 'derailed_benchmarks', group: :development
-gem 'stackprof', group: :development
+gem "version", git: "https://github.com/pglombardo/version.git", branch: "master"

Gemfile.lock

@@ -218,6 +218,13 @@ GEM
       dry-initializer (~> 3.0)
       dry-schema (>= 1.12, < 2)
       zeitwerk (~> 2.6)
+    erb_lint (0.5.0)
+      activesupport
+      better_html (>= 2.0.1)
+      parser (>= 2.7.1.4)
+      rainbow
+      rubocop
+      smart_properties
     erubi (1.12.0)
     execjs (2.9.1)
     faraday (1.10.3)
@@ -323,6 +330,7 @@ GEM
     kramdown (2.4.0)
       rexml
     language_server-protocol (3.17.0.3)
+    lint_roller (1.1.0)
     listen (3.8.0)
       rb-fsevent (~> 0.10, >= 0.10.3)
       rb-inotify (~> 0.9, >= 0.9.10)
@@ -501,11 +509,6 @@ GEM
     rubocop-performance (1.20.2)
       rubocop (>= 1.48.1, < 2.0)
       rubocop-ast (>= 1.30.0, < 2.0)
-    rubocop-rails (2.23.1)
-      activesupport (>= 4.2.0)
-      rack (>= 1.1)
-      rubocop (>= 1.33.0, < 2.0)
-      rubocop-ast (>= 1.30.0, < 2.0)
     ruby-debug-ide (0.7.3)
       rake (>= 0.8.1)
     ruby-progressbar (1.13.0)
@@ -547,6 +550,20 @@ GEM
     sqlite3 (1.7.2)
       mini_portile2 (~> 2.8.0)
     stackprof (0.2.26)
+    standard (1.34.0)
+      language_server-protocol (~> 3.17.0.2)
+      lint_roller (~> 1.0)
+      rubocop (~> 1.60)
+      standard-custom (~> 1.0.0)
+      standard-performance (~> 1.3)
+    standard-custom (1.0.2)
+      lint_roller (~> 1.0)
+      rubocop (~> 1.50)
+    standard-performance (1.3.1)
+      lint_roller (~> 1.1)
+      rubocop-performance (~> 1.20.2)
+    standardrb (1.0.1)
+      standard
     stimulus-rails (1.3.3)
       railties (>= 6.0.0)
     stringio (3.1.0)
@@ -609,6 +626,7 @@ DEPENDENCIES
   derailed_benchmarks
   devise (>= 4.9.0)
   devise-i18n
+  erb_lint (~> 0.5.0)
   foreman
   google-cloud-storage (~> 1.48)
   high_voltage
@@ -636,15 +654,13 @@ DEPENDENCIES
   rails-i18n (~> 7.0.8)
   rollbar
   route_translator (>= 13.0.0)
-  rubocop
-  rubocop-performance
-  rubocop-rails
   ruby-debug-ide
   sass-rails (~> 6.0, >= 6.0.0)
   selenium-webdriver
   simple_token_authentication
   sqlite3
   stackprof
+  standardrb (~> 1.0)
   stimulus-rails
   terser (~> 1.2)
   translation

Rakefile

@@ -3,13 +3,13 @@
 # Add your own tasks in files placed in lib/tasks ending in .rake,
 # for example lib/tasks/capistrano.rake, and they will automatically be available to Rake.
 
-require File.expand_path('config/application', __dir__)
+require File.expand_path("config/application", __dir__)
 
 PasswordPusher::Application.load_tasks
 
 # Add version gem rake tasks
-require 'rake/version_task'
+require "rake/version_task"
 Rake::VersionTask.new do |task|
   task.with_git_tag = true
-  task.git_tag_prefix = 'v'
+  task.git_tag_prefix = "v"
 end

app/controllers/application_controller.rb

@@ -8,10 +8,10 @@ class ApplicationController < ActionController::Base
 
   def custom_set_locale_from_url
     locale_from_url = RouteTranslator.locale_from_params(params) ||
-                      RouteTranslator::Host.locale_from_host(request.host) ||
-                      I18n.default_locale
+      RouteTranslator::Host.locale_from_host(request.host) ||
+      I18n.default_locale
     if locale_from_url
-      old_locale  = I18n.locale
+      old_locale = I18n.locale
       I18n.locale = locale_from_url
     end
 
@@ -21,15 +21,15 @@ def custom_set_locale_from_url
   end
 
   def not_found
-    raise ActionController::RoutingError, _('Not Found')
+    raise ActionController::RoutingError, _("Not Found")
   end
 
   private
 
   def render_error(status, _exception)
     respond_to do |format|
-      format.html { render template: "errors/error_#{status}", layout: 'layouts/application', status: }
-      format.all  { render nothing: true, status: }
+      format.html { render template: "errors/error_#{status}", layout: "layouts/application", status: }
+      format.all { render nothing: true, status: }
     end
   end
 end

app/controllers/feedbacks_controller.rb

@@ -12,16 +12,16 @@ def create
     # valid? will tell us if the humanity test was answered correctly
     if @feedback.spam? || !@feedback.valid?
       flash[:alert] =
-        _('Our apologies but you failed the spam check.  You could try contacting us on Github instead.')
+        _("Our apologies but you failed the spam check.  You could try contacting us on Github instead.")
       render :new, status: :unprocessable_entity
     else
       @feedback.request = request
       if @feedback.deliver
         redirect_to root_path,
-                    notice: _('Feedback sent!  We will get back to you as soon as possible.')
+          notice: _("Feedback sent!  We will get back to you as soon as possible.")
       else
         flash[:alert] =
-          _('Could not send feedback.  Did you pass the Humanity Test?  Valid email?  Try again?')
+          _("Could not send feedback.  Did you pass the Humanity Test?  Valid email?  Try again?")
         render :new, status: :unprocessable_entity
       end
     end