Skip to content

Add QR Code pushes #3418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Jun 12, 2025
Merged

Add QR Code pushes #3418

merged 22 commits into from
Jun 12, 2025

Conversation

ozovalihasan
Copy link
Collaborator

@ozovalihasan ozovalihasan commented Jun 3, 2025

Description

It is requested to use QR code pushes. So, this feature is implemented by using a new qr kind.

Related Issue

#2525

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Checklist

  • I've written tests (if applicable) for all new methods and classes that I created. (rake test)
  • I've added documentation as necessary so users can easily use and understand this feature/fix.
    -- I have added very limited documentation for QR pushes.

@ozovalihasan ozovalihasan marked this pull request as ready for review June 3, 2025 10:49
@ozovalihasan ozovalihasan requested a review from pglombardo June 3, 2025 10:49
@pglombardo pglombardo mentioned this pull request Jun 3, 2025
6 tasks
@ozovalihasan ozovalihasan requested a review from Copilot June 3, 2025 16:39
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new "qr" push type that supports QR code generation for secure sharing of content. Key changes include adding "qr" as an option in the Push model with associated validations, updating controllers and routes to support QR pushes, and providing new views and integration tests for creating and displaying QR code pushes.

Reviewed Changes

Copilot reviewed 32 out of 32 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
test/integration/qr/* New integration tests covering QR push creation, authentication, audit logging, and anonymous access.
config/settings*.yml Added configuration settings for QR pushes including expiration and retrieval options.
app/views/pushes/* Updated views and partials to add a QR form and display QR codes in the push show page.
app/models/push.rb Extended the enum to include the "qr" kind and added payload validation for QR pushes.
app/controllers/pushes_controller.rb Updated controller logic to handle the new "qr" type and enforce authentication as needed.
app/controllers/api/v1/pushes_controller.rb Updated API endpoints to include the "qr" type.
app/helpers/pushes_helper.rb Imported the necessary library for QR code generation.

@pglombardo
Copy link
Owner

@ozovalihasan tested and looks great. One item, can you update the "Save the above settings as the page default." - it's still saving under password cookies.

@ozovalihasan
Copy link
Collaborator Author

can you update the "Save the above settings as the page default." - it's still saving under password cookies.

Good catch 🚀 . It is updated. @pglombardo

@ozovalihasan
Copy link
Collaborator Author

https://docs.pwpush.com/docs/self-hosted-configuration/#application-general

Settings for QR Code should be added 📝

@pglombardo pglombardo merged commit 647e747 into master Jun 12, 2025
6 checks passed
@pglombardo pglombardo deleted the add-qr-pushes branch June 12, 2025 15:12
@pglombardo
Copy link
Owner

Added new QR push documentation here: https://docs.pwpush.com/docs/self-hosted-configuration/#qr-pushes

@ozovalihasan ozovalihasan mentioned this pull request Jun 12, 2025
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants