-
Notifications
You must be signed in to change notification settings - Fork 398
Add QR Code pushes #3418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add QR Code pushes #3418
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a new "qr" push type that supports QR code generation for secure sharing of content. Key changes include adding "qr" as an option in the Push model with associated validations, updating controllers and routes to support QR pushes, and providing new views and integration tests for creating and displaying QR code pushes.
Reviewed Changes
Copilot reviewed 32 out of 32 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
test/integration/qr/* | New integration tests covering QR push creation, authentication, audit logging, and anonymous access. |
config/settings*.yml | Added configuration settings for QR pushes including expiration and retrieval options. |
app/views/pushes/* | Updated views and partials to add a QR form and display QR codes in the push show page. |
app/models/push.rb | Extended the enum to include the "qr" kind and added payload validation for QR pushes. |
app/controllers/pushes_controller.rb | Updated controller logic to handle the new "qr" type and enforce authentication as needed. |
app/controllers/api/v1/pushes_controller.rb | Updated API endpoints to include the "qr" type. |
app/helpers/pushes_helper.rb | Imported the necessary library for QR code generation. |
@ozovalihasan tested and looks great. One item, can you update the "Save the above settings as the page default." - it's still saving under |
Good catch 🚀 . It is updated. @pglombardo |
https://docs.pwpush.com/docs/self-hosted-configuration/#application-general Settings for QR Code should be added 📝 |
Added new QR push documentation here: https://docs.pwpush.com/docs/self-hosted-configuration/#qr-pushes |
Description
It is requested to use QR code pushes. So, this feature is implemented by using a new
qr
kind.Related Issue
#2525
Type of Change
Checklist
rake test
)-- I have added very limited documentation for QR pushes.