Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qual: Add pre-commit configuration & action #97

Merged
merged 1 commit into from
Feb 21, 2024
Merged

qual: Add pre-commit configuration & action #97

merged 1 commit into from
Feb 21, 2024

Conversation

mdeweerd
Copy link
Contributor

@mdeweerd mdeweerd commented Feb 7, 2024

qual: Add pre-commit configuration & action

This pre-commit configuration adds different quality checks to the repository.

@mdeweerd
Copy link
Contributor Author

Once the install PR and typos PR are integrated, only a few notifications will remain for bash_unit and apparently the hello world example.

The shellcheck results for bash_unit that remain are best checked by the author IMHO, hello world was overlooked, but there's just a few lines.

# qual: Add pre-commit configuration & action

This pre-commit configuration adds different quality checks to the
repository.
@pgrange pgrange merged commit 308c139 into pgrange:master Feb 21, 2024
1 check failed
@pgrange
Copy link
Owner

pgrange commented Feb 21, 2024

So now I'm using pre-commit... so cool. Thank you @mdeweerd

@mdeweerd mdeweerd deleted the pre-commit branch February 21, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants