Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

two finger swipe gesture implementation #3

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

two finger swipe gesture implementation #3

wants to merge 2 commits into from

Conversation

Alsan
Copy link
Contributor

@Alsan Alsan commented Oct 11, 2020

Add mac like two finger swipe gesture. Most of the changes are from my code formatter, hope you won't mind.

@pguedes
Copy link
Owner

pguedes commented Oct 14, 2020

hi @Alsan ,

thanks for the contribution!

have you tested this to see how it interacts with scrolling? i assumed 2 fingers were always used for scrolling... what to macs do with two finger gestures?

@Alsan
Copy link
Contributor Author

Alsan commented Oct 15, 2020

Personally, I don't use Mac. As my understanding, there's no horizontal scroll in Mac, they use three fingers drag (the horizontal scroll bar, also apply to the vertical scroll bar) for scrolling, and two finger swipe horizontally is for switching desktop, just like I did.

My implementation, only two fingers swipe is captured. Two fingers swipe vertically or the drag event is ignored, they handled by libinput. And therefore, two fingers drag horzontally or vertically or simultaneously is possible for scrolling the window.

@Alsan
Copy link
Contributor Author

Alsan commented Oct 15, 2020

Ok, just find someone with Mac to test the two finger horizontal scroll, they're supported with context. That means, they are scrolled when the windows with horizontal scrollbar and switching desktop if they don't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants