Include the reference model name in the build query when getting rela…#16655
Merged
niden merged 4 commits intophalcon:5.0.xfrom Oct 21, 2024
Merged
Include the reference model name in the build query when getting rela…#16655niden merged 4 commits intophalcon:5.0.xfrom
niden merged 4 commits intophalcon:5.0.xfrom
Conversation
…ted records When we overload the getRelated function and join more tables, it can happen that the referencedField/s can't be mapped back correctly to the referenceModel it not specified
Contributor
Author
|
Before the fix The column 'id' is ambiguous, when preparing: after this patch request Now SQL is correctly formatted |
Member
|
@alrieckert If you don't mind, can you add a line to the CHANGELOG regarding this? After that I will merge it. Thank you so much |
niden
approved these changes
Oct 2, 2024
Member
|
Thank you @alrieckert |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ted records
When we overload the getRelated function and join more tables, it can happen that the referencedField/s can't be mapped back correctly to the referenceModel it not specified
Hello!
In raising this pull request, I confirm the following:
Small description of change:
Thanks