fix #16818: override memcached options correctly#16819
Merged
niden merged 1 commit intophalcon:5.0.xfrom Nov 14, 2025
Merged
Conversation
niden
approved these changes
Nov 14, 2025
Member
|
@tashik Thank you. Good catch |
Contributor
Author
|
@niden, OPT_CONNECT_TIMEOUT in Memcached is in milliseconds, I think to have the default 10 ms is not suitable for production with one memcached. Please, consider to set the default at least 50 ms |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
In raising this pull request, I confirm the following:
Small description of change:
Fixes merging numeric arrays keeping keys safe for \Memcached options constants
Thanks
Natalya