Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removal of vestigial gensim import #127

Closed
wants to merge 2 commits into from
Closed

removal of vestigial gensim import #127

wants to merge 2 commits into from

Conversation

mgudorf
Copy link

@mgudorf mgudorf commented Jul 13, 2021

deepwalk.skipgram imports but does not use an object from gensim, Vocab , which has been removed in gensim>=4.0.0. It wasn't being used anyway so this doesn't affect anything; other than allowing deepwalk to be ran in command line once more. Technically, I only ran deepwalk --help because I just recently cloned the repo, so there could be other gensim compatibility issues elsewhere as well.

@GTmac
Copy link
Collaborator

GTmac commented Jul 13, 2021

Thanks for working on this! Running deepwalk --help doesn't trigger the training of DeepWalk model. Could you run DeepWalk on some graph (you could refer to the commands in README), and ensure it still works? Thank you!

@mgudorf
Copy link
Author

mgudorf commented Jul 13, 2021

Word2Vec also had a keyword argument change, namely, size was changed to vector_size; the most recent commit accounts for this; I ran the command line with default arguments in the edgelist format; unsure if there are differences in dependencies for different formats. If there's anything else you would like me to check out let me know! @GTmac

$ deepwalk --format edgelist --input edgelist.txt --output deepdish.txt
Number of nodes: 115
Number of walks: 1150
Data size (walks*length): 46000
Walking...
Training...

@mgudorf
Copy link
Author

mgudorf commented Jul 13, 2021

This is linked to issues #125 and #123 (the latter being closed)

@mgudorf mgudorf closed this by deleting the head repository Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants