Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added DM parameter and merge when SITEID variable exists #401

Open
wants to merge 4 commits into
base: devel
Choose a base branch
from
Open

Added DM parameter and merge when SITEID variable exists #401

wants to merge 4 commits into from

Conversation

AlcJ123
Copy link
Collaborator

@AlcJ123 AlcJ123 commented Jul 16, 2024

Added DM parameter and merge when SITEID variable exists

@harriscw

Closes #270

@harriscw
Copy link
Collaborator

harriscw commented Jul 16, 2024 •
edited by AlcJ123
Loading

  • Default to DM=NULL, add logic for if !is.null(DM)?
  • Need to update sdtmchecksmeta for DM (Will to do)
  • Assuming DM is defaulted to NULL, we don't need to update existing unit tests. But we should add additional unit tests for the new DM code.

Alcaraz, Josue {TBB~SOUTH SAN FRANCISCO} and others added 2 commits July 25, 2024 03:31
Default to DM=NULL, added logic for if !is.null(DM) for both function…
cdc46a4 
…s. Created new unit checks for when DM has and does not have siteid variable.
@AlcJ123
Update documentation
83f45bf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add DM.SITEID to LB checks
2 participants
@AlcJ123 @harriscw